From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE20C43331 for ; Thu, 7 Nov 2019 18:08:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F2ED120869 for ; Thu, 7 Nov 2019 18:08:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2ED120869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9C4B26B0003; Thu, 7 Nov 2019 13:08:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 974756B0008; Thu, 7 Nov 2019 13:08:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83CD16B000A; Thu, 7 Nov 2019 13:08:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id 6F9CE6B0003 for ; Thu, 7 Nov 2019 13:08:58 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 16ACF1EF2 for ; Thu, 7 Nov 2019 18:08:58 +0000 (UTC) X-FDA: 76130267556.24.ocean17_13f888030541c X-HE-Tag: ocean17_13f888030541c X-Filterd-Recvd-Size: 6690 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Nov 2019 18:08:57 +0000 (UTC) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id xA7I7MF2083378 for ; Thu, 7 Nov 2019 13:08:55 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2w4pdenh71-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 07 Nov 2019 13:08:55 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Nov 2019 18:08:52 -0000 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 7 Nov 2019 18:08:43 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xA7I86IF10486184 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Nov 2019 18:08:06 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F06D64C044; Thu, 7 Nov 2019 18:08:41 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BFE874C04E; Thu, 7 Nov 2019 18:08:40 +0000 (GMT) Received: from pic2.home (unknown [9.145.15.120]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 7 Nov 2019 18:08:40 +0000 (GMT) Subject: Re: [PATCH 10/10] ocxl: Conditionally bind SCM devices to the generic OCXL driver To: "Alastair D'Silva" , alastair@d-silva.org Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Keith Busch , Ira Weiny , Geert Uytterhoeven , Anton Blanchard , Krzysztof Kozlowski , Vasant Hegde , David Gibson , Hari Bathini , Allison Randal , Anju T Sudhakar , Mahesh Salgaonkar , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , Andrew Morton , David Hildenbrand , Oscar Salvador , Michal Hocko , Pavel Tatashin , Wei Yang , Qian Cai , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org References: <20191025044721.16617-1-alastair@au1.ibm.com> <20191025044721.16617-11-alastair@au1.ibm.com> From: Frederic Barrat Date: Thu, 7 Nov 2019 19:08:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191025044721.16617-11-alastair@au1.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 19110718-0012-0000-0000-00000361A638 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19110718-0013-0000-0000-0000219D084A Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-11-07_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911070167 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 25/10/2019 =C3=A0 06:47, Alastair D'Silva a =C3=A9crit=C2=A0: > From: Alastair D'Silva >=20 > This patch allows the user to bind OpenCAPI SCM devices to the generic = OCXL > driver. >=20 > Signed-off-by: Alastair D'Silva > --- I'm wondering if we should upstream this. Is it of any use outside of=20 some serious debug session for a developer? Also we would now have 2 drivers picking up the same device ID, since=20 the SCM driver is always registering for that ID, irrespective of=20 CONFIG_OCXL_SCM_GENERIC Fred > drivers/misc/ocxl/Kconfig | 7 +++++++ > drivers/misc/ocxl/pci.c | 3 +++ > 2 files changed, 10 insertions(+) >=20 > diff --git a/drivers/misc/ocxl/Kconfig b/drivers/misc/ocxl/Kconfig > index 1916fa65f2f2..8a683715c97c 100644 > --- a/drivers/misc/ocxl/Kconfig > +++ b/drivers/misc/ocxl/Kconfig > @@ -29,3 +29,10 @@ config OCXL > dedicated OpenCAPI link, and don't follow the same protocol. > =20 > If unsure, say N. > + > +config OCXL_SCM_GENERIC > + bool "Treat OpenCAPI Storage Class Memory as a generic OpenCAPI devic= e" > + default n > + help > + Select this option to treat OpenCAPI Storage Class Memory > + devices an generic OpenCAPI devices. > diff --git a/drivers/misc/ocxl/pci.c b/drivers/misc/ocxl/pci.c > index cb920aa88d3a..7137055c1883 100644 > --- a/drivers/misc/ocxl/pci.c > +++ b/drivers/misc/ocxl/pci.c > @@ -10,6 +10,9 @@ > */ > static const struct pci_device_id ocxl_pci_tbl[] =3D { > { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x062B), }, > +#ifdef CONFIG_OCXL_SCM_GENERIC > + { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0625), }, > +#endif > { } > }; > MODULE_DEVICE_TABLE(pci, ocxl_pci_tbl); >=20