From: "Aiqun(Maria) Yu" <quic_aiquny@quicinc.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>, <ziy@nvidia.com>,
<david@redhat.com>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <mike.kravetz@oracle.com>,
<opendmb@gmail.com>
Subject: Re: [PATCH] mm/page_isolation: fix clang deadcode warning
Date: Fri, 21 Oct 2022 13:21:02 +0800 [thread overview]
Message-ID: <b6ea49a8-2ad2-1a80-a6f6-fe2d9b30f5b6@quicinc.com> (raw)
In-Reply-To: <20221020211733.31b2ee4f81805186367304b0@linux-foundation.org>
On 10/21/2022 12:17 PM, Andrew Morton wrote:
> On Fri, 21 Oct 2022 11:26:22 +0800 "Aiqun(Maria) Yu" <quic_aiquny@quicinc.com> wrote:
>
>>> Honestly, the cure is worse than the disease. I'd rather not have a
>>> line that's this long.
>> I don't like this long either. While the current Deadcode warning is
>> also annoying for our clang tidy check.
>>
>> will the CONFIG check can be acceptable?
>> like:
>> #ifdef CONFIG_DEBUG_VM
>> or
>> if (IS_ENABLED(CONFIG_DEBUG_VM))
>>
>> Any good ideas?
>
> Put a newline in there?
>
> Although the shortly following lines are nearly as long...
>
Thx for the suggestion. new patchset uploaded.
--
Thx and BRs,
Aiqun(Maria) Yu
prev parent reply other threads:[~2022-10-21 5:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 3:09 Maria Yu
2022-10-21 3:19 ` Matthew Wilcox
2022-10-21 3:26 ` Aiqun(Maria) Yu
2022-10-21 4:17 ` Andrew Morton
2022-10-21 5:21 ` Aiqun(Maria) Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6ea49a8-2ad2-1a80-a6f6-fe2d9b30f5b6@quicinc.com \
--to=quic_aiquny@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=opendmb@gmail.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox