From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E57C1C05027 for ; Fri, 20 Jan 2023 12:52:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57F876B0072; Fri, 20 Jan 2023 07:52:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 52FC16B0073; Fri, 20 Jan 2023 07:52:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F7056B0074; Fri, 20 Jan 2023 07:52:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2C54F6B0072 for ; Fri, 20 Jan 2023 07:52:54 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E49EB80238 for ; Fri, 20 Jan 2023 12:52:53 +0000 (UTC) X-FDA: 80375167026.03.0802418 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf26.hostedemail.com (Postfix) with ESMTP id D9EB7140005 for ; Fri, 20 Jan 2023 12:52:51 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ElA9uAGL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ERovqVMA; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674219172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kTQ8Nq5uvi7FWe1ddqkYPpHbQ6IQIb+Qc6lBsv5QfVI=; b=ZKDdrxOFozygJexP5Tf8YEkjYrQn3fPkFhMllqzlceT0LelwJrghxlFAD0y827QWMosAm/ nN8WtxaFtdoZSR8wmO91e4HAo5QaSJgREfTTv3hKx2120i0ORfHUYLx/YdeCg4Fxt+WXJy sQ5DcYKv/OoL09bO0TFz3STPV6Yju2Q= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ElA9uAGL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ERovqVMA; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674219172; a=rsa-sha256; cv=none; b=fPH4lgoQb5S9E6hAtPwdSWZ8eASNYVCtAriQtBXiuL4UepT1i2S4/y5y7ij6PR6oN18KgB TryjYJUOHLtXu+6puDDMEQScKmuu6kdgF7FTdGG3S0ymCHMS1h/qiqFRsMFoeqCGgLA1NK ABuFfA6S5vRQu07iPWosLCsK2t9PoaQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 50B8422CF2; Fri, 20 Jan 2023 12:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1674219170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kTQ8Nq5uvi7FWe1ddqkYPpHbQ6IQIb+Qc6lBsv5QfVI=; b=ElA9uAGLE8ZdsC+6EypPtS7ML7QfEqiyXmTJDtC7kgz7sDJz+8iO8gcTxtbxOmhomCzCdz PnD4wZlJVQA8POWLgxzspN9PojhrsHQ0ZkJU6BiHX6ziA54MnRnMVZyzFgvjAvWeO+sbIx RcIHkdF6CjTh/57o5c7UnanqLjT2Cvg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1674219170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kTQ8Nq5uvi7FWe1ddqkYPpHbQ6IQIb+Qc6lBsv5QfVI=; b=ERovqVMAZaPUFruKbfpihDfcPrnt+VfHJu4rR0qhMeuljKCXst6SlU7fA5QkFSXBRc586Z OY4eZq3brnySttAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0E10A1390C; Fri, 20 Jan 2023 12:52:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5ZZqAqKOymMWKAAAMHmgww (envelope-from ); Fri, 20 Jan 2023 12:52:50 +0000 Message-ID: Date: Fri, 20 Jan 2023 13:52:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCHv4 2/2] mm: use stack_depot_early_init for kmemleak Content-Language: en-US To: Andrew Morton Cc: "zhaoyang.huang" , Catalin Marinas , Nathan Chancellor , Peter Zijlstra , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com, Mirsad Todorovac References: <1674091345-14799-1-git-send-email-zhaoyang.huang@unisoc.com> <1674091345-14799-2-git-send-email-zhaoyang.huang@unisoc.com> <6e9e406a-8a94-4e34-9e5e-f4bb3a321b4e@suse.cz> <20230119144204.a5a67be85544cd29cd656a5b@linux-foundation.org> From: Vlastimil Babka In-Reply-To: <20230119144204.a5a67be85544cd29cd656a5b@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 84x6qdgpjjcwcjcx61371u4carkd45rr X-Rspamd-Queue-Id: D9EB7140005 X-HE-Tag: 1674219171-924240 X-HE-Meta: U2FsdGVkX1/Nt3gK6CnHTgRGVJzY91/meum5G+Av6fPsc4mJ4/ZahaN5TuWw0jplUgFcnzREAAC15N5fCdWQebo4AxDTtEHzl8/1Vm29xkt/Ct4h+vwn0mOHQWVEwFV7ermiMhtNfl/Eu62tQ32G0In57WOfClln0GvLothow9FvzrecZQs9sGMBJB+qhXsR2ZIWqjhFI1pLSofNk4mFcCPkzoKM4PKfhcSheO97FwuAO3EtWhy6/5k038BhNrxkBWw3d+YYg4GBsECyfGrBM4xMPClShIEvC4A7WDCMTpLJMHz/z3wRqlxLW2WGhjl3R9DTHYkWt2A7wW5Nw2JPhgoNKsYQGDNIsnK8kcBFEyQEM24uQiREh7L2fF/krKebRrw/FJPbt7KY/4i8yyu/sAl/CWCB9KOLse7WjCz/cS+b1jg6nTHNegJoYoz6+BwnMgohkuviAFvQsP1JuRbrHqoLshQOL3EwQL7aJEpnPq7BmLsFVNQnAjg2t0fj4dNW1qqyglmHkH/KfS3XGrTlepjKaC1shcmwtc7q9V8j6fQWddhFZfQTzOK7pKUzeLZ90AcIP5gunN4eJqW9CWw6epMuW1eys/BG+8gKfN82zHHxZkyk5cc/CV2q5fckmM3iNGGHTsSF5BhOrf+Pxng9iXSodPVaV6bj0eXsyOscyzZXhMv1+cixyB2lQGPl69qT07kY7TjrJbsecN1PV+wMGsIIwS+Hkejc877/Av0R0kvVNmA1lrzJ6yl3iwrsdTmudwYxCLiLv/5+NGl2/7Z2KNa0D1i7zx/mlyvPI9nRZmEol0VL2LewjY4UZ/SA9mN7veouoOGYcsp49H9JQ+sGzpEKoTQGn2RDCicPhl9J3JtlzKwleUj2lFVvExh3o+75w/TDfkpcMoSVvqoyb895poPOo+b1nJVfkru9aXeq+S/bc6HARoFRoIHZQxy+MVcHjblBx1rJ45OFXIXrA02 rKKNtmvU VARXp26nvD1rs7Jc96X2oTZtq0W7LOn/VU13ERLOsV0GXUi9jhcfp3u6kDJl6V9M8dPe2OWDeHZpA1jfZY7eoIKvY85bDFiBN5f9eA4xvucWgm47omwp03Y3eysaD1unIYvU0ntnEcdLOokXbSEYn5lo8J09UXrAkTCvjgu+VMHQxzw61orPUd5GzLBeakHGTGDdNdt/ml6BsqCbukDpY9A3WZmsqkhbjUedY6uwd31Pj/eUJcItORMCiuVbYwH7uiQDjmZaa3in0Ays= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/19/23 23:42, Andrew Morton wrote: > On Thu, 19 Jan 2023 11:32:36 +0100 Vlastimil Babka wrote: > >> But to be cleaner I'd also suggest Andrew adds the hunk below. The call >> to stack_depot_init() becomes no-op after this patch so it's not a bug >> to leave it there, but it's just misleading now. >> >> ---8<--- >> diff --git a/mm/kmemleak.c b/mm/kmemleak.c >> index 91dda5c2753a..55dc8b8b0616 100644 >> --- a/mm/kmemleak.c >> +++ b/mm/kmemleak.c >> @@ -2095,7 +2095,6 @@ void __init kmemleak_init(void) >> if (kmemleak_error) >> return; >> >> - stack_depot_init(); >> jiffies_min_age = msecs_to_jiffies(MSECS_MIN_AGE); >> jiffies_scan_wait = msecs_to_jiffies(SECS_SCAN_WAIT * 1000); >> > > I added your signoff to this. Fine with me, thanks. > I used not to bother for such minor to-be-folded fixups, but now > Stephen sends me automated nags when his scripts detect this. Ack, will try to remember that next time.