From: Vlastimil Babka <vbabka@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Nathan Chancellor <nathan@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Zhaoyang Huang <huangzhaoyang@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ke.wang@unisoc.com,
Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Subject: Re: [PATCHv4 2/2] mm: use stack_depot_early_init for kmemleak
Date: Fri, 20 Jan 2023 13:52:49 +0100 [thread overview]
Message-ID: <b6da6f3b-8d66-2b8c-b02e-14d274260493@suse.cz> (raw)
In-Reply-To: <20230119144204.a5a67be85544cd29cd656a5b@linux-foundation.org>
On 1/19/23 23:42, Andrew Morton wrote:
> On Thu, 19 Jan 2023 11:32:36 +0100 Vlastimil Babka <vbabka@suse.cz> wrote:
>
>> But to be cleaner I'd also suggest Andrew adds the hunk below. The call
>> to stack_depot_init() becomes no-op after this patch so it's not a bug
>> to leave it there, but it's just misleading now.
>>
>> ---8<---
>> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
>> index 91dda5c2753a..55dc8b8b0616 100644
>> --- a/mm/kmemleak.c
>> +++ b/mm/kmemleak.c
>> @@ -2095,7 +2095,6 @@ void __init kmemleak_init(void)
>> if (kmemleak_error)
>> return;
>>
>> - stack_depot_init();
>> jiffies_min_age = msecs_to_jiffies(MSECS_MIN_AGE);
>> jiffies_scan_wait = msecs_to_jiffies(SECS_SCAN_WAIT * 1000);
>>
>
> I added your signoff to this.
Fine with me, thanks.
> I used not to bother for such minor to-be-folded fixups, but now
> Stephen sends me automated nags when his scripts detect this.
Ack, will try to remember that next time.
next prev parent reply other threads:[~2023-01-20 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 1:22 [PATCHv4 1/2] mm: move KMEMLEAK's Kconfig items from lib to mm zhaoyang.huang
2023-01-19 1:22 ` [PATCHv4 2/2] mm: use stack_depot_early_init for kmemleak zhaoyang.huang
2023-01-19 10:03 ` Mike Rapoport
2023-01-19 10:13 ` Catalin Marinas
2023-01-19 10:32 ` Vlastimil Babka
2023-01-19 22:42 ` Andrew Morton
2023-01-20 12:52 ` Vlastimil Babka [this message]
2023-01-19 10:04 ` [PATCHv4 1/2] mm: move KMEMLEAK's Kconfig items from lib to mm Mike Rapoport
2023-01-19 10:16 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6da6f3b-8d66-2b8c-b02e-14d274260493@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=huangzhaoyang@gmail.com \
--cc=ke.wang@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mirsad.todorovac@alu.unizg.hr \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox