From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42F72C433ED for ; Wed, 28 Apr 2021 14:06:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 82EC061407 for ; Wed, 28 Apr 2021 14:06:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82EC061407 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E0BA06B0036; Wed, 28 Apr 2021 10:06:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBC6B6B006E; Wed, 28 Apr 2021 10:06:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAA0A6B0070; Wed, 28 Apr 2021 10:06:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id AD67E6B0036 for ; Wed, 28 Apr 2021 10:06:41 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 752881F1A for ; Wed, 28 Apr 2021 14:06:41 +0000 (UTC) X-FDA: 78081951402.02.FE8F65D Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by imf26.hostedemail.com (Postfix) with ESMTP id 2FBD740B8CE0 for ; Wed, 28 Apr 2021 14:06:27 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R531e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=xuyu@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0UX4Z7HA_1619618792; Received: from xuyu-mbp15.local(mailfrom:xuyu@linux.alibaba.com fp:SMTPD_---0UX4Z7HA_1619618792) by smtp.aliyun-inc.com(127.0.0.1); Wed, 28 Apr 2021 22:06:33 +0800 Subject: Re: [PATCH] mm, compaction: avoid isolating pinned tmpfs pages From: Yu Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org References: Message-ID: Date: Wed, 28 Apr 2021 22:06:55 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2FBD740B8CE0 X-Stat-Signature: 7cbhdr17h45gcscd33e8qinftoofyme5 Received-SPF: none (linux.alibaba.com>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=out30-132.freemail.mail.aliyun.com; client-ip=115.124.30.132 X-HE-DKIM-Result: none/none X-HE-Tag: 1619618787-379940 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/28/21 10:00 PM, Xu Yu wrote: > This makes pinned tmpfs pages bail out early in the process of page > migration, like what pinned anonymous pages do. > > Signed-off-by: Xu Yu > --- > mm/compaction.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index e04f4476e68e..78c3b992a1c9 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -964,11 +964,11 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, > } > > /* > - * Migration will fail if an anonymous page is pinned in memory, > - * so avoid taking lru_lock and isolating it unnecessarily in an > - * admittedly racy check. > + * Migration will fail if an anonymous or tmpfs page is pinned > + * in memory, so avoid taking lru_lock and isolating it > + * unnecessarily in an admittedly racy check. > */ > - if (!page_mapping(page) && > + if (!page_is_file_lru(page) && > page_count(page) > page_mapcount(page)) Sorry, this patch is flawed, since tmpfs page cache takes an extra page count. Please ignore this patch. > goto isolate_fail; > > -- Thanks, Yu