From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6A97C43334 for ; Wed, 13 Jul 2022 00:49:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D8EF9400ED; Tue, 12 Jul 2022 20:49:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 561249400E5; Tue, 12 Jul 2022 20:49:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 403219400ED; Tue, 12 Jul 2022 20:49:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2D2509400E5 for ; Tue, 12 Jul 2022 20:49:58 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EBB4320307 for ; Wed, 13 Jul 2022 00:49:57 +0000 (UTC) X-FDA: 79680244434.14.BBB51C7 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by imf18.hostedemail.com (Postfix) with ESMTP id 870141C0072 for ; Wed, 13 Jul 2022 00:49:57 +0000 (UTC) Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-10c0430e27dso12362752fac.4 for ; Tue, 12 Jul 2022 17:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=/EtJDXI2fz8pm2wa/kg91uhQuEMJnLZy4xD2Ju9pYIk=; b=s39mIbAI2ALNtOBYHbU/VkwT73TA80TaeGinWpvDDpg5H3a9LBgudo/v3+1ifSaEm5 shcfXZjErGnl/uDUS1oZNGTfzdalN26eaFp4zzyZZYAzlWpxt5La07ynkHXjaA0FIKtU H9+YJ9qCCC93KqGRcZTJciCP/ummIwsp4+CLskjVdNJzcB+rzuKlMsxZTGxjYPGBXxMZ TZzuslVwc00c+XxHr4mwN6e61+Vxc9OgDcS09N29D0RNxNL6DtXsVwDaMdpb20k2DluW p5HMpYB1Xc1Wi1gugZR3rhE/upgrMpEL1SWcHh2JU7mdnVBVKPHlQFWFOuxQoYWy4aAg QcDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=/EtJDXI2fz8pm2wa/kg91uhQuEMJnLZy4xD2Ju9pYIk=; b=omNxVH3kWiEYTeo3I2AVHljOk0kx44mzEhajKH1TEqtrhCmXLddxLXXJ3FFIIVbXl4 gF8J660nbr1ZXjpA/EprI1XkRnYTt7XN9ccEInZkz0sCLIsSkv/AabOIBBb+b6fIQ+Kh QglCwktAIqQPNKvagRqKjI2cUBoQSee0t8EIJxu5usNgyrST2hIDv+g0j5nfrJisirWs 9dutq9LoW1OEqxknuSkee9yoomIvee6VA0fpsG8efMv4c6icEOqOECz6Nk7ck7K1CQwd 5r+LIpFbwEhkqSkRobtJWVfXwWh4C7Hdbv95pJ02aXZnOQx6yxcUhcJSX7T30oOW+Trx 2irw== X-Gm-Message-State: AJIora8PDe9XqolQYNTC+YYzQ6JpQLC5UPTW1Cge6QxgznmAfw5mjExi ZWda3Z6Pj+7ezg3mbkwzGWk2Bg== X-Google-Smtp-Source: AGRyM1t0fpQLal72HAql1XzV9CLiMdeHHv4podegGh1GBikvn7WR33caIu3r4SfrlgquDp+WfaiknA== X-Received: by 2002:a05:6870:a999:b0:10c:9df7:28ad with SMTP id ep25-20020a056870a99900b0010c9df728admr466405oab.119.1657673396720; Tue, 12 Jul 2022 17:49:56 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id l84-20020acabb57000000b003264a325ecdsm4789880oif.5.2022.07.12.17.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 17:49:56 -0700 (PDT) Date: Tue, 12 Jul 2022 17:49:40 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Nadav Amit cc: Dave Hansen , Thomas Gleixner , LKML , Hugh Dickins , Ingo Molnar , Borislav Petkov , X86 ML , Linux MM , Peter Zijlstra , Andy Lutomirski Subject: Re: [PATCH v2] x86/mm/tlb: ignore f->new_tlb_gen when zero In-Reply-To: <3DC1239B-FBE4-4EE0-B0D1-641B64697712@vmware.com> Message-ID: References: <20220710232837.3618-1-namit@vmware.com> <7672923F-D439-4867-9418-B1F44EE5CC44@vmware.com> <3DC1239B-FBE4-4EE0-B0D1-641B64697712@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657673397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/EtJDXI2fz8pm2wa/kg91uhQuEMJnLZy4xD2Ju9pYIk=; b=D4KybuKjkvec8j8X+pgFVwXpB7SU0MIZXY+grIJ5tzOFskB7IYUi7cRjPxnEKZSFkNScZu Lx4CjSH6J1OJepPu2v+3A5ngZv8YdbginY08kAHZyAX4pMtxZorREDa63tkMmwowqwK01u 3GFgbu4epk7jl35Du5A+EHx9DerjS+k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657673397; a=rsa-sha256; cv=none; b=qi+7vkvjv/oHrGvIKKGJ9tSgkk4dywnwjvKz0UHZQPU4SMRmITo2zQ3Iue8Db2oULO7PLZ PIpwaavdWaKxF2E3LldWO/K73k/JTFire2hRbcd3NchcwhoZcOcqcxAe3Sai9jWWPi5hFl 6j30Y/yPOkmlTFRYtmUv6Xtqhs+lLKo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=s39mIbAI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of hughd@google.com designates 209.85.160.54 as permitted sender) smtp.mailfrom=hughd@google.com X-Stat-Signature: mcbywfrotgqadx5w15qomonpe7fpw4ae X-Rspamd-Queue-Id: 870141C0072 X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=s39mIbAI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of hughd@google.com designates 209.85.160.54 as permitted sender) smtp.mailfrom=hughd@google.com X-Rspamd-Server: rspam05 X-HE-Tag: 1657673397-517428 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 13 Jul 2022, Nadav Amit wrote: > On Jul 11, 2022, at 10:39 AM, Nadav Amit wrote: > > On Jul 10, 2022, at 4:28 PM, Nadav Amit wrote: > >> From: Nadav Amit > >> > >> Commit aa44284960d5 ("x86/mm/tlb: Avoid reading mm_tlb_gen when > >> possible") introduced an optimization of skipping the flush if the TLB > >> generation that is flushed (as provided in flush_tlb_info) was already > >> flushed. > > > > Dave, > > > > Can you please review this patch today? > > > > I feel bad (for a good reason) for breaking swap/migration. > > > > Thanks, > > Nadav > > Ping? > > As you know, this really must go into 5.19 or otherwise aa44284960d5 > reverted. No, aa44284960d5 is not in 5.19-rc: it's in linux-next heading for 5.20. Hugh