From: Hugh Dickins <hughd@google.com>
To: Nadav Amit <namit@vmware.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Hugh Dickins <hughd@google.com>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, X86 ML <x86@kernel.org>,
Linux MM <linux-mm@kvack.org>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH v2] x86/mm/tlb: ignore f->new_tlb_gen when zero
Date: Tue, 12 Jul 2022 17:49:40 -0700 (PDT) [thread overview]
Message-ID: <b6bcd4c5-2311-451a-4792-6c2bc450b6@google.com> (raw)
In-Reply-To: <3DC1239B-FBE4-4EE0-B0D1-641B64697712@vmware.com>
On Wed, 13 Jul 2022, Nadav Amit wrote:
> On Jul 11, 2022, at 10:39 AM, Nadav Amit <namit@vmware.com> wrote:
> > On Jul 10, 2022, at 4:28 PM, Nadav Amit <nadav.amit@gmail.com> wrote:
> >> From: Nadav Amit <namit@vmware.com>
> >>
> >> Commit aa44284960d5 ("x86/mm/tlb: Avoid reading mm_tlb_gen when
> >> possible") introduced an optimization of skipping the flush if the TLB
> >> generation that is flushed (as provided in flush_tlb_info) was already
> >> flushed.
> >
> > Dave,
> >
> > Can you please review this patch today?
> >
> > I feel bad (for a good reason) for breaking swap/migration.
> >
> > Thanks,
> > Nadav
>
> Ping?
>
> As you know, this really must go into 5.19 or otherwise aa44284960d5
> reverted.
No, aa44284960d5 is not in 5.19-rc: it's in linux-next heading for 5.20.
Hugh
next prev parent reply other threads:[~2022-07-13 0:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-10 23:28 Nadav Amit
2022-07-11 17:39 ` Nadav Amit
2022-07-13 0:33 ` Nadav Amit
2022-07-13 0:49 ` Hugh Dickins [this message]
2022-07-13 0:50 ` Nadav Amit
2022-07-19 16:13 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6bcd4c5-2311-451a-4792-6c2bc450b6@google.com \
--to=hughd@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox