From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 737C8C54E66 for ; Tue, 12 Mar 2024 09:41:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3EB88D0025; Tue, 12 Mar 2024 05:41:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC6BA8D000D; Tue, 12 Mar 2024 05:41:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D66A58D0025; Tue, 12 Mar 2024 05:41:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C68018D000D for ; Tue, 12 Mar 2024 05:41:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A09F5A0F10 for ; Tue, 12 Mar 2024 09:41:34 +0000 (UTC) X-FDA: 81887894508.01.0B7661E Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf23.hostedemail.com (Postfix) with ESMTP id 7AD5E140008 for ; Tue, 12 Mar 2024 09:41:31 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710236492; a=rsa-sha256; cv=none; b=X88BrXd+CHriVTnz5nXDXpU72eEToMjCqp/zZuk95Iwr/jZxGq6nYh/arn0c405ks7FKbT Cq1K2HY0vDluEJmeZV1bq8TuFw9+fd9QDGyW2gqMKkqPxuMtT3cpcoHf9B1R5rBxF0Ru0v fvhzNA/o4O7zo1s6mxPhBt/vwNNU4Ug= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710236492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sGq9/OS66AvGvlNzWFK5jF+e/wG/3e8AEIa5hSEDHw4=; b=PDAvxg8QNF1O457X3GpMPAqhPnUwXhZutLkNbWiKOapKVFk3asUol0M9gyJf/CWzE7Hjv2 nWzr89Za5L2BmxrUto444YS9u6kFxpgGHe/f7VSHsIuNYW07JSGl6BOPW5gsk8sIuHesed AXcoPpTSA5Sd7Fc82C6d+kT28xIJLw8= Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Tv7pW0sy4z688hZ; Tue, 12 Mar 2024 17:37:23 +0800 (CST) Received: from lhrpeml500003.china.huawei.com (unknown [7.191.162.67]) by mail.maildlp.com (Postfix) with ESMTPS id 5738E140D1D; Tue, 12 Mar 2024 17:41:28 +0800 (CST) Received: from lhrpeml500006.china.huawei.com (7.191.161.198) by lhrpeml500003.china.huawei.com (7.191.162.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 12 Mar 2024 09:41:27 +0000 Received: from lhrpeml500006.china.huawei.com ([7.191.161.198]) by lhrpeml500006.china.huawei.com ([7.191.161.198]) with mapi id 15.01.2507.035; Tue, 12 Mar 2024 09:41:27 +0000 From: Shiju Jose To: fan CC: "linux-cxl@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "dan.j.williams@intel.com" , "dave@stgolabs.net" , "Jonathan Cameron" , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "tony.luck@intel.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "mike.malvestuto@intel.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , tanxiaofei , "Zengtao (B)" , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: RE: [RFC PATCH v7 03/12] cxl/mbox: Add SET_FEATURE mailbox command Thread-Topic: [RFC PATCH v7 03/12] cxl/mbox: Add SET_FEATURE mailbox command Thread-Index: AQHaZmXa2rf54FiQvUO4a7U5LboEzbEzJw+AgADJeeA= Date: Tue, 12 Mar 2024 09:41:27 +0000 Message-ID: References: <20240223143723.1574-1-shiju.jose@huawei.com> <20240223143723.1574-4-shiju.jose@huawei.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.195.33.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7AD5E140008 X-Stat-Signature: r3poxyfstmkajocz73mze8gm9y747q3h X-Rspam-User: X-HE-Tag: 1710236491-139266 X-HE-Meta: U2FsdGVkX1+4QC72Ozt9e2ezlWApJq5qZOTLXaujLINbEu5rvur5KXBZtGEa+DU/NnQFNFGiLHBI1U0EWxmgBeeqtWJftPa30zHTTskF7OUBZOimTsGr9akFQ22BXNLOgstKe4JRpFyz0TvKYXVWPn4U8PVj5jcRMEklUMb7uU7mW19kiFDmIfgv/BFfestH6qH5Hpu7xa/2pBQblGenVnqCZT9UP8ORJdRNLCSy4gA9xtDjPemqMoIOQX85yPOgUUCe9ioPdDDtfDlos4xsAgZy/NSeFucNpwjyo4L5dsEwmNZwlIc4fwwGZrReghOJnEvV2Ovbo4pa0KksmpfUh3I0gmdaM3FTIb8rDVIGP+r5bcIH8ffo9JridbnJqRX5tqqLegZIdXWkgSIZxcZBChn3OelIymBBLUaGP05JZXpw2y6qaIM8pGNNopd3mZv90zfCrkDrZ7w9x3XP9ix7MgGaCVBvm3Zt3OJk74slR1/OVk0ewwh7dKxVLyeShcxNvDySykT4N5MXCXJPuVk1nQ7+bmTgTtzRg3Cro4kw+F4LRinTeemaplGKIXzpywOPMKldEqRBRiDaWXqMYtFZshmx/d46fUI6t73z1jpNdfpghUf+UWfslpUnVOKiyZbKo3d4tAc9MxbUbB+jD5hna1GbqcxjD8q9USlbF9YKv1Ed8/gcfbKch4UsZXnVFFcVJsSFErR2nkMtMa7lfIYfLV2ihZ7beF5QXDJmhVcwHkG0uS4KABY2rh3TjJ4hOxEKIUSR3yc+vNeCIV1lblsccUgFLQUfcuRaZDrQTB0AP+AMdeOacEd60RoJ/re9q6H3sF/A2RYJouQR2FbDj7AVouM5yXnS1CYmKnLo+hmF334HWgd3AUFqRXUla/i9sjHmjZk7Fr3dKa9ZcAxJ2ak01El3JP1zvsTr4ub/4MB3Ie1MDhhQk5LTmW1oqJPO0WqBjb5EakR9MIxBZZoIK2Y kVtd/1kb yPBrm0teLp8JpOQ1B1AvKI8RMxufNMjvW3+AxSwt1vkVMkR7xmLlMyCh02zfkFrAaFS55q6faAoRjZ5CjdFnfE532aj+W5dEqamLShoT6UmGOKwBWhfvmyr0SMV5oFLiEauRd1n7UUshc+UuLdIusUqxcvAiFXw/g1qnaV54zym9yV7xcogtX08hqjbBRnQ1g7tQvHMjJ4ICvL6zsqpfPCIZNveU3R0kBFSZM2kA1rWWLZWhYGcGL8mnSLEbJSG1BqyBVQzbDU/t6JLJ75vWb9/XDhOqs/7FVPmZmYvtvrooLZgMhOh751IK2eMJ5XqFoMkyR3wMqWtwfCjzSpDz48l0rNFOLJJYmIf84LDXpQ4AHyNMKXQ9E9KuX+HvlqyvaPnk+w9tAA0GMVGYiRu4xrd9yN0XijTZ/259FmWx5GHsyTtSccZDRf+O+G7AxZ17/DKu65uDyYUUyYuTc4wFaZaY0Ts8eB8GPpqeZpYCNomxIuI95h/UwnVqLZ2f6w/kF40zHqctBwlz5Uzvme7VowDVJ6zhcSm2pkMO7ft9bB/cAb80UBrcJKt/JSPYDw5rkobvHMGABX5lE66SEe0XVSEEYJ4wlawBoIOzXOrvZJTgJz5K4d5e8GKrl01oQJQ8eTdQ/xOk9lUUOzcMuOgZJS5wlHeM0nFWX1ntNKJTlzWs2zRurW0gJHxniwsxU3drfLbM9ndMuvVlN/sY8G1Fx4CTUx50/qLCCIWzrgPln6Uepm50vuNgi2JXnHLdnH6g+eRO9hHpEn9R5JnEXfyzbcLKwm2tPqd2gpEErZa/T2xj3aW16IafhmDtynaG0i+MbzUCIRaATHDvW0zpdLa3tsSqETx+UmSxm27hWBfzUqbqVF2amvOjTbQDe4eaBxqiMzZDhzsP6lWLWwoQCd6L47s1KjPUMdmlR7ckoEDA6tMLX8vo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Fan, >-----Original Message----- >From: fan >Sent: 11 March 2024 21:20 >To: Shiju Jose >Cc: linux-cxl@vger.kernel.org; linux-acpi@vger.kernel.org; linux- >mm@kvack.org; dan.j.williams@intel.com; dave@stgolabs.net; Jonathan >Cameron ; dave.jiang@intel.com; >alison.schofield@intel.com; vishal.l.verma@intel.com; ira.weiny@intel.com; >linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; david@redhat.com= ; >Vilas.Sridharan@amd.com; leo.duran@amd.com; Yazen.Ghannam@amd.com; >rientjes@google.com; jiaqiyan@google.com; tony.luck@intel.com; >Jon.Grimm@amd.com; dave.hansen@linux.intel.com; rafael@kernel.org; >lenb@kernel.org; naoya.horiguchi@nec.com; james.morse@arm.com; >jthoughton@google.com; somasundaram.a@hpe.com; >erdemaktas@google.com; pgonda@google.com; duenwen@google.com; >mike.malvestuto@intel.com; gthelen@google.com; >wschwartz@amperecomputing.com; dferguson@amperecomputing.com; >tanxiaofei ; Zengtao (B) = ; >kangkang.shen@futurewei.com; wanghuiqiang ; >Linuxarm >Subject: Re: [RFC PATCH v7 03/12] cxl/mbox: Add SET_FEATURE mailbox >command > >On Fri, Feb 23, 2024 at 10:37:14PM +0800, shiju.jose@huawei.com wrote: >> From: Shiju Jose >> >> Add support for SET_FEATURE mailbox command. >> >> CXL spec 3.1 section 8.2.9.6 describes optional device specific features= . >> CXL devices supports features with changeable attributes. >> The settings of a feature can be optionally modified using Set Feature >> command. >> >> Signed-off-by: Shiju Jose >> --- >> drivers/cxl/core/mbox.c | 67 >+++++++++++++++++++++++++++++++++++++++++ >> drivers/cxl/cxlmem.h | 30 ++++++++++++++++++ >> 2 files changed, 97 insertions(+) >> >> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index >> c078e62ea194..d1660bd20bdb 100644 >> --- a/drivers/cxl/core/mbox.c >> +++ b/drivers/cxl/core/mbox.c >> @@ -1366,6 +1366,73 @@ size_t cxl_get_feature(struct cxl_memdev_state >> *mds, } EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); >> >> +int cxl_set_feature(struct cxl_memdev_state *mds, >> + const uuid_t feat_uuid, u8 feat_version, >> + void *feat_data, size_t feat_data_size, >> + u8 feat_flag) >> +{ >> + struct cxl_memdev_set_feat_pi { >> + struct cxl_mbox_set_feat_hdr hdr; >> + u8 feat_data[]; >> + } __packed; >> + size_t data_in_size, data_sent_size =3D 0; >> + struct cxl_mbox_cmd mbox_cmd; >> + size_t hdr_size; >> + int rc =3D 0; >> + >> + struct cxl_memdev_set_feat_pi *pi __free(kfree) =3D >> + kmalloc(mds->payload_size, >GFP_KERNEL); >> + pi->hdr.uuid =3D feat_uuid; >> + pi->hdr.version =3D feat_version; >> + feat_flag &=3D ~CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK; >> + hdr_size =3D sizeof(pi->hdr); >> + /* >> + * Check minimum mbox payload size is available for >> + * the feature data transfer. >> + */ >> + if (hdr_size + 10 > mds->payload_size) > >Where does this magic number come from? This represents minimum extra number of bytes to be available in the mail b= ox for storing the actual feature data to work with multipart feature data tra= nsfers. This will be set as a definition in the next version and however not sure t= he best value to be set. > >Fan > >> + return -ENOMEM; >> + >> + if ((hdr_size + feat_data_size) <=3D mds->payload_size) { >> + pi->hdr.flags =3D cpu_to_le32(feat_flag | >> + >CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER); >> + data_in_size =3D feat_data_size; >> + } else { >> + pi->hdr.flags =3D cpu_to_le32(feat_flag | >> + >CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER); >> + data_in_size =3D mds->payload_size - hdr_size; >> + } >> + >> + do { >> + pi->hdr.offset =3D cpu_to_le16(data_sent_size); >> + memcpy(pi->feat_data, feat_data + data_sent_size, >data_in_size); >> + mbox_cmd =3D (struct cxl_mbox_cmd) { >> + .opcode =3D CXL_MBOX_OP_SET_FEATURE, >> + .size_in =3D hdr_size + data_in_size, >> + .payload_in =3D pi, >> + }; >> + rc =3D cxl_internal_send_cmd(mds, &mbox_cmd); >> + if (rc < 0) >> + return rc; >> + >> + data_sent_size +=3D data_in_size; >> + if (data_sent_size >=3D feat_data_size) >> + return 0; >> + >> + if ((feat_data_size - data_sent_size) <=3D (mds->payload_size - >hdr_size)) { >> + data_in_size =3D feat_data_size - data_sent_size; >> + pi->hdr.flags =3D cpu_to_le32(feat_flag | >> + >CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER); >> + } else { >> + pi->hdr.flags =3D cpu_to_le32(feat_flag | >> + >CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER); >> + } >> + } while (true); >> + >> + return rc; >> +} >> +EXPORT_SYMBOL_NS_GPL(cxl_set_feature, CXL); >> + >> int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, >> struct cxl_region *cxlr) >> { >> diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index >> bcfefff062a6..a8d4104afa53 100644 >> --- a/drivers/cxl/cxlmem.h >> +++ b/drivers/cxl/cxlmem.h >> @@ -531,6 +531,7 @@ enum cxl_opcode { >> CXL_MBOX_OP_GET_LOG =3D 0x0401, >> CXL_MBOX_OP_GET_SUPPORTED_FEATURES =3D 0x0500, >> CXL_MBOX_OP_GET_FEATURE =3D 0x0501, >> + CXL_MBOX_OP_SET_FEATURE =3D 0x0502, >> CXL_MBOX_OP_IDENTIFY =3D 0x4000, >> CXL_MBOX_OP_GET_PARTITION_INFO =3D 0x4100, >> CXL_MBOX_OP_SET_PARTITION_INFO =3D 0x4101, >> @@ -773,6 +774,31 @@ struct cxl_mbox_get_feat_in { >> u8 selection; >> } __packed; >> >> +/* Set Feature CXL 3.1 Spec 8.2.9.6.3 */ >> +/* >> + * Set Feature input payload >> + * CXL rev 3.1 section 8.2.9.6.3 Table 8-101 */ >> +/* Set Feature : Payload in flags */ >> +#define CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK GENMASK(2, 0) >> +enum cxl_set_feat_flag_data_transfer { >> + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER, >> + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER, >> + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER, >> + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER, >> + CXL_SET_FEAT_FLAG_ABORT_DATA_TRANSFER, >> + CXL_SET_FEAT_FLAG_DATA_TRANSFER_MAX >> +}; >> +#define CXL_SET_FEAT_FLAG_DATA_SAVED_ACROSS_RESET BIT(3) >> + >> +struct cxl_mbox_set_feat_hdr { >> + uuid_t uuid; >> + __le32 flags; >> + __le16 offset; >> + u8 version; >> + u8 rsvd[9]; >> +} __packed; >> + >> /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ struct >> cxl_mbox_poison_in { >> __le64 offset; >> @@ -912,6 +938,10 @@ size_t cxl_get_feature(struct cxl_memdev_state >*mds, >> size_t feat_out_size, >> size_t feat_out_min_size, >> enum cxl_get_feat_selection selection); >> +int cxl_set_feature(struct cxl_memdev_state *mds, >> + const uuid_t feat_uuid, u8 feat_version, >> + void *feat_data, size_t feat_data_size, >> + u8 feat_flag); >> int cxl_poison_state_init(struct cxl_memdev_state *mds); int >> cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, >> struct cxl_region *cxlr); >> -- >> 2.34.1 >> Thanks, Shiju