From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE99EB64DC for ; Tue, 27 Jun 2023 19:14:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C7398D0003; Tue, 27 Jun 2023 15:14:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 177E78D0001; Tue, 27 Jun 2023 15:14:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03EBA8D0003; Tue, 27 Jun 2023 15:14:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E77128D0001 for ; Tue, 27 Jun 2023 15:14:06 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B3528A0953 for ; Tue, 27 Jun 2023 19:14:06 +0000 (UTC) X-FDA: 80949478092.10.7C8BEAF Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf03.hostedemail.com (Postfix) with ESMTP id 584D32000D for ; Tue, 27 Jun 2023 19:14:04 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=bM9Je+tO; dmarc=none; spf=pass (imf03.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687893244; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kvHLvhv1Vboi73O1yp/Tlc9InhlPe7nOe1kq7T+MFRo=; b=L+yXH7HQOeTcPaJ5NEXTT7EtS5Xv3uTTxa8PW1AlZ9xdaDFGcmsSYoCU2uV8slMXSQMRKR tmX83TXgWqRbXHKhaU8KU5qzrfk3YtVfAJ68PtvIBm2Ye2LCY1C0DA5q281levFsRFlK2d 9u1PG4LqwovOO2vzwBszP23K3/S50ok= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=bM9Je+tO; dmarc=none; spf=pass (imf03.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687893244; a=rsa-sha256; cv=none; b=tl1N/riYtodxgC3zsY8MzzoB+o2HKjgntK4mZYd05Vq9l5NGw1MumZ8lyHAEiFUfBjzF8I 1bDcZCgNx7TvNu4giRg/eYVCN70Fa8gUW/FNeknsn8U3zGCjA6wpAQnIwqmRIk9BgGC1zo WLdHCsBX5iLP7ntc8xQU8xsRRAg1Oek= Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-666e64e97e2so2825563b3a.1 for ; Tue, 27 Jun 2023 12:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687893243; x=1690485243; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=kvHLvhv1Vboi73O1yp/Tlc9InhlPe7nOe1kq7T+MFRo=; b=bM9Je+tOekLovPkvT+/l7nbya5CmvdUQjXrADEm1UMcV4/Dft3yRiRDI0ZDflduo0a eCCHc/eGgHA3aTnPLKW75ZP3+msGkQAgAajr0fU475B6t9dnUbkeGDGaGhTQuEs9G8Em fP/NIDTeV8LmgxO8Ql0wOGFl7SgfrLikcvULFnS16kiPfzK7oAB1YpIUgqh/lMxpHyod tqWpPiE4/bUvsjhZfVbvFSWKmV4p5zoSojTJH1B4PXJkJ5GFHQt4ps0dwXEGoW/rFJ5j 7OEFRkR/4WYv521gDAmtenL688/6yjI/zD/BFplexhWDCjqz/HwvAM7QaYSh0oWP3Dui ALeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687893243; x=1690485243; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kvHLvhv1Vboi73O1yp/Tlc9InhlPe7nOe1kq7T+MFRo=; b=TX0Me3KsxDnvfM1OscWOP5Zjqua4acfG2Dh+67HA/jE1d1Ym5RQ8cb31985QhELCRX zbT2tq2t95YdPD6NaEy5tpyIsc9YzthwMBNSdT03c5WwDdvGwpBEIB0gL9mvBze+E6Zq i8+9QN6Siyu90YLb9731pWk2zam99IEYNcL6ayIdeNkTT53N5TGOmJ3uJ8kuEScUWSpj pVCxblI9Apw/svo6xThR0w+RwOijeH8ZBK+o34K2XLgff3FIydGAIldw1CvfaUNmYkVc pT+drU0FiVparKEfLhItRKF/CcuZLAIL4rnTPwvgGPPLG9gT35dXwHEDN7wmVvzIuZez aB3w== X-Gm-Message-State: AC+VfDydZiWNS35ZaQssuTFEIbF1eTlGwJpOmo+XE0OyHAHLMt/zLJvy GSAJxT2qxDf7LQabcZKOw5M= X-Google-Smtp-Source: ACHHUZ7LJIGe+68y+/f7zW8IDz+Iq/yBUPpzssEQrXLR8wKbF9q9Wu20nywq5XNVdfXVbWMgiaxYCw== X-Received: by 2002:a05:6a00:2490:b0:668:7209:1856 with SMTP id c16-20020a056a00249000b0066872091856mr26446249pfv.14.1687893243046; Tue, 27 Jun 2023 12:14:03 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id s1-20020aa78281000000b0065a1b05193asm5742654pfm.185.2023.06.27.12.14.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 12:14:02 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 12:14:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v5 26/33] nios2: Convert __pte_free_tlb() to use ptdescs Content-Language: en-US From: Guenter Roeck To: Vishal Moola Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , Dinh Nguyen , Mike Rapoport References: <20230622205745.79707-1-vishal.moola@gmail.com> <20230622205745.79707-27-vishal.moola@gmail.com> <13bab37c-0f0a-431a-8b67-4379bf4dc541@roeck-us.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 584D32000D X-Stat-Signature: edo1xuibifz1x17zfozx5eke91ki7xmj X-HE-Tag: 1687893244-319324 X-HE-Meta: U2FsdGVkX1/k2BSyhIdW/Hz2L5ON2g8RooUNfMRPFLaYdMTgnqj/KnK7yS5o4ovl5NHA0pC1ZRRJFBqSTCRb4CaV2kp86TphhdpafeujfdXGbSbWlno0gIFMtY4bCZ0cowc25lI4dyYOAOoBbzjeCxl6uvVci4LMIyXHLo4ua2h8cTJK/kiVhZpM1uvApPhqm+jyw70m/1S1IfQMmpUv9LU4wvQYA83SJ5i7Sg2zde6kRNek6n6jcpOr57/S+XKMbd8QCNKj8c33jYD5KTCN4OA8gTymwIBVyP6LmFa4tq99HK6jIup5rEh80naUcA6YceYGlxYZ5lAR8fP1ojOb2rR10oLNlyPfDI1LFUbSH15GcFntNh2ZuecpFUJiPinxkAurhWmCeoarbV+KFuBOSDfDse/Ohj8gxcQIgaX6fWtqHdrrZPS03FNCtbRjPT88bmDGm04elscMvOg8kgmN7xbPDmA2zeKIhu3PqW4gjKtms2JxaqTQKBSwydAkr2etl3jTwKVCRke0A9RTEB8sEVKDayR19jN+bKYCVjurst7WKj+QRFuDi0ty4oNpId7saBV/esTK91yE0SityQ3DGw2NgEX0SeiaRMNGCKMtePI+D7//wIZ8gsqF3JZ2eJmkWgIdHHMqKo7W3jbV4MSuy2z8JYNDslFmeodo8ETUIFZdSbLUNzre+Eo/HdQmRGRsKwcFOqS+knVb8hbt1dj9ovLN6yqg7/Bmipn7n3zp1KwHjdYEN7URrSNsUqDa99XJjEllUzr4DT5dSK+i3rXGCAu9O6HGCfjOBdjsv0fp9ITetWpAWlIXoGlVBDFO/61Spyy+8GBVXL5lxWRvYUSFMJJC6aNfqgeeuvDnCh8bqIDm5eMtJxF3GBZDQmVdBKxJeiNOMP92qF452vSZr5s7KCtzCHscJr3kNZWmQByxzDKfJXMybmVtVJ1m5GT2eRQsw1f85Xh/bJF7rJglBtG F/A3DA2o UZTKIfkS0tYzZt7wokNtbrMeJqh8ng5yuM4jRJ/qzkMDaB5vWgJG+xSk4jsv3yF0djxgdzjxTKAfxCTQdWIgebxL+VHrLp5P6IGGjv815NYkrGFUIz7VWfdX9GF6lkPF8e3KSZ+szMKCmqchmvslK+lHRw81RDUQWXNzosV7JsNx7QuqdTJysI7sQTA6yjKnRIT3Sie343Cr1n5bz+b4sVYjBsG3UQDIRQNWkHyf/rzN8eWf5nTCX23wEZniWRt63nXCJuTqe03CdLZ3nLEGjsEPWl336+tn5I7QnhqOpNmxkhssH5DRmmYpfY0wRUi/pRNlvFtV0gF3zOQL3+rRZ0yAw8P62crqthbCPYM/i1CGKO3WHxbpmGMjO2axyqT/90KBqptbnYGwYtHQSjyL94JbohDv3TWaI2XZKvNKwlVpHCnCZizYDmoQAiPwpW9lj6m7Jx2CXLEsABHzKVEk/ZQcyCWNNCFKB4iM9m8R15jejFhr4/73kytZqdkxjQCP/9+p3GgxQ18woVqWz36eB0FwYRIkSWQRJxHt4cz9hY1Kacj/0jWAQv01Q+iKnZ+3M7TDqc1YAM7y5XXlTQ7YyjzeTmuy+enCOP2QPQs66m2lt+TGCdKJEKpNySCjga932LHSmIBvFLxMY496LE958jUPtFUD8PVnOT6056eFr22/+5QFxxIRz0teTQ2V4Yp+z0uPu5y57lU9/Abk5xukyHlKJA99DyifCO3/F X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/27/23 12:10, Guenter Roeck wrote: > On 6/27/23 10:42, Vishal Moola wrote: >> On Mon, Jun 26, 2023 at 10:47 PM Guenter Roeck wrote: >>> >>> On Thu, Jun 22, 2023 at 01:57:38PM -0700, Vishal Moola (Oracle) wrote: >>>> Part of the conversions to replace pgtable constructor/destructors with >>>> ptdesc equivalents. >>>> >>>> Signed-off-by: Vishal Moola (Oracle) >>>> Acked-by: Mike Rapoport (IBM) >>> >>> This patch causes all nios2 builds to fail. >> >> It looks like you tried to apply this patch on its own. This patch depends >> on patches 01-12 of this patchset to compile properly. I've cross-compiled >> this architecture and it worked, but let me know if something fails >> when its applied on top of those patches (or the rest of the patchset). > > > No, I did not try to apply this patch on its own. I tried to build yesterday's > pending-fixes branch of linux-next. > A quick check shows that the build fails with next-20230627. See log below. Guenter --- $ git describe next-20230627 $ git describe --match 'v*' v6.4-12601-g53cdf865f90b Build reference: v6.4-12601-g53cdf865f90b Compiler version: nios2-linux-gcc (GCC) 11.4.0 Assembler version: GNU assembler (GNU Binutils) 2.40 Building nios2:allnoconfig ... failed -------------- Error log: :1519:2: warning: #warning syscall clone3 not implemented [-Wcpp] In file included from mm/memory.c:86: mm/memory.c: In function 'free_pte_range': arch/nios2/include/asm/pgalloc.h:33:17: error: implicit declaration of function 'pagetable_pte_dtor'; did you mean 'pgtable_pte_page_dtor'? [-Werror=implicit-function-declaration] 33 | pagetable_pte_dtor(page_ptdesc(pte)); \ | ^~~~~~~~~~~~~~~~~~ include/asm-generic/tlb.h:666:17: note: in expansion of macro '__pte_free_tlb' 666 | __pte_free_tlb(tlb, ptep, address); \ | ^~~~~~~~~~~~~~ mm/memory.c:194:9: note: in expansion of macro 'pte_free_tlb' 194 | pte_free_tlb(tlb, token, addr); | ^~~~~~~~~~~~ arch/nios2/include/asm/pgalloc.h:33:36: error: implicit declaration of function 'page_ptdesc' [-Werror=implicit-function-declaration] 33 | pagetable_pte_dtor(page_ptdesc(pte)); \ | ^~~~~~~~~~~ include/asm-generic/tlb.h:666:17: note: in expansion of macro '__pte_free_tlb' 666 | __pte_free_tlb(tlb, ptep, address); \ | ^~~~~~~~~~~~~~ mm/memory.c:194:9: note: in expansion of macro 'pte_free_tlb' 194 | pte_free_tlb(tlb, token, addr); | ^~~~~~~~~~~~ arch/nios2/include/asm/pgalloc.h:34:17: error: implicit declaration of function 'tlb_remove_page_ptdesc'; did you mean 'tlb_remove_page_size'? [-Werror=implicit-function-declaration] 34 | tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ | ^~~~~~~~~~~~~~~~~~~~~~ include/asm-generic/tlb.h:666:17: note: in expansion of macro '__pte_free_tlb' 666 | __pte_free_tlb(tlb, ptep, address); \ | ^~~~~~~~~~~~~~ mm/memory.c:194:9: note: in expansion of macro 'pte_free_tlb' 194 | pte_free_tlb(tlb, token, addr); | ^~~~~~~~~~~~ cc1: some warnings being treated as errors make[3]: *** [scripts/Makefile.build:243: mm/memory.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [scripts/Makefile.build:477: mm] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Makefile:2022: .] Error 2 make: *** [Makefile:226: __sub-make] Error 2