From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B63EED68BE9 for ; Sat, 16 Nov 2024 10:07:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14D296B00B7; Sat, 16 Nov 2024 05:07:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FD8A6B00B8; Sat, 16 Nov 2024 05:07:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6BAA6B00B9; Sat, 16 Nov 2024 05:07:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C15146B00B7 for ; Sat, 16 Nov 2024 05:07:04 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EC0A8ADD19 for ; Sat, 16 Nov 2024 10:07:03 +0000 (UTC) X-FDA: 82791529506.28.B03667B Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf22.hostedemail.com (Postfix) with ESMTP id E9F09C000B for ; Sat, 16 Nov 2024 10:06:03 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731751444; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6BITrGwCktL5Jq+X71yuMGeN9lc8EktfbH6sdnkEy4Y=; b=bcg5xlqVkL8FCUbxW0oJm3TDdYpVfz7uzLctS8d4G1QXbUekhxCuCh2phZz39WDX+MXNvo Qcl7C3zb/+XItIk5MEITPKT5GwJgr9ebB68rjSVzrKc0dydX1MngnlRXbAhz/N0nSnIA4+ hdZVmdD5JRHHJ20EYgoAIUx/JoTZHko= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731751444; a=rsa-sha256; cv=none; b=sv9df7TYPacIPGCrpBu3eVs8oQ6ML2F7gBQ2GVbKxnn92h/IZIUlS3ZVK79ttpl5X5xBO7 IjAeKkZ3QEkTCY5B4KQ/SMmOG913BnrhPUvmgTesvrma5lFHvZ4uab8LiXdjqBW3zB1ofx PkpXmzx9MRlaFxvuzlKXy/M/2BWN3yw= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Xr8gm1HnWz9sSY; Sat, 16 Nov 2024 11:07:00 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id es6k7pGxiX9O; Sat, 16 Nov 2024 11:07:00 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Xr8gl0nQ8z9sSV; Sat, 16 Nov 2024 11:06:59 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id EF7308B7A7; Sat, 16 Nov 2024 11:06:58 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id t4lgoLTHg9Gu; Sat, 16 Nov 2024 11:06:58 +0100 (CET) Received: from [192.168.232.159] (POS169858.IDSI0.si.c-s.fr [192.168.232.159]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 7AEB48B763; Sat, 16 Nov 2024 11:06:55 +0100 (CET) Message-ID: Date: Sat, 16 Nov 2024 11:06:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/21] powerpc/papr_scm: Convert timeouts to secs_to_jiffies() To: Easwar Hariharan , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-5-911fb7595e79@linux.microsoft.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <20241115-converge-secs-to-jiffies-v2-5-911fb7595e79@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E9F09C000B X-Stat-Signature: nj4zgn3gzkaakq3rf15hdeaabpbcsnd8 X-Rspam-User: X-HE-Tag: 1731751563-87634 X-HE-Meta: U2FsdGVkX18MALmAJGHFPSxapBLgfz0Axuk7NHiV/AD0K5KNYD4DVGpeH29/qQwW49vt4csE53H9B5OicyoW4ka96xCyusLJO2UIML7WL5gowBXhhg85ZCFowGMG5xnT1a4qGM3Eq0p0aoTOkCjquKko+twkd3nXPunhR/LflEivUWfleXgWk8I7FHGX69ItiBdNWF7PN6hBGSSmhBk+vuBgfPC0NAGd4C0AVMOOvUX+PAemVGNyYZ5AIp2QaiisrS7joAYFTzjfzpeJTSwAOUuNoVD7ocxWUz85Y4dBq5JTUmvoXp/RSTPtx7ev9+Z8xb2Hypnva1MJB8IMxQ2huaSVG6qxPyHKXQa88CzMScZcZrDT3HyHifkhGgXW3By6CJg1ERkZwkzB9n7yPMWByeGdhvx8sr9LuISJ4i+voGV/QFqAGcG9sA2JKmI2iWKiMZ5K4hMKamxW4vmdUrT1QJWjzCb+SWMW/p3fLN4KC/1cj1PqJwm2S+5F3fMdINlK2SFXfriIJdFdmvjcE8CcVtv9xdVJSsx90tBeiLG+epWse2KK2i1HoeQ41tFejaN+z3s7GIy4ZxJ7j7fclK14AjqQdE0qAuTyYfbcJiPRx5NGlHjVWJUhYTFbLTFgyLVBa2y87InTlhVatN4BUeVvi7VUuwvSmft3fcczTcPbwL2QTXo2CKGbFvJfmMVvVQ1UlMi1ZZrdyMWa2IGBRQg0lpn9FL3EfQgSfmg7Mbkyx3SJ3Z8LWUcWFnEoAaNuOpy4BTqXnFzIiUbvKM1GwgMCSH3vVEljl7WUxZ3GQId/DcuUrbEENACQfb4mzxoL/XZEf9sh663eJh5REw8jmkQVWdKGrkWELWaXAeMeqbTIDdodsVhsTr26I94fmRU80p7napngmtWBQA3vQN8l3ifgLQHsxTYxKiUcO/WbmGNlimIVUDME1ee3nEpgZaOq2F7pgaht1kCFU2G0i/SWf5m OiQCvEjP fy2pGD2veW2/5LJfOBuNk+v/4HuVII3VjodB75FwA0yzrRqJS1aWVhqDubq20kgv2JyRnEYnlSgOj5fbwb9VjCjefaTGlwqX65mU1ZGxdtMQ4vKE8jeHIB8KwWyvUIAfmU2S+j51CH0V5PRyakKleb3G0J+ruqCrjkqBSceP8TWoTqa3A/TmEUm77tsVMp9PL3qbzMUB5H6hKIMmjYaTSxvzNUU6v2Tr1nbk74TWB/2poISxX6GYoO4YsJp52pVPYTg4I+bHZWO4poVyo8e5MKmeBV0hOJisB2OYwNQRzFAm4OJ9+5dKEU6S5asB4b3nmxbEI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > [Vous ne recevez pas souvent de courriers de eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) Is it a special script or is it done with the script in patch 2. That's nice to say how it is done, but you also have to say _what_ and _why_ you do it. This is even more important as you plan to get it merged independently in each tree instead of merging it as a single series. It could be something like: Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci > > Signed-off-by: Easwar Hariharan > --- > arch/powerpc/platforms/pseries/papr_scm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c > index 9e297f88adc5d97d4dc7b267b0bfebd58e5cf193..9e8086ec66e0f0e555ac27933854c06cfcf91a04 100644 > --- a/arch/powerpc/platforms/pseries/papr_scm.c > +++ b/arch/powerpc/platforms/pseries/papr_scm.c > @@ -543,7 +543,7 @@ static int drc_pmem_query_health(struct papr_scm_priv *p) > > /* Jiffies offset for which the health data is assumed to be same */ > cache_timeout = p->lasthealth_jiffies + > - msecs_to_jiffies(MIN_HEALTH_QUERY_INTERVAL * 1000); > + secs_to_jiffies(MIN_HEALTH_QUERY_INTERVAL); Wouldn't it now fit on a single line ? cache_timeout = p->lasthealth_jiffies + secs_to_jiffies(MIN_HEALTH_QUERY_INTERVAL); Also I'm not sure it is worth the MIN_HEALTH_QUERY_INTERVAL macro as it is defined localy and used only once, but that's another story. > > /* Fetch new health info is its older than MIN_HEALTH_QUERY_INTERVAL */ > if (time_after(jiffies, cache_timeout)) > > -- > 2.34.1 >