From: Rik van Riel <riel@surriel.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Nicholas Piggin <npiggin@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
torvalds@linux-foundation.org, luto@kernel.org, x86@kernel.org,
bp@alien8.de, jannh@google.com, ascannell@google.com,
dave.hansen@intel.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, David Miller <davem@davemloft.net>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-arch@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] mm: move tlb_table_flush to tlb_flush_mmu_free
Date: Fri, 07 Sep 2018 10:28:05 -0400 [thread overview]
Message-ID: <b686a7e397b992cf7a32b2e5e7c3503919a8c717.camel@surriel.com> (raw)
In-Reply-To: <20180907134359.GA12187@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
On Fri, 2018-09-07 at 14:44 +0100, Will Deacon wrote:
> On Thu, Sep 06, 2018 at 04:29:59PM -0400, Rik van Riel wrote:
> > On Thu, 2018-08-23 at 18:47 +1000, Nicholas Piggin wrote:
> > > There is no need to call this from tlb_flush_mmu_tlbonly, it
> > > logically belongs with tlb_flush_mmu_free. This allows some
> > > code consolidation with a subsequent fix.
> > >
> > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> >
> > Reviewed-by: Rik van Riel <riel@surriel.com>
> >
> > This patch also fixes an infinite recursion bug
> > with CONFIG_HAVE_RCU_TABLE_FREE enabled, which
> > has this call trace:
> >
> > tlb_table_flush
> > -> tlb_table_invalidate
> > -> tlb_flush_mmu_tlbonly
> > -> tlb_table_flush
> > -> ... (infinite recursion)
> >
> > This should probably be applied sooner rather than
> > later.
>
> It's already in mainline with a cc stable afaict.
Sure enough, it is.
I guess I have too many kernel trees on this
system, and was looking at the wrong one somehow.
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-09-07 14:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 8:47 [RFC PATCH 0/2] minor mmu_gather patches Nicholas Piggin
2018-08-23 8:47 ` [RFC PATCH 1/2] mm: move tlb_table_flush to tlb_flush_mmu_free Nicholas Piggin
2018-08-23 13:40 ` Will Deacon
2018-09-06 20:29 ` Rik van Riel
2018-09-07 13:44 ` Will Deacon
2018-09-07 14:28 ` Rik van Riel [this message]
2018-08-23 8:47 ` [RFC PATCH 2/2] mm: mmu_notifier fix for tlb_end_vma Nicholas Piggin
2018-08-23 12:46 ` Catalin Marinas
2018-08-23 13:41 ` Will Deacon
2018-08-24 13:07 ` [RFC PATCH 2/2] mm: mmu_notifier fix for tlb_end_vma (build failures) Guenter Roeck
2018-08-24 13:10 ` Will Deacon
2018-08-24 13:24 ` Guenter Roeck
2018-08-24 13:34 ` Will Deacon
2018-08-24 13:50 ` Will Deacon
2018-08-24 13:54 ` Guenter Roeck
2018-08-24 14:06 ` Guenter Roeck
2018-08-24 14:25 ` Will Deacon
2018-08-24 18:22 ` Guenter Roeck
2018-08-24 23:32 ` Palmer Dabbelt
2018-08-23 19:15 ` [RFC PATCH 0/2] minor mmu_gather patches Linus Torvalds
2018-08-23 19:37 ` Linus Torvalds
2018-08-23 23:27 ` Will Deacon
2018-08-23 23:42 ` Nicholas Piggin
2018-08-23 23:35 ` Nicholas Piggin
2018-08-24 8:05 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b686a7e397b992cf7a32b2e5e7c3503919a8c717.camel@surriel.com \
--to=riel@surriel.com \
--cc=ascannell@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=davem@davemloft.net \
--cc=jannh@google.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox