From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA6AFC001DF for ; Wed, 2 Aug 2023 02:56:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E97F0280119; Tue, 1 Aug 2023 22:55:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4805280112; Tue, 1 Aug 2023 22:55:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0FA7280119; Tue, 1 Aug 2023 22:55:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BECE6280112 for ; Tue, 1 Aug 2023 22:55:59 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 87CD980277 for ; Wed, 2 Aug 2023 02:55:59 +0000 (UTC) X-FDA: 81077650038.16.EC90DBF Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by imf15.hostedemail.com (Postfix) with ESMTP id 6E6F6A0004 for ; Wed, 2 Aug 2023 02:55:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf15.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690944958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RFSYa+f257kpITVU5+T5xqZyY5TyFeyU4gxeDe/nRvY=; b=IThWQlonvDlYbgiQTtd+rHQqG/vgYq7jqw8ddIwcFZIbqqHuvfkSiAFV8svl3JnwNuRZUG t4IK8RxilaTNs1eCYLh5zRtVphn5RpcblDXL5Jzx5nMC3sZC9J5wVy9Ue7ydjrgdH/FApJ 1WHonlpoK3EHaC3oUvZ0cq9YWd0qxCk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf15.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690944958; a=rsa-sha256; cv=none; b=YPrkskDFkPeCNdLaV6NKCjhqXmBa6k/gOMKK1Nhg0OGZMtUVprovWxzO5AnuaPHsa48Y1N zkhTGOfcuajbfzkha9C+8ClRHOS9+DPEswUsdLwD1by9xEV0BZkXBfKQIMlwlD7HY8fgXf T6+fWk0DuXEwm8Bk8hjI0lN0eyk9c0Q= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0Vot1lRb_1690944951; Received: from 30.97.48.77(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vot1lRb_1690944951) by smtp.aliyun-inc.com; Wed, 02 Aug 2023 10:55:52 +0800 Message-ID: Date: Wed, 2 Aug 2023 10:56:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 3/5] mm/compaction: merge end_pfn boundary check in isolate_freepages_range To: Kemeng Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: mgorman@techsingularity.net, willy@infradead.org, david@redhat.com References: <20230729174354.2239980-1-shikemeng@huaweicloud.com> <20230729174354.2239980-4-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230729174354.2239980-4-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6E6F6A0004 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: rdhw6a3uemsjos93c6o4mo8jo5iakg6f X-HE-Tag: 1690944956-604564 X-HE-Meta: U2FsdGVkX1+3cnoryenZdu5uy4NlYs7AbhEPo9IJgCBmVldrUhEK5xUqLYa+Oj41Mq8XUUGTLQgOEttBo3Evmtg6msWpkH+rh9K9sMbjfyOh50TTjrTCKmLmL6eOwZeRyZV51U7Omo8fsvu2lSWpw3FYKmN4lIt2YvjMvjqwq1q3jSTCkiWL5jS2CsiDu3GSbpUNp4DeihjHcj/ZL5dCAYYAYFpqAcK/3uqUM40665N1tScmMHrLOln3BScAHvTo+h8vMbsg0Kd+Jr2n6T9gm+oXI9CdSgty2AMBemlLHKJCpij634WFhWj3mSJ0rDVPOpV485/THrqo55VXAabRunX8i/WkCnxvZvOBBqLac7XrfBD+WzvgO2zxHjQT2lDlChoMPgyTzFAvb/DmpVd/597RIBl4OaLbmNxTfToG/ZxmYiDvgKPUNlP7R8vKTRFY+YcVcVGb2PGkXbsS7M3SM9/vjiHDOmgRWfeUFY7V22aWtifYeN73wLEd/Z+Cd2KhE1dZNaoWffI1UrUmXlmHU5/w3kTvTDecx7grsBngCTT5CY3xAufJtqJ6iLwufazCPJipVU+2wfaexPqQeqHIA0XXtK6KJKiQT6FWwYES9NRaYiLFhRh07CPMZxVwsytm+X5nM4UV4yFx8CaFfTufjhCNh2qZ/dNZykshhhDoQJ6MmoG2oz1QfzYBJ2TY9iKCeNMDNHLkcRuZIF31JLCmQ8+CUc29DzM67EJ2byeWdBODlLBv/1MYM71bsMx5xYFiju9zWyPcxzpHc/xndkLfKdmeNoEfdkdRpeTHfeWaYLEEpr11P7qfGz38CLymR+wU/drvV7ydIvvDPCE3Cbl3YuRGA6mHro9D0jjG6/tYgWt5FycjCzwX9sEPw6G2TWOEXWcsTwLXHHuo1yqbT31H3MnhxyvHh8Y49RIhodjTCMhFy7s2uiffcSphcKeWlBaYXGbL7vhCRwhc9vKvcvc bLGjxxby XGOvDbyPNdfRc3w4UiHg274bblgdm1CflPBg5QB05ojZeGFUw1TokQI9EOtJsHYJK3GsqXI7f1Sw+X5qZwlbLmRGlujOAW/woSMm5e87xrtG74fliunI2DorIGSzpxxhqoCGh9eJYrK70fBdBvU2okQsiXGRMoikbsbR1L5W+RZvp7adcGO/KUbDZc+mkUGch8ySHuHqhZEYCspsJBVjf+CpYn0t83BfUTb4NsoPy8LRiE8I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/30/2023 1:43 AM, Kemeng Shi wrote: > From: Kemeng Shi > > Merge the end_pfn boundary check for single page block forward and multiple > page blocks forward to avoid do twice boundary check for multiple page > blocks forward. > > Signed-off-by: Kemeng Shi LGTM. Reviewed-by: Baolin Wang > --- > mm/compaction.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 4a784872565a..65791a74c5e8 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -740,8 +740,6 @@ isolate_freepages_range(struct compact_control *cc, > /* Protect pfn from changing by isolate_freepages_block */ > unsigned long isolate_start_pfn = pfn; > > - block_end_pfn = min(block_end_pfn, end_pfn); > - > /* > * pfn could pass the block_end_pfn if isolated freepage > * is more than pageblock order. In this case, we adjust > @@ -750,9 +748,10 @@ isolate_freepages_range(struct compact_control *cc, > if (pfn >= block_end_pfn) { > block_start_pfn = pageblock_start_pfn(pfn); > block_end_pfn = pageblock_end_pfn(pfn); > - block_end_pfn = min(block_end_pfn, end_pfn); > } > > + block_end_pfn = min(block_end_pfn, end_pfn); > + > if (!pageblock_pfn_to_page(block_start_pfn, > block_end_pfn, cc->zone)) > break;