From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B529C2BBCA for ; Tue, 25 Jun 2024 06:41:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 195386B00A4; Tue, 25 Jun 2024 02:41:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1453A6B00A9; Tue, 25 Jun 2024 02:41:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 034116B00E6; Tue, 25 Jun 2024 02:41:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DA0516B00A4 for ; Tue, 25 Jun 2024 02:41:05 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 610131C2D10 for ; Tue, 25 Jun 2024 06:41:05 +0000 (UTC) X-FDA: 82268463690.30.477CC7B Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf16.hostedemail.com (Postfix) with ESMTP id D665B18000F for ; Tue, 25 Jun 2024 06:41:02 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf16.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719297650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d+sqJv3LF9fZodCoDGndVteu8gOAaAgl4i5xtCgZlV4=; b=WgH5aq5yplW3gn9N2lX1cIfbBgT4TzzILCKxjyEd7TGgftIM00Y9xpju//EUpUt5Adfret 6d0TfJlG8niU4N+8ELkfKMjrzczSTOQMclCYki7wCD1j1PnME76QzKRq4pAoB5qEeDia4d uxhi+Xgube7IX9MyE/ZR4fTuKUsmTEs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719297650; a=rsa-sha256; cv=none; b=5VFnDGiv4sLCM8ZWKzho5SyiOy6JIiwOBeHZYvpddPsTlhWya7nreRWholsh1DBkLsSKM+ J7a4KpPWa7UOxK7wopCemv0di0nNfgcPBeN+bzpPqJg0dZr2TynvDDGj0FO6pyonmlqXml FnS0mgIAUyErKARbJWakcITOHOkDGIY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf16.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4W7ZqW2h1XzxTcR; Tue, 25 Jun 2024 14:36:39 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id DA443140360; Tue, 25 Jun 2024 14:40:57 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 25 Jun 2024 14:40:54 +0800 Subject: Re: [PATCH v5 1/4] mm/memory-failure: refactor log format in soft offline code To: Jiaqi Yan CC: , , , , , , , , , , , , , References: <20240624163348.1751454-1-jiaqiyan@google.com> <20240624163348.1751454-2-jiaqiyan@google.com> From: Miaohe Lin Message-ID: Date: Tue, 25 Jun 2024 14:40:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240624163348.1751454-2-jiaqiyan@google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspamd-Queue-Id: D665B18000F X-Stat-Signature: 46ynsfybmnp9tp7mz9gyp6uictumr9hi X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719297662-343525 X-HE-Meta: U2FsdGVkX1/5CbQFQFOmo1M2drMubd7jGTmYAO9iti8K6bqLF/bHEMP8SFQfiAxqNefhvNbqAWGOTX6yfI06qTfSVK4sf0v+UD6PDQMJG8ZY/rH/01FiVHToFKLECR1ghn5Pomnpva+6rtpas6G9u14HB8Yf4Bk/EsXp/L5wk7qEu/HD0lrkvlaW3VuGoQKovIckC18TDWBhoC9YGkxdDx2+FPS0pqWsv/23fQ71IcW1vr6U5ldTjirCCsshOLLPh0zPZeA2zrpL0cr/mO6S7W1l310w/YSC7nheRQI6NldBk6C4w8HoJEDVRQA5k+xmzynAdDgniZYyuZNjF/LtNv3DfkGKIx6aZW5LD+nixRgC3NkAASXVGQgnu2lPYHzH1FjX+253za/ND/6zhPrJTcCB12QPVrhMj7azJF6dX8ylB+xM+OeHnKSUcMLUU/9UaK+0rnmZlmArCSWU0LHkcQ4Q7Dv9efFDhQj5gDr0EZziSiiMNKvhBPCxRkGfUetj9qPrZTNLE5Blh0Dw2m2Jt87GJSl5lS8H79TzKYKnkLWFibGjqXKQ/cbPKFonTQHImP+bZ4gMJbQnFejvZmazAZxpfmzsX64fYRLOUfs1fzfRf8Rospl/5P8FXFzirY6hvErphZg0SpqT1QF+s5SEksTVjxubLjW5cza6GD6Y10l0hFJfX2awZA9gM7vmOIL4OPpiFtGmBn7Ks2Q2RDFOhp1vFgE3f6S+m0CRGEbAaufaN06IhfJwzBwy2PajsWkSbrpBuMof6/rpqL9CVJFL+y6ZaldH9js4g3cuBMbnrSMYGQwyBkrZVrTAGq1opcNXBp7nCw0NX5p2fvpwIy17+62dmomleWpRzKcVaA839g69seTdWkzKHfxiShTdF64rXNp97JjM9pxE8noNiR4rinsC7lYYT7IN8aq7aJhiwTRIUNm4Z0NjogPc24Jr2bh24bZfPVHLhOWaAni/T4C xzAOCiTr gTMVDnBgGdbG/o7hGKson4oEbCWCUiS/XsjQfqfVlkqdLUclm0OrR1fQxxiNmRt4Ibm1HBMYldaLTak5BjY2XHmh81Qyl9wPVFE8w8XJ15G1BJGQGha7uPMkILJE0uFJZekuW8ytvOWWnS76lukaLcbZ8pY8f+RPPW7pVQBvVK+WK8tfNCmb7PpvrhPd0CqVxh0pqMOwlG6ohRW4p11A4iLgHLT53yrLzTwqo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/25 0:33, Jiaqi Yan wrote: > Logs from soft_offline_page and soft_offline_in_use_page have > different formats than majority of the memory failure code: > > "Memory failure: 0x${pfn}: ${lower_case_message}" > > Convert them to the following format: > > "Soft offline: 0x${pfn}: ${lower_case_message}" > > No functional change in this commit. > > Signed-off-by: Jiaqi Yan > --- > mm/memory-failure.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index d3c830e817e3..2a097af7da0e 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2631,6 +2631,9 @@ int unpoison_memory(unsigned long pfn) > } > EXPORT_SYMBOL(unpoison_memory); > > +#undef pr_fmt > +#define pr_fmt(fmt) "Soft offline: " fmt > + > static bool mf_isolate_folio(struct folio *folio, struct list_head *pagelist) > { > bool isolated = false; > @@ -2686,7 +2689,7 @@ static int soft_offline_in_use_page(struct page *page) > > if (!huge && folio_test_large(folio)) { > if (try_to_split_thp_page(page)) { > - pr_info("soft offline: %#lx: thp split failed\n", pfn); > + pr_info("%#lx: thp split failed\n", pfn); > return -EBUSY; > } > folio = page_folio(page); > @@ -2698,7 +2701,7 @@ static int soft_offline_in_use_page(struct page *page) > if (PageHWPoison(page)) { > folio_unlock(folio); > folio_put(folio); > - pr_info("soft offline: %#lx page already poisoned\n", pfn); > + pr_info("%#lx page already poisoned\n", pfn); Again, it's better to be "%#lx: page" to make log format consistent. Thanks. .