From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2F36C282C5 for ; Mon, 3 Mar 2025 10:46:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77334280003; Mon, 3 Mar 2025 05:46:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 722CE6B0093; Mon, 3 Mar 2025 05:46:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61280280003; Mon, 3 Mar 2025 05:46:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 442AD6B0092 for ; Mon, 3 Mar 2025 05:46:38 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EBF19C06CE for ; Mon, 3 Mar 2025 10:46:37 +0000 (UTC) X-FDA: 83179911234.23.A2EB1E7 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf14.hostedemail.com (Postfix) with ESMTP id 39250100006 for ; Mon, 3 Mar 2025 10:46:36 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740998796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xto8yvtut54VzIXvAvSpVKSvQNZLOGzamPvWaxUKQLo=; b=14IuWdyoyAYJIuG+WCC5AVG/WxC+jWDQYpRI6xIebLeJgYL7rAHBUHU5GyA94edf8pOhap R4P2DeHkkz8nJ415uI/jphZO9oAyqRmCzmW1JtQcF1HIC2jWmbRlZtjWMz0xVYL/seyUWK sxk4oxoXm/FLjXGwrBA7AhrxJnPjZt8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740998796; a=rsa-sha256; cv=none; b=iyOBlFK1jxzlXofQ2bQnqNhL0Gq64WP7EuSgNOv31gKi2MSi1VjwnZRwO1lV3fURmNl1Fu rN+pcFBltkIr75YvQmwcIGPX2ZtdysFhUKJDTUQ42atTTSxT6WYXQ8qhkYWnWMKqI2Oo23 Wujy39a326BbsvhdaVuVgHif93tQQKg= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6BC34113E; Mon, 3 Mar 2025 02:46:49 -0800 (PST) Received: from [10.163.38.109] (unknown [10.163.38.109]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C56143F66E; Mon, 3 Mar 2025 02:46:32 -0800 (PST) Message-ID: Date: Mon, 3 Mar 2025 16:16:29 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/10] selftests/mm/uffd: Rename nr_cpus -> nr_threads To: Brendan Jackman Cc: Lorenzo Stoakes , Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> <20250228-mm-selftests-v3-4-958e3b6f0203@google.com> <18ea9794-3901-4802-875c-b0327984a9d6@arm.com> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 39250100006 X-Rspam-User: X-Stat-Signature: 19z56xkbxzjtt5x5nxqax11himj7k9j8 X-HE-Tag: 1740998796-635462 X-HE-Meta: U2FsdGVkX1+J57Fe23CeRB+jZhO4f6dVuZz1HXZCGcte/W+ZV8WWqXJ9thwFjxajGFifqMosO6WcKg5EBIxQ7BlC4PC8dp8eYI9deCJ0ogAlYdlBfR4HBvlhXoRfBHEL+xMzeKFTCWydGZUiFw3ynNcFiyoQ3TUT0o1OUUOyLSpREyDDlsAKi4YewkaBwUi6PkSySb0chF3ZByV0UL669NXwaM6H6pHjBLhrK4FPzrjp2EsAwxjOyr0l3w74hU0yzAbvb94m5bwRqKRdHtUq30/Q0Pf0wQ9bUFPhaPo/10AA8pPpiHSBpLr0hWoCoZv6z2D0gNL3bUXLdz0RH+h+xa0O8Qdi1lvhkaPxkMzvFJwUhHUn5EvtoUr88nzSUHHSt9MS3G+nrLoHgc5VLcHh7x4o3U/kyOYNfZlI3ZbP03fqb/A1YEEpU6EHcOySz1OsXyTd5C4SP9B6ygUPMudyjsusFuxddJGtl8ZnnVd8h58PsMIdNLFjUBmNfhqw3L9UdB3WTDKDfmMZ4B/4GXvZ4V5pVHjdHRBJr+t7sJ6zMZhuVfR0DurSk+u7lhcZFoQVtNt2ua3Wm4j9QjfJrxg5NwARDRsks4Tu+CpdkNmU9gV3HhQpd0Es+wVQiDuyIjoEbTAGB4JaFrxonwLUO/bgtUK9pzcy6PflzeUiKTD9oUnPyKKKHrnEy53LGCj92R4JzSfdIe0xe/un2o8Oza3zTzQrPIbG2gZ9hctjzFQhEl6VeRZuPtFGmzCmAaR4IOftiODaso/t+bhOIDtwF8YV4N5LLtK5xDo59f6xCNgCGtl0Kk2XtTSQCaFy6FtLaUIJODBaFSzB601YhSycjJv0CWF0x7mbbS8G5Fd9+naU/SeVYY/otwYAqNgXoTvJ42kQrMpziBnDoU4h4/qhsoeqF9ryVncCx1lPNWRN5nWOR4KXIbE3D4sLGxURzaa9CBWGWiRUMob7Uv/g9p6qk5k FMyp7QYr ILUtDmgtxxDnvJF8l9QCQLz/3lyd99BygwJWWS45G4ioik1mIft/1royrRF5EWb/Xqz95/+ewjf8mPg9kmHPWA1cLWY+lmW5z82JgWELPrMxJClYE9fDeNDCDOIYIOZIjgsCHhUjWuOVyI66unOZGk7osWhuDRI7//4bR5DCG7Zlh524cbshvUrNm5D6w8TgBVHWM2Tg3INS8qvX4kOJPNjLJKzxjhRh/hXTb73xSz9G8Y+vPU8Jeoiuz7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.062102, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/03/25 4:04 pm, Brendan Jackman wrote: > On Mon, Mar 03, 2025 at 03:48:38PM +0530, Dev Jain wrote: >> >> >> On 03/03/25 3:17 pm, Brendan Jackman wrote: >>> On Fri, Feb 28, 2025 at 11:06:35PM +0530, Dev Jain wrote: >>>> Taking a cursory look at the test, it creates three threads for each cpu. >>>> The bounding of the variable is fine but that being the reason to rename the >>>> variable is not making sense to me. >>> >>> Hmm yeah the name needs to be more abstract. Do you think nr_workers >>> would be confusing? Or even just "parallelism" or nr_parallel? Or any >>> other ideas? >>> >>> FWIW I briefly looked at just cleaning this up to remove the global >>> variable but that's a bigger time investment than I can afford here I >>> think. (The local variable in stress() would still need a better name >>> anyway). >>> >>> Thanks for the review BTW! >> >> Your welcome. >> >> I personally prefer leaving it as is; unless someone comes up and completely >> cleans up the structure, let us save our collective brain cycles for more >> meaningful battles than renaming variables :) > > Hmm, I think that's a false economy on brain cycles. A variable called > nr_cpus that isn't a number of CPUs is bound to waste a bunch of > mental energy at some point in the future. > > Unless you strongly object I'll go for nr_parallel. It's not a great > name but, well... I think that probably just suggests it's not a great > variable, and I don't have time to fix that. nr_parallel sounds better for sure. In case you send out a new patch: Reviewed-by: Dev Jain