From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CFE2C3ABAB for ; Tue, 29 Apr 2025 15:46:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CB086B0005; Tue, 29 Apr 2025 11:46:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 779526B0008; Tue, 29 Apr 2025 11:46:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F32A6B000C; Tue, 29 Apr 2025 11:46:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3A40E6B0005 for ; Tue, 29 Apr 2025 11:46:02 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 04EAF14086C for ; Tue, 29 Apr 2025 15:46:01 +0000 (UTC) X-FDA: 83387507364.20.BCB55C1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 6B519120015 for ; Tue, 29 Apr 2025 15:45:59 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f1AHNA6s; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745941559; a=rsa-sha256; cv=none; b=FxakP5Pv8lXcBLJB4Vt0jql8lvnAAR3xX4sYU92vVsYfYr9/KZeY8T2wZNqpdcdobnsPUv fWJB+Rr/NaIMLfmleU3yQgLGDXmYF1h0y8zoMPI0hkYgfQwUYSoX0cy1+wyUFoqptDJWyh 4s9w8t/rfCehqBbVKamzJkm5nSBB/Jc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745941559; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KJkBeINQl3NFAYCfsyQAhOdLaYy8cgJsBpXeXsGczuA=; b=V4lj7lLfD8gYEdQ9/NOTZ65+be1DPjOyF3r+gYIG9eLnU5NPEXoQFh8YImAzcNd6bPe4iT rLedv0YiUBaqGFCiyyWftcepGkl0cE9Y0dalVK0K5CVFg1Kk2iP0ZZO5I/1LFjoIVZgmyJ 5TC5iFni5Fp+qrLMZSRHS8T3LWHW7jA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f1AHNA6s; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745941558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KJkBeINQl3NFAYCfsyQAhOdLaYy8cgJsBpXeXsGczuA=; b=f1AHNA6sPVUg7GllMvk97PBgMogB6bifn1nvYDARUSuV4cH94T+RXb0uwpLSJpL2Ug2YCS 3WJz1nHMye95JoqWr+I3syaeOFuT4GcLGrr6f0i9cb+eXCVZIL8Db3Xw9abzZh+YwKJISK QkbujnHHXRxQ+Zws5d42odqldKkioEM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-yTsEzHckNNuLLLC6EX5kGw-1; Tue, 29 Apr 2025 11:45:57 -0400 X-MC-Unique: yTsEzHckNNuLLLC6EX5kGw-1 X-Mimecast-MFC-AGG-ID: yTsEzHckNNuLLLC6EX5kGw_1745941555 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43947a0919aso43120045e9.0 for ; Tue, 29 Apr 2025 08:45:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745941555; x=1746546355; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=KJkBeINQl3NFAYCfsyQAhOdLaYy8cgJsBpXeXsGczuA=; b=YLY49s3wl1ZiFXO2IXMb3PriJZgqgPi8fyD/9OAtpOGnH9T4874CD3nk4FB4EovXII 2G5/IRkgoCOgTu3Lx12FFypfMCWIsr1V18KDRgIJzTDe6Re7LBONVCm0Ll6QDg2UtBBi RLqgiYEEBjxDIRQO5LXB9LlrzCwPHBS+GN5Sxl5E6YqtEZI3RQMhJQHoQU+ACtA9mD4c Vd8+WakDbcPgVSXmhyfzF5PWp33ps1Uqb4jDFECqU9lv5B0Cbp9MidQp98Lv+/Qem0LY uHxxGr5CChO9tHepfDHAlGLJySEsdupeONX199ynz45CmMAJiWdaMvk1qcm+f1GR76k+ LWog== X-Forwarded-Encrypted: i=1; AJvYcCU9bKeyR4qgs4M6r5BUS4BG+WcNYMs/cRqmU39ipCxt6u3mAmuJH0bnzZ5/SCMeN4asSngdPJoCfQ==@kvack.org X-Gm-Message-State: AOJu0YxFkeVYNWWRXbvF/BVS7sFKh1nt9cigWtijknQItYzQfigf5KOT Eiid0aKyXr+C0h6oAXZWeo+zaDcRmKHMRZsdACb9/lcdfuGSaEvdrN4X86nZLNBGt7+WGRns7Wl XWy7lOhGhT4gO4o0/6I3vXLkoBFBu/eKMVBO8/Fodscrx0+vV X-Gm-Gg: ASbGncuPkD3jP4b2xF754psiAyYOWctVptvYJSB6L4eV4ujlEEjlUOKbyszl7xmb8jC pLV4tzMgi23sHsPoe7H+FLhkWdAup7HNFQkkDaAuC1fMSXkD1+oYd+XhpPT/zUbZ3D2FVtJmmA1 VuAkYW0sdCqXrFiJZh3mK7kxdOfOFSvyUeTfBScMCet5Z/RU38bt+iBNOjK336MqoSHdqcpSt5V DtcnfdHSZjyJKsII5E1Mk3/7TWHMA/SE2C8vrWwg0zvIp4o15xw1sCziEIfraZDEg8goXBq/P1j 6ylgrweLBbCkb6D3InjH8mCoKKH95GjIK1YyGTUgTMVFtJKLkzJP6gmktLCbktTSqN8CAcwXH5X vD+r3n/NVdXcyugM+w2LeZNPZ/Esm+ECPHvkhr8Y= X-Received: by 2002:a05:600c:46cf:b0:439:9424:1b70 with SMTP id 5b1f17b1804b1-440ab871770mr128621565e9.30.1745941554864; Tue, 29 Apr 2025 08:45:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFt0DK2rmUfljN2z2b+q11frPzsFEc1skfJ0nZYXWdcoUPJqbsw4oWgy/3IkPCYXvYpVzK/AA== X-Received: by 2002:a05:600c:46cf:b0:439:9424:1b70 with SMTP id 5b1f17b1804b1-440ab871770mr128621335e9.30.1745941554500; Tue, 29 Apr 2025 08:45:54 -0700 (PDT) Received: from ?IPV6:2003:cb:c73b:fa00:8909:2d07:8909:6a5a? (p200300cbc73bfa0089092d0789096a5a.dip0.t-ipconnect.de. [2003:cb:c73b:fa00:8909:2d07:8909:6a5a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441ae3ee26fsm19485125e9.1.2025.04.29.08.45.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 08:45:54 -0700 (PDT) Message-ID: Date: Tue, 29 Apr 2025 17:45:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm: Fix folio_pte_batch() overcount with zero PTEs From: David Hildenbrand To: =?UTF-8?Q?Petr_Van=C4=9Bk?= Cc: linux-kernel@vger.kernel.org, Andrew Morton , Ryan Roberts , linux-mm@kvack.org, stable@vger.kernel.org References: <20250429142237.22138-1-arkamar@atlas.cz> <20250429142237.22138-2-arkamar@atlas.cz> <2025429144547-aBDmGzJBQc9RMBj--arkamar@atlas.cz> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WdYZGWIcTjNZeWvGjqs5uIP2zoDmpkt2OBvQNxFG78U_1745941555 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6B519120015 X-Stat-Signature: zfumckt8qj5qhb11pybhopohh4cmd9h5 X-Rspam-User: X-HE-Tag: 1745941559-573417 X-HE-Meta: U2FsdGVkX1//mcmNChMT659T3ZRSssDUS9q55Qtn/7oYCmHTY4g2GrNNYoVHBgdgBt4XhhcXPi78XPD+7kOddBlic/Mu+Ox7VteapBHcKSsm1UMebTkcWLgkfTMXFZn4e4F7g3eX28QNZwwbCHEpd3tgMSO3eYwhayHZJ01WMGp0FepaldxdW2M6geVyll+35tTJr6EFwSRhQ30ioLygRwAxUkO7slRpeI52QMJ8jftnFvglgChdLrRYGAbhmGE12oic2Fftk7TGtAxIejnSTjEm+OkYibP/ejw/GVb+NGQ2XVOvWsXXtRY7g2x49ef4ddKiotcQoe5MUVZFU8Vv/kpxjvC33tY9P0iumzU45BpwreT4AW/SRJUJzRMI/+ca/tG+XlyLdAqbgTluXw8Gmf9ReDAOQpoKvjKBhhfrO/IU37L9lk+E/j9pOYU3c1Mrio9c3qw3jsvqxfWXoX0VM9iiMb5tCsFHL9BkJf0y/S6rhS1PZO1t2lEb3Bx7oBa2JicD9JRooNxLuEcz3g3uVCnonSfsggtPwnCZn+zQfE2nPTi1UixbitDI9OlkCJ6QF65utXL1NMeUxuxXehCKOiEGLywIKq6DOxhNgXZf8rdyfw2sGTSpi9dRIiwoOTq4FITRIBlGBjtio8L8SgAgYm8zHgRk+k236n8Z+6vz+bYMW8B9NHwTSc3USqImCo+peszkmzoeVaE3NVmelb1q/0oPuodGNoxy0LQ4zHnWe0GCVGcrAfaCm1BB2a+marD+KQUTFce8aOmcVFK2siKCeMvjqNwxrn0suuyx+jFKFkmEpzLmH94Wq34Gb83S6wHJN2JxSQSF2c7HWdR9RpUqD6i1FFvooYkSQjV2nk0xMv03eXZ7aJna94dAiqr9+MT4+tmIubqYoA1WNJq7yy80rcJYyMo/ZLlNwUw/zWkuyjyt2Cgo8UOTDrm5bNFyfWCY9ZQgXZD5WVXgmX7MQ+P dDJs+CLv ribusPqs1Weons4+kSJPiNkzTpFveJE37P1uYrTqPHhgbU0tGBluTdOaXnUOdhYZeNhO2dvxyHD+q93SFXcmTaQdOrHBO4AefuBBBQrqF5KJ9NigxUoFQPnr1dtWhGTRjIMxCojJMBqg1FN2pOpJwqzWiIkCVDkMy38zPx8tyv11J0tuO9Lml+5T9uaQjsHJGciwFV76wpQjqmL296SzaEy3VKdoHnTdWXQvvcZ1QMMF81deROl+PndVs8SEvMhOyMb0aq9YRG6Y2JEIIbCpfKQ4HwA4p9C44o0/alhHmgNBrONTgBuKC50Mh4zFG5q7zwyJYhuNHW8OQKpkO2fxO/LFZEFbbFFKer+f5D8oBBd1Y+HQQUFoIEyu12iZBxTLel5M+YiEbLPTTp8GB8VihklI0aFpFWjo8NufY4lgKh06vt15WZcECmpwXYW+B20BAQBSfjx47NcT2H2R9nUDwO2l5eHUoNXf7H2lPqeR3wn/KzBpl2wOwhG712g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.04.25 16:52, David Hildenbrand wrote: > On 29.04.25 16:45, Petr Vaněk wrote: >> On Tue, Apr 29, 2025 at 04:29:30PM +0200, David Hildenbrand wrote: >>> On 29.04.25 16:22, Petr Vaněk wrote: >>>> folio_pte_batch() could overcount the number of contiguous PTEs when >>>> pte_advance_pfn() returns a zero-valued PTE and the following PTE in >>>> memory also happens to be zero. The loop doesn't break in such a case >>>> because pte_same() returns true, and the batch size is advanced by one >>>> more than it should be. >>>> >>>> To fix this, bail out early if a non-present PTE is encountered, >>>> preventing the invalid comparison. >>>> >>>> This issue started to appear after commit 10ebac4f95e7 ("mm/memory: >>>> optimize unmap/zap with PTE-mapped THP") and was discovered via git >>>> bisect. >>>> >>>> Fixes: 10ebac4f95e7 ("mm/memory: optimize unmap/zap with PTE-mapped THP") >>>> Cc: stable@vger.kernel.org >>>> Signed-off-by: Petr Vaněk >>>> --- >>>> mm/internal.h | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/mm/internal.h b/mm/internal.h >>>> index e9695baa5922..c181fe2bac9d 100644 >>>> --- a/mm/internal.h >>>> +++ b/mm/internal.h >>>> @@ -279,6 +279,8 @@ static inline int folio_pte_batch(struct folio *folio, unsigned long addr, >>>> dirty = !!pte_dirty(pte); >>>> pte = __pte_batch_clear_ignored(pte, flags); >>>> >>>> + if (!pte_present(pte)) >>>> + break; >>>> if (!pte_same(pte, expected_pte)) >>>> break; >>> >>> How could pte_same() suddenly match on a present and non-present PTE. >> >> In the problematic case pte.pte == 0 and expected_pte.pte == 0 as well. >> pte_same() returns a.pte == b.pte -> 0 == 0. Both are non-present PTEs. > > Observe that folio_pte_batch() was called *with a present pte*. > > do_zap_pte_range() > if (pte_present(ptent)) > zap_present_ptes() > folio_pte_batch() > > How can we end up with an expected_pte that is !present, if it is based > on the provided pte that *is present* and we only used pte_advance_pfn() > to advance the pfn? I've been staring at the code for too long and don't see the issue. We even have VM_WARN_ON_FOLIO(!pte_present(pte), folio); So the initial pteval we got is present. I don't see how nr = pte_batch_hint(start_ptep, pte); expected_pte = __pte_batch_clear_ignored(pte_advance_pfn(pte, nr), flags); would suddenly result in !pte_present(expected_pte). The really weird thing is that this has only been seen on XEN. But even on XEN, a present pte should not suddenly get !present -- we're not re-reading from ptep :/ -- Cheers, David / dhildenb