From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F74EE77188 for ; Mon, 6 Jan 2025 09:34:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 185406B0082; Mon, 6 Jan 2025 04:34:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10EB46B0088; Mon, 6 Jan 2025 04:34:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF11A6B0089; Mon, 6 Jan 2025 04:34:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CFD956B0082 for ; Mon, 6 Jan 2025 04:34:24 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 54B201413B3 for ; Mon, 6 Jan 2025 09:34:24 +0000 (UTC) X-FDA: 82976516448.23.8F2DD39 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by imf18.hostedemail.com (Postfix) with ESMTP id 8ECD01C0002 for ; Mon, 6 Jan 2025 09:34:21 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=AYv8XxWB; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736156062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M8lTSA5py1VNeH7wK2Bn79u4g3AsD2U1AjR2tynOIls=; b=dgVBnbkFRapxtbbme37pYqcPvv+qdwywWm3Zi5feRGlFl3WE0RpXo2kcenLe2Y4gdd1YZo ZKEOVtZcyS5Ty8kzRgjZmxs56KhaLGxZEabdScutuJZ5GKF2gud30Hpll0FvCRoBjMOAYM zwLpiSFYOIja5lftHatvuuDexOIRgis= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=AYv8XxWB; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736156062; a=rsa-sha256; cv=none; b=g9+M9lqCGgNFbhI/pjBcKk8nFin3VgQXx9QiNV5orz3DgOQuMImimsafy9VjchxdAXsvSs tPGRLUUVEQIyDUyjor8f1KzQ/ns4v4gTNzhfwzWpQAPZpgOMDQSlksUbCJn6nVS8UfyCMT ByMqEP6H2OdiA3Gg9cph7fffGoNR9LA= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1736156058; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=M8lTSA5py1VNeH7wK2Bn79u4g3AsD2U1AjR2tynOIls=; b=AYv8XxWBSAyp4QZMzqL2DYg4d42PWzC0l4hIuz02h3jdzeARXvgCpiSYCpINLIo1HHadNFeFzt1UypwN83mJJ7gsdj8YdQFCSyd44AY0dUNz2dNDUtnWBTMPFGw1wKzIM1ahmyUq2oy21oXcg4hjYOHiA9daiqxgXXwiEcW2Pgw= Received: from 30.74.144.118(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WN2FNnI_1736156055 cluster:ay36) by smtp.aliyun-inc.com; Mon, 06 Jan 2025 17:34:16 +0800 Message-ID: Date: Mon, 6 Jan 2025 17:34:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm: set folio swapbacked iff folios are dirty in try_to_unmap_one To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, ioworker0@gmail.com, david@redhat.com, ryan.roberts@arm.com, zhengtangquan@oppo.com, ying.huang@intel.com, kasong@tencent.com, chrisl@kernel.org, Barry Song References: <20250106031711.82855-1-21cnbao@gmail.com> <20250106031711.82855-2-21cnbao@gmail.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 8ECD01C0002 X-Stat-Signature: rmgrhndskg1te8xycpnox7krdoz5yxkt X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736156061-409559 X-HE-Meta: U2FsdGVkX1+RkUQ82kM2+0IfeN/DRCNDir/EDdhT8cEOWXLpLfOppY7LCdn3CnP3lkNysAXl/TItR/Z8Xg225sroeEaCRILXF+0j4YKNMruZAjWth13NZt4XXXiibkCjCnetZ8IcTXClIcpXlmpxHbOeWCMEJNFtxUr8DutNJLUMDF25cqeEh4W4J5tee+dszPU2BfGlzSzGpVDNBsAHbLDmBLva1khXRBY7o7wJHE1iDR1bN8mshwM/cIltTqPQPiVJOPsvgibh1nmYXa84z0NvCCF/pLlCtwAs8etrIb5eqF/Dit1GKG6AhgE6Hb4qJX8RcoGdH8hQqSe+SAh9UO6+Mz/tm/Uxz8XyvXC1HiTCJJ0AKoooDKmV5SlOcjWOkSpjFV0QwMlrD+vi2N/k8YKa2r3mpqg3tZ52XJe5ZTwNc1WRkvMZ151dqZsoQ6PFoowBvKZYtkian5RXr4rqsm2A4PoNf0mTzht6o7cqz1r0uJjSqVMGuF+WSjsDx6TTdxsSAV7PNCH04nNL/JYyGYujXKrvU18lAENPcn6JO/QTMKazgeUaGqwOiLQliGOobWev8zgqjvsgJT8VkuKiIxOrW6hcsBVkqCDCoXaYbOoYw7GPa7baZExLVvyfiQWMXPF8k8yM1NLxuXnP9srvcyDOKTh6T5ke8Cw+XJ8GN4SaPKDyIoH1m4bZyu6YBEt+gYSxOpzPXCgVicVqY5+1eHRktMMfp7s8AowDdpRxaE1io5UNJJE4+uxG39+khnCAz6gZPJpPP/yw8ZhrUPlLUqTsNEguLVmDNhzzaQ9bFqM2+b3sekRhkvyG0TFOvi5FHC4X3uaPQX7Qjv+aZhqCb6pI5BCP+Jq2SjrzWrQspD4+EZl6aNEY49ATChxYihR7zAULmnxD7FxT3nVHrkvSNEwGntgdPx/2662j6zvCb0+j0Gd6o/YOrI1tHX/sWQr1lh6eB6WHQe5dfd+rRLN HWvnfkd7 QJ6tEAqjyLEe8Bd47zH/TKhDAgjYEGtoo183/4n4n+tWE2jDs/8OAk8Y7TkNS7GQ8tJNxBNCJQe+8EQyZGpQMFoopXrn9sHkoQ33yWbPV8g3MPxyXpLtJuiq+MJqDdVMVEQ72Gc0O8ZO7pdxwAt4R7x+9Fha2iGaMm/atmNP285zlv2mmWxkahlA0Am4LUFvJFmaahwd2qRWtVtrjMPw2wP09bnpgUdQILLUJYLjiVzPkWzvjjBB4B5k01FKA02GfUX+nlhWXQwoFrKnq6ThZes0D1RNVspzcURoZom3mal1ywLlTGwU+kwEf75nYZZd56zl+ciG/awrAmIsqoBsjMtoChksukercogf8a+QF2nHXvOgQbC50tgy9dsWvuDJZAOttJm/Kypu7Ftg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.109440, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/6 17:03, Barry Song wrote: > On Mon, Jan 6, 2025 at 7:40 PM Baolin Wang > wrote: >> >> >> >> On 2025/1/6 11:17, Barry Song wrote: >>> From: Barry Song >>> >>> The refcount may be temporarily or long-term increased, but this does >>> not change the fundamental nature of the folio already being lazy- >>> freed. Therefore, we only reset 'swapbacked' when we are certain the >>> folio is dirty and not droppable. >>> >>> Suggested-by: David Hildenbrand >>> Signed-off-by: Barry Song >> >> The changes look good to me. While we are at it, could you also change >> the __discard_anon_folio_pmd_locked() to follow the same strategy for >> lazy-freed PMD-sized folio? > > it seems you mean __discard_anon_folio_pmd_locked() is lacking > folio_set_swapbacked(folio) for dirty pmd-mapped folios? > and it seems !(vma->vm_flags & VM_DROPPABLE) is also not > handled properly? Right.