From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F0C4CF11EC for ; Thu, 10 Oct 2024 12:56:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECF196B0089; Thu, 10 Oct 2024 08:56:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7F186B008A; Thu, 10 Oct 2024 08:56:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF9556B008C; Thu, 10 Oct 2024 08:56:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AE21B6B0089 for ; Thu, 10 Oct 2024 08:56:12 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B3834C0122 for ; Thu, 10 Oct 2024 12:56:08 +0000 (UTC) X-FDA: 82657690584.09.4F5B65D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 7ED9E100002 for ; Thu, 10 Oct 2024 12:56:08 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R3mWx5pB; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728564832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UrQTfjCM3j6GClkiT+HP0r9syj9KPAbtwtmQXlpEPSo=; b=0EOvWF9r7zxJx8EblqScdQXvqujJRAkFq+/fTgQ8sA0/DvwO8hQ7pf1GC6ksDFFwVB84hI ZY7lqDcbZdl1/suFC/9rAz8QTFF8iXo9x+i81+ugkNM+vVLXBg5LJYd1symc9VYm3zVW6x TDNruOJgvf32jcnkyiUSxTzcbF2hUFE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728564832; a=rsa-sha256; cv=none; b=EPxHH59zUTNduXWaFNNW0LlMKQUPk1YnM3DF6P4R4dlxX/ve4KQR+jK7JzhZZGGYirK654 1O1CKEAz++pVF/4IoSIF+ixi5Hb+NVjkU8SBPwOhQS0nIduPLpnOPEIMhPoZm7Lp+uXBng aDtRFncZRnfge4AZiM4QGtDqIv2u+MA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R3mWx5pB; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728564969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UrQTfjCM3j6GClkiT+HP0r9syj9KPAbtwtmQXlpEPSo=; b=R3mWx5pBRp6fg4nKEcz0zVnsDW6OwaNPxFpcAdxSQYL1mpulZM9tfN3reUtmOW93lC+xHc mTgefv3WwtY4edO7iFOTDWm+HhnD+gh5bndUAn0EkSsKarvvynhm67CkR1BJL/ZG5oGKYK uIAHLV5POrLfBdTgf33SllJnsSDL5EQ= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-104-C-BaZVZAPfek2n8fSBR0Rg-1; Thu, 10 Oct 2024 08:56:07 -0400 X-MC-Unique: C-BaZVZAPfek2n8fSBR0Rg-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5398b8cb3cdso769758e87.1 for ; Thu, 10 Oct 2024 05:56:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728564966; x=1729169766; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UrQTfjCM3j6GClkiT+HP0r9syj9KPAbtwtmQXlpEPSo=; b=gT0dUs38S8/4nOD14Kb++1jfFID2NaDWRO4OZ1hcb7F33dNVcv3QEcIl3d3UU5bfCo HVQuJgPnS2Jf31GWJVyCBA56TnPofXdsONgHeiycVPHK9dVyLn7W2m26pGVKH9dI2is6 kanmgbiGMZGCrhLXRNNwlNz/c9YhPFCrjdxClPyV8PiJywycPinp0vCsTAa74JrJvdls sMiMX9kU3LJoYipbBeLuvijJUjhkTPuYd/UPBS1hLkbP97qqTCeGefYdyl7+OuB3NMUZ G6YuT7NOuCJr4gOZl7F6erDUk2ohbQ5XS+ly2sKKld91osyQZfQTZl9NUFHMa2EvDn0R Ud5A== X-Forwarded-Encrypted: i=1; AJvYcCUhBqyQ1I/ITrtKG44UOqjp1vZqV1YhmB/Z4N/+7e0v5PJwR+321vL2tUuxa/0jvZLgEBul7A0Hyg==@kvack.org X-Gm-Message-State: AOJu0YwComQGjwKPY3aBbhN9lkCQeilWhWeo1kjoF/QTo/Wjo19EU4oI xYvHCN8jO4CDM3kuLatPuXpQzGQyCt7y85EO1u/K4uvMIV2Knd7mafa4MhmV42VLxFihzGGT0Q7 xxwqrLCXxNcng8l4iLYDW806FJg3IXQ9VVa/CR12OxLTGTHVc X-Received: by 2002:a05:6512:220b:b0:530:ae4a:58d0 with SMTP id 2adb3069b0e04-539c488a817mr3711997e87.8.1728564965733; Thu, 10 Oct 2024 05:56:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyoEFQE0m+JbEAhGlaFjmjSUQcX0/4d8LnIDTxhuaSDXsn6BZ8wHeoBtAFB+ouBeAmKu+GWQ== X-Received: by 2002:a05:6512:220b:b0:530:ae4a:58d0 with SMTP id 2adb3069b0e04-539c488a817mr3711981e87.8.1728564965280; Thu, 10 Oct 2024 05:56:05 -0700 (PDT) Received: from ?IPV6:2003:cb:c742:9200:eb2e:74f9:6f5c:3040? (p200300cbc7429200eb2e74f96f5c3040.dip0.t-ipconnect.de. [2003:cb:c742:9200:eb2e:74f9:6f5c:3040]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b7ef220sm1497801f8f.103.2024.10.10.05.56.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Oct 2024 05:56:04 -0700 (PDT) Message-ID: Date: Thu, 10 Oct 2024 14:56:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm: huge_memory: move file_thp_enabled() into huge_memory.c To: Kefeng Wang , Andrew Morton Cc: Hugh Dickins , Barry Song , Ryan Roberts , Baolin Wang , Matthew Wilcox , linux-mm@kvack.org References: <20241010061024.1846220-1-wangkefeng.wang@huawei.com> <20241010061024.1846220-2-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241010061024.1846220-2-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: nsmwy5tpwsiddqgaw95k3i87h6nm1niz X-Rspamd-Queue-Id: 7ED9E100002 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728564968-544958 X-HE-Meta: U2FsdGVkX1/8aAH1QqiYZTl+xzVKaOTh9WBZRlIMJlDGbVPscEkXA2Jpyfua6blVZxK0jZxbdBIe4dJza55Be3DeT05mplc3UqnL2eKs2NNQaHFvjPZIAMwIORU0Ye6c/19cAbDepiGUZPq/hkmqxz6h2kvLKf7y5k0AF7lg4L00iosBBiuet/oJPwvIT9IV092NaE5Mi31CzJYSfJ/M0/x72+KAZxGpc2lRqrFOS5AFhz+d68mTlDbK2UoEkxZ4yj7psH67ku3iIgNsxnDSxbrWP6AWYeTVWnG/N/wDENq2BSv5oMIRk4sI9hYksOrmLMn9JKn0mZbZ3VGjqrP6dw++6dsPAdIeLznCGb6rRPPldQho9FBRNdvL+oXdeA2HAZom7RwDbtpHLxeXyTGAqcwYU+6s+3SV/29vM56dipYn120cnsXl+2u5BpH7wWO8GWeuwETkpLrGbty+xVD02PeD7w7bKagPyPKK59W/oeRAV3a2FjE1NnVDMhwstZnY3NtnalP6B0eEMu39Wv7Yk/q2l2Ni8IqxHZFNoDzj7d3MHOkMWzBDHLj6EHcz6L0D3ijx99SVL/WpVPMfOrhnQafqrfpqTtJNuQhBc+ItvXVI8drByhdKN1OETXXHBzVJXMs3U8A0BY5neSAeRxFKzH+DWVRYZxWK1TaQX33eK3qWzbFiDNEdwydqeLOhvo9uJHPyPBo28vwHoZT5U4DNGTtvSFoVGvlTN84dV37WL6feDFsdEVM2I97hd9bMfCC5SIHZCSqEWIh8LLMyPwdlI1P/I1RLQKdhhAqm0X8W5JIMzPEcfXvHd3P7kJByaNtIwWCDuZ2xJc6y0WmnSJf5sf3VzBvDa1XY1nyws1UiWjqzRZq6UiNP3bqGgfjjv2GsImGxNfX7D+7vN4FOM+VQniizRorWbSr8JZiHaKgWJg6pEEuXsxUxWayd6NPifX9FcK7OhZo3gUcPAX/KAt3 a0ExkZWL 0Zpldm1rTIfV5mEuNm4ivT6aUJxReB/ddyNkVxlGjd1QsuOZieBqNIBKoQcLugatAMDvqaJBnsAdIGy2hogquVYLEBgtauzArBuvjrMZGnEChMnXIcTU7bQ7/59pr9L/9RV0mq4QibAuqE+957cetByV05xihCSqhJCnTLoVpIOv+jeBA3XPcx+uNRKfyXIYnFORyutdZQ3yIUt7Qvg/uxu9IE0m0w2S+rNvlgnNxnWsY30heKNN3PCs3ZOf+22Lcbcxe2WgZlQdikow035uBQQcKFmdWTdg7Q5JQLl98f/7m5BWI29eKSo5cEQAaB9KpVVL4OX6H9jPhs9z1Cc+TJfeVtrEE/hSNyZJ5k0bqVHKvkRIVJ4RKOT6LaaNn7sK/FdBaWYI94ft55CilklzmQ5z6NQ9N/cFOVLoiSggfzRCq0lIxunr5oktOL/sV0P0+nA9QziXjqrted5Ejbx8U4+tFONt8PtXnuC7cfYwcBagcStY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.10.24 08:10, Kefeng Wang wrote: > The file_thp_enabled() only used in __thp_vma_allowable_orders(), > so move it into huge_memory.c, also check READ_ONLY_THP_FOR_FS > ahead to avoid unnecessary code if config disabled. I would hope the compiler is smart enough. But this way is clearer Acked-by: David Hildenbrand -- Cheers, David / dhildenb