From: David Hildenbrand <david@redhat.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Hugh Dickins <hughd@google.com>, Barry Song <baohua@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm: huge_memory: move file_thp_enabled() into huge_memory.c
Date: Thu, 10 Oct 2024 14:56:04 +0200 [thread overview]
Message-ID: <b652554b-07ee-4846-a97a-29970ebbe853@redhat.com> (raw)
In-Reply-To: <20241010061024.1846220-2-wangkefeng.wang@huawei.com>
On 10.10.24 08:10, Kefeng Wang wrote:
> The file_thp_enabled() only used in __thp_vma_allowable_orders(),
> so move it into huge_memory.c, also check READ_ONLY_THP_FOR_FS
> ahead to avoid unnecessary code if config disabled.
I would hope the compiler is smart enough. But this way is clearer
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-10-10 12:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 6:10 [PATCH 0/3] mm: cleanup thp and shmem allowable order check Kefeng Wang
2024-10-10 6:10 ` [PATCH 1/3] mm: huge_memory: move file_thp_enabled() into huge_memory.c Kefeng Wang
2024-10-10 12:56 ` David Hildenbrand [this message]
2024-10-12 3:27 ` Baolin Wang
2024-10-10 6:10 ` [PATCH 2/3] mm: huge_memory: add thp_vma_disabled() Kefeng Wang
2024-10-10 12:58 ` David Hildenbrand
2024-10-10 14:41 ` David Hildenbrand
2024-10-10 14:53 ` David Hildenbrand
2024-10-11 0:40 ` Kefeng Wang
2024-10-11 10:00 ` David Hildenbrand
2024-10-10 6:10 ` [PATCH 3/3] mm: shmem: remove __shmem_huge_global_enabled() Kefeng Wang
2024-10-12 3:38 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b652554b-07ee-4846-a97a-29970ebbe853@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox