From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 275CCC02181 for ; Sun, 26 Jan 2025 07:19:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AECD2800A6; Sun, 26 Jan 2025 02:19:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 75FFF6B0206; Sun, 26 Jan 2025 02:19:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 626C02800A6; Sun, 26 Jan 2025 02:19:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 435A26B0205 for ; Sun, 26 Jan 2025 02:19:03 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E0AED16074A for ; Sun, 26 Jan 2025 07:19:02 +0000 (UTC) X-FDA: 83048751324.19.DBF8849 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf17.hostedemail.com (Postfix) with ESMTP id 5E47640004 for ; Sun, 26 Jan 2025 07:18:59 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of gongruiqi1@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=gongruiqi1@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737875941; a=rsa-sha256; cv=none; b=XQR3twAHzCRsZTG8lTcBL+zaNlzOUMceRbE0F6RLVzJ/bNms9UZ373aLIN5E5ng58bcOU0 5PPd9O/lXyeJeF5JbVaPJ1P3aGljpJD+bVvvULFNDpuMIi74BFS0ENat3lj8QXizlHir/L orqUn2xBz/BnXs06F5H287pH0oBijEQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of gongruiqi1@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=gongruiqi1@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737875941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iAMzX7EnnZH9TbR5ndthLogYug/aJOgkA1HwzuawXVc=; b=Ne6O1+Mr8Rs4kFm9Im0BAfwkVtYQZToohZU3484Y172oqwrvmHXFaMzIg+xRhHPrygkd4J lqjgFi8G3Y9GsjZaOCdPkamzoyP42vKHiYr+AVpIttuku3tHz6EtVgss8YeY/3p/0KgZ/0 2GWoWfnu7hUweq5H4yG7rkE5PIB0m5o= Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4YgjVB65B5z1l090; Sun, 26 Jan 2025 15:14:42 +0800 (CST) Received: from kwepemg100016.china.huawei.com (unknown [7.202.181.57]) by mail.maildlp.com (Postfix) with ESMTPS id C0F78180042; Sun, 26 Jan 2025 15:18:06 +0800 (CST) Received: from [10.67.110.48] (10.67.110.48) by kwepemg100016.china.huawei.com (7.202.181.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sun, 26 Jan 2025 15:18:05 +0800 Message-ID: Date: Sun, 26 Jan 2025 15:17:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/slab: Achieve better kmalloc caches randomization in kvmalloc To: Vlastimil Babka , "Christoph Lameter (Ampere)" CC: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Kees Cook , Tamas Koczka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Xiu Jianfeng , , , , "Uladzislau Rezki (Sony)" References: <20250122074817.991060-1-gongruiqi1@huawei.com> <62044279-0c56-4185-97f7-7afac65ff449@suse.cz> Content-Language: en-US From: GONG Ruiqi In-Reply-To: <62044279-0c56-4185-97f7-7afac65ff449@suse.cz> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.110.48] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemg100016.china.huawei.com (7.202.181.57) X-Rspam-User: X-Rspamd-Queue-Id: 5E47640004 X-Rspamd-Server: rspam10 X-Stat-Signature: cfa8cm4i8inr4qj6cf9efydmf1pjroue X-HE-Tag: 1737875939-516261 X-HE-Meta: U2FsdGVkX19HNZzFenSQU4IB+b2FV+gkXYtb69T6X3MW8UW+0ASmFrq9EaFLd6FV0Hb+rjyxbnJ0f1kt1dza76WyYip9hAlrB4qOCXofUiQh/6pCBFLV6NGuLSVztdoop69Pun2YcIEdLnBGGpKhuphn1dtoEgKbmIvJIdQqRoBAoKSqaAPmSigjckoz8nIFa69Zz2gR3Jx1G6GRaBuDiYqlemI0/PsDSrbmhhf0iZCb1Xl3KabwXswTgOIT41PlRkQu0Uh7lFTR86wvC6AFb7XJe17UFuXfdok3WpN2tUsBNS9dtvD0qxhI/G3xhj2DdgcMJkWiuycJyl6u2NhVCdYStJf9vYp6tyTWH0KTwD7fATVjhP3QwVGhm8hCOj63ChqbRpGPxSt6gQ1Tk59sffL2X76JAckMkmSOqY1wt4MW8chNNuBw49WXNuc+bD6gcbpAkrEIh4fR/WXkUFyCS2e6RlGgJ16KQAtDKrkktRoVHxZN/xh9pag7ALDovrr/tFhcWG6fuWvo77M+CvCuAjBca0qssqNfEUQfKEV4n/5kDybecH78m/hStxVdWVIXjJ78g/KvDfhv8YpK/bGDgbcL6/sv66qcuxuPKKFKyDjiUP80JySZG7sKFGFJ8UQSFJYOerCd98dwY+SX9O4I4HBpzzFOTYF1pmRbKMwZ9hHYbEir+zakxL7YZX+9HYoG1FxLoO4WqFC+A5v5IkXChr1hSI2HGsFk2ON8tpg7ATuIJPMv3DvwPeoJPkROhqPxW5Pi7vSaNMPJr9/P/37Z6+1a9Ojde4VdvEvZaQ4KnxhSNODpSgB82b9KYUWl78/kAGtc1fIe+enSY9oJY9VWeZmcipQKjNqFoq633snhHCRbZkal+9dRll0vDGrq7dQPbyY+mB45sPKir8g50zm33ApLa895gUcsmVpnH+VoDf7AD38S3dwRyFQqQswxoT4QUbScRahxHUKlOq8P21Z WQcvwPmc owfKskiPodbPKgPjm4w3gFGHhE24Ttfhzn3yqXWMD1yzIZ6pxTffR1Pql1mz56nRMh8Q93tipKcPRzDAgAFEUDA2cCK2veNIZ6+TMpQwkUtl17fwdoEn85B2M/e1dW6TxrnNsLupdwoJKiyUOgNpBSU4O/hMdtpO0kC0tLzlfI6WUCW1f3a9KZXhTg3hulYfFsowZixZjheqL6U7dzkDAu6i7lB/wFCGxEIh0lr8jVo33ejHPKeTlGOqSog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/01/24 23:19, Vlastimil Babka wrote: > On 1/22/25 17:02, Christoph Lameter (Ampere) wrote: >> On Wed, 22 Jan 2025, GONG Ruiqi wrote: >> >>> >>> +void *__kmalloc_node_inline(size_t size, kmem_buckets *b, gfp_t flags, >>> + int node, unsigned long caller); >>> + >> >> >> Huh? Is this inline? Where is the body of the function? >> >>> diff --git a/mm/slub.c b/mm/slub.c >>> index c2151c9fee22..ec75070345c6 100644 >>> --- a/mm/slub.c >>> +++ b/mm/slub.c >>> @@ -4319,6 +4319,13 @@ void *__kmalloc_node_track_caller_noprof(DECL_BUCKET_PARAMS(size, b), gfp_t flag >>> } >>> EXPORT_SYMBOL(__kmalloc_node_track_caller_noprof); >>> >>> +__always_inline void *__kmalloc_node_inline(size_t size, kmem_buckets *b, >>> + gfp_t flags, int node, >>> + unsigned long caller) >>> +{ >>> + return __do_kmalloc_node(size, b, flags, node, caller); >>> +} >>> + >> >> inline functions need to be defined in the header file AFAICT. > > Yeah, this could possibly inline only with LTO (dunno if it does). But the > real difference is passing __kvmalloc_node_noprof()'s _RET_IP_ as caller. > > Maybe instead of this new wrapper we could just move > __kvmalloc_node_noprof() to slub.c and access __do_kmalloc_node() directly. > For consistency also kvfree() and whatever necessary dependencies. The > placement in util.c is kinda weird anyway and IIRC we already moved > krealloc() due to needing deeper involvement with slab internals. The > vmalloc part of kvmalloc/kvfree is kinda a self-contained fallback that can > be just called from slub.c as well as from util.c. Thanks for the advice! I will send a V2 based on moving __kvmalloc_node_noprof() and kvfree() to slub.c as soon as possible. BR, Ruiqi