From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEFE7C433E0 for ; Fri, 12 Jun 2020 03:09:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 69E5B20823 for ; Fri, 12 Jun 2020 03:09:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69E5B20823 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CA90B8D00AE; Thu, 11 Jun 2020 23:09:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C594A8D00A0; Thu, 11 Jun 2020 23:09:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B70D58D00AE; Thu, 11 Jun 2020 23:09:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 9F8578D00A0 for ; Thu, 11 Jun 2020 23:09:42 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 683A31EFF for ; Fri, 12 Jun 2020 03:09:42 +0000 (UTC) X-FDA: 76919079804.06.lamp75_0a12c8126dd9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 4C0491003E0CD for ; Fri, 12 Jun 2020 03:09:42 +0000 (UTC) X-HE-Tag: lamp75_0a12c8126dd9 X-Filterd-Recvd-Size: 2182 Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Fri, 12 Jun 2020 03:09:41 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01358;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0U.K13Qc_1591931375; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U.K13Qc_1591931375) by smtp.aliyun-inc.com(127.0.0.1); Fri, 12 Jun 2020 11:09:35 +0800 Subject: Re: [PATCH v12 00/16] per memcg lru lock To: Hugh Dickins Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com References: <1591856209-166869-1-git-send-email-alex.shi@linux.alibaba.com> From: Alex Shi Message-ID: Date: Fri, 12 Jun 2020 11:09:33 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk X-Rspamd-Queue-Id: 4C0491003E0CD X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000018, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =D4=DA 2020/6/12 =C9=CF=CE=E76:26, Hugh Dickins =D0=B4=B5=C0: >> ..." > It was well worth exploring, and may help in a few cases; > Johannes's memcg swap simplifications have helped a lot more; > but crashes under rotate_reclaimable_page() show that this series > still does not give enough protection from mem_cgroup_move_account(). >=20 > I'll send a couple of fixes to compaction bugs in reply to this: > with those in, compaction appears to be solid. >=20 Thanks a lot for fixing. I will look into them and try to merge into the patchset. Thanks a lot! Alex