From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AFC9C433EF for ; Thu, 16 Jun 2022 19:53:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C38BF6B0073; Thu, 16 Jun 2022 15:53:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC10C6B0074; Thu, 16 Jun 2022 15:53:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A11F36B0075; Thu, 16 Jun 2022 15:53:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 927696B0073 for ; Thu, 16 Jun 2022 15:53:28 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 6DA0B80520 for ; Thu, 16 Jun 2022 19:53:28 +0000 (UTC) X-FDA: 79585148496.31.37F5EC7 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by imf20.hostedemail.com (Postfix) with ESMTP id E4F661C008C for ; Thu, 16 Jun 2022 19:53:27 +0000 (UTC) Received: by mail-oi1-f181.google.com with SMTP id q11so3054932oih.10 for ; Thu, 16 Jun 2022 12:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=EfwlzFckWlUMOMsTP0CL3PI+ky24pigsEudIsOwrRdI=; b=XoPuikzI8T2Enhg9yfnoUEsHSfpocokh8nllyr1EvKnLHKHH4KdJvmE92GdcBXQTqL SIqH+LyXNQuPeYMKv2+GgRBjzAY/Wo2nXdujrfOBqa18SykwVVb8o7J2SD1N1Zyulv6U U7cG9kZdpphOzt4EmU15Cpd2aKe9vUoP7oJTw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EfwlzFckWlUMOMsTP0CL3PI+ky24pigsEudIsOwrRdI=; b=AX1+AFreVRGMHdy6JMFRqfzoITwcMjQNcuGyY+NMk96cq7O577zOCQ6la0sduuYO1Y +xSe7bB3RaBrpS3BI5Ui8comXEpgHp/Vomcyyg5x6I5AFsOH1b0Btle3PQP0TX1PfzRx LLhU6AViQTqf+J5mANZpXAs8wlvVOA31tPovRX8h7XZT2s21swyy15c4DNCltvd/pE5R l5d4k1/Bcx/Tun1zH9wlSFRljl29qjfEl4P6iCM3QhseCBNOpORV/2N+OxgKbNoHXAYj fbDPVmDjxlO9+bxVqml+OKkdoUzQQavTM8bziYjngW5D13NtMBhBA1LkaOQ2jM42WTz8 OIeA== X-Gm-Message-State: AOAM531MoAnWaX7b4F1pnWRbPtyGdPfz0KDjqbWN4QNsBWNt6vCINGKs m028IW7SIG80G3aB0Ngq3bkY8Q== X-Google-Smtp-Source: ABdhPJwweF1/2fqbcaZAz1sg2n/7BwBVsvtY3F6NXRJHPRCtaFg6+jab8NKhG/y5uP1KYQQ0ZVdO0w== X-Received: by 2002:a05:6808:2003:b0:32e:f319:456f with SMTP id q3-20020a056808200300b0032ef319456fmr8647466oiw.226.1655409207075; Thu, 16 Jun 2022 12:53:27 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id z4-20020a056870738400b000f317901b29sm1374116oam.4.2022.06.16.12.53.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jun 2022 12:53:26 -0700 (PDT) Subject: Re: [PATCH V2] selftests/vm: Add protection_keys tests to run_vmtests To: "Shetty, Kalpana" , akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220610090704.296-1-kalpana.shetty@amd.com> <8e7fca3a-096c-7d6c-e43b-9292995ab970@linuxfoundation.org> <2f157493-02ed-4bc8-6624-b7d077c0d5af@linuxfoundation.org> <442c7cb4-7ec5-bf34-b9d6-ce9480b4b491@amd.com> From: Shuah Khan Message-ID: Date: Thu, 16 Jun 2022 13:53:24 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <442c7cb4-7ec5-bf34-b9d6-ce9480b4b491@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655409208; a=rsa-sha256; cv=none; b=YCIyej6xENB8Ecp73Bv+WzgPfBg0jh+eOL7JDJyM14L8C1A89SwXBg5ZUdF39rFCAnGX4R YN2dxz3t93rHK0gLBjvssMCbF8MODneeN+UFWxrL6Q2XFG3IrzW8mKymmAOo6GfkKHQn2u ZZKAQoks1ec/RBhHc3KpE52IahiNmoc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655409208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EfwlzFckWlUMOMsTP0CL3PI+ky24pigsEudIsOwrRdI=; b=Kmcy0KPLKo29xoLfRMxWnGINm3DkOS0HlahyFdShaqIO2Zi2D+c8uAtFV+r6zee+B0Mz3F znKoSAwaLt0KINn/XcfSp+BOfhnr9Uvu4uMlyj97g0y1s/fyImZKelscXz6uZzX/mVvZ7a F/Dhrd3GIUkrfeF23FHbK3ej/YvPwH0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=XoPuikzI; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf20.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.167.181 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=XoPuikzI; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf20.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.167.181 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E4F661C008C X-Stat-Signature: zmhujzdqmsnhmaqq4d6x7oyix1at1zj6 X-HE-Tag: 1655409207-688329 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/15/22 6:04 AM, Shetty, Kalpana wrote: > > On 6/14/2022 10:50 PM, Shuah Khan wrote: >> On 6/14/22 6:15 AM, Shetty, Kalpana wrote: >>> >>> On 6/14/2022 3:14 AM, Shuah Khan wrote: >>>> On 6/10/22 3:07 AM, Kalpana Shetty wrote: >>>>> Adding "protected_keys" tests to "run_vmtests.sh" would help out to run all VM related tests >>>>> from a single shell script. >>>>> >>>> >>>> Makes sense - can you explain why you can't just run >>>> protection_keys_32 without checks? >>> >>> Yes; we can run protection_keys_32 without check. >>> >>> >>>> Why are you checking for VADDR64? >>> >>> The check is added to ensure if the system is in 64-bit mode before executing 64-bit binary. >>> >>> >> >> Okay. protection_keys_32 will only be built on 32-bit system and. >> protection_keys_64 on 64-bit system. > > On 64-bit system, we get both 32-bit and 64-bit binary. > > >> >> Won't it be better to check if binary exists and run either _32 or >> _64 instead of checking for VADDR64? > > makes sense; > > In this case on 64-bit platform we would run both _32 and _64 and this should be fine. > > Okay - send v3 with the change. thanks, -- Shuah