From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12BE7EB64DD for ; Wed, 5 Jul 2023 01:17:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A8FB6B0071; Tue, 4 Jul 2023 21:17:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2592A6B0072; Tue, 4 Jul 2023 21:17:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1214B8D0001; Tue, 4 Jul 2023 21:17:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F1A676B0071 for ; Tue, 4 Jul 2023 21:17:52 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B1AF8AF955 for ; Wed, 5 Jul 2023 01:17:52 +0000 (UTC) X-FDA: 80975796384.04.81312BD Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf11.hostedemail.com (Postfix) with ESMTP id 5C86F40005 for ; Wed, 5 Jul 2023 01:17:46 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688519871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tn3DbcEYLwF21GWyA3uzft2QHOVr9qLGZ/aAy+PKFyo=; b=O+M88PkACXlWtUF+d/l+NKlq0nWU2hlwSteon57T9rgQpPINbq5AO0GN75GAnV50ybj0Nv Nebbrzjgtvq2EUd6HCm4r8XNm9yZgtTdUCEBHQPni3STF3heQTYqgqUAobeT44zK5U9Y5P URiF1p5cm6fo7Z+yB5tmHBtuA2zhOyA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688519871; a=rsa-sha256; cv=none; b=cDdtx6Isxh3okYSj4mczod5mxjeCd2aYVb+GPw/ZTHblyDlleMYNQdEJlmQmnucC4dyQGG q9tLK7wdzDnbipUJ6gGnx36MABlD5H8jUj5r4CMC5tuFFvAEnvGqqrM3bU9ToZlhUv4Jbj h95h1M3POMp1n8roVVFt2rIQwECeI18= Received: from dggpemm500009.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QwhZd1cZZzTm3l; Wed, 5 Jul 2023 09:16:41 +0800 (CST) Received: from [10.174.179.24] (10.174.179.24) by dggpemm500009.china.huawei.com (7.185.36.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 5 Jul 2023 09:17:42 +0800 Subject: Re: [PATCH] bootmem: remove the vmemmap pages from kmemleak in free_bootmem_page To: Andrew Morton References: <20230704101942.2819426-1-liushixin2@huawei.com> <20230704092841.2e71a21ee1149ec662c73744@linux-foundation.org> CC: Muchun Song , Matthew Wilcox , Mike Kravetz , Oscar Salvador , , From: Liu Shixin Message-ID: Date: Wed, 5 Jul 2023 09:17:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20230704092841.2e71a21ee1149ec662c73744@linux-foundation.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500009.china.huawei.com (7.185.36.225) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 5C86F40005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: myjiy1myqo83osyabarsbjf67pzp9ris X-HE-Tag: 1688519866-37349 X-HE-Meta: U2FsdGVkX1+mTEnIauItZcpVu6eU/UlOWAhLGjQ7VNPJrQ8c50FJtZ4t8+h19ILH91EJa9aYmkybm8pE+0wjG0SBX/pfPIyp8HJfG/MF4CSJBSjmIVf8DXa7/lPDxva+Lc2XRRk5n5j+cF5V+wBSdHE2xuxGs32nLplARKI29lEXktHDmU1RpZpIA+ZvN5iRwksU89HO/LSYvYANodFyS5LwN47f2x+8qWtR7TC5dcnZExoIhy+Emc/iJ7U9n1j2SVst8NB2gFsRDvr/Ic7ZpbB2aQcoPgY1xYGKhf6PeTYMNRXrnHb/qyNBkzJ0kTLrs+mvr/oj+iFMO7RLGc+dfK+DI+rHX3ml+n8B/JEq5sI12Cbs9h3ydMjBVzcglSHHwLtNexgG62f2bwQPRsT5D6w2EUBpKsjfym7I0ao2rqBFDUGqlfa1+6gZudtob0jzkMcKnULmvrIRtqnRIbcUOIYVyLmWgwefWmBoZLxVczTqva0Vqb1Zmi8M4gW/dJV7EAoyr1UefOQtZ6sqRpfSls19QiRaKTsz6IXcl4vSe9aFS21Vy3Jj8/kvzNAnNl7wUlOe4UZwUSeErAp5TbS/vj3xTV7Z3lw+zrKLyUTiObIRPXrM2iJrmCGaDfOJE5UmCvIqr32/sQKJn0XRC9aitHiD3yDzxqbg6bfKjdXB7DdwJj2nFYos3cAIooy0nx9ELDYVsZs6a6ZQ2y7U240BgSxrv72oDN3dJ1bSJMhUmgl+tPvtGf5DBS247/sHtMs/cI77Hin2Ltb3V8ytEA7+Zx6ORy/OFmSBbsup/pQGyAIflP+EbCcZNCbmPsQvbfiz592otyg8737Hu2QKGj8M8j8nHixNE1TZw3tBC/XuwSafwq9xRClVA94Ps+kbRb8k1RA2zDhhrjhg5I+CmutNbNeSCSewvWktCK/su9CCsTw92Or2QkdxYQsFTYxExMyzXCWqEjKzqGnUvaUOFE6 HV4KKnpD G1jZpXJqauEtdgiR0NjHJwMQ4jOVsU8gonVjKvZOGJT5XuZBbYihd336SNRXcaZmoRykBmhv/3rRsU54RVxHQh7VMeQYma/95fHf19GUIcoP5LfBReTMjUw9DYZsU0BYWWvhvCtUC9ZNrE032auXw8r+1NAY+Ql4YvsmE3eJQ6zTSbz3Grj1pNWyzgcPa6pxCBCyMa/gcbOMzhbU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/5 0:28, Andrew Morton wrote: > On Tue, 4 Jul 2023 18:19:42 +0800 Liu Shixin wrote: > >> commit dd0ff4d12dd2 ("bootmem: remove the vmemmap pages from kmemleak in >> put_page_bootmem") fix an overlaps existing problem of kmemleak. But the >> problem still existed when HAVE_BOOTMEM_INFO_NODE is disabled, because in >> this case, free_bootmem_page() will call free_reserved_page() directly. > So I take it that with CONFIG_HAVE_BOOTMEM_INFO_NODE=n, the issue > described in dd0ff4d12dd2 still occurs? That kmemleak reports an error > and stops working? Yes, you're right. > > So we want a cc:stable on this fix, yes? Yes. > >> Fix the problem by adding kmemleak_free_part() in free_bootmem_page() >> when HAVE_BOOTMEM_INFO_NODE is disabled. >> >> Fixes: f41f2ed43ca5 ("mm: hugetlb: free the vmemmap pages associated with each HugeTLB page") >> ... > . >