From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95582CD4857 for ; Wed, 4 Sep 2024 15:41:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB0248D025C; Wed, 4 Sep 2024 11:41:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C35726B0447; Wed, 4 Sep 2024 11:41:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A40288D025C; Wed, 4 Sep 2024 11:41:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 651EB6B0445 for ; Wed, 4 Sep 2024 11:41:03 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F28301210CB for ; Wed, 4 Sep 2024 15:41:02 +0000 (UTC) X-FDA: 82527469164.14.D8486D9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf21.hostedemail.com (Postfix) with ESMTP id 9C6E81C001D for ; Wed, 4 Sep 2024 15:41:00 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xEEAkkFa; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gQZgk6Ry; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xEEAkkFa; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gQZgk6Ry; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725464364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UGnCm+5KpvBBOcZ7VQpXPQJk0GjrSJiZzzkHGzbvUYg=; b=zm0WoptpNhe+mUhOwr59ytCD0eO+nuzMQsT0Mn9b7gTaI2KzrIrEGOqW4NKZDotQCT3VzO hO6YDDpPVfXKwDnwGmYM+Owi/ZlVgX5CoKCl2mmIvxKIPCjLRsKrLyrxdDZsJ4xQy87z1y fHUwWf8PqF9ls0gA2vYdENHaHWoa20M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725464364; a=rsa-sha256; cv=none; b=jih68i+25k0uq9OshUXc1dKOTjdANSlC7t60wdCOn9WCmshfJWfNuSjsDf95pPdVyNexwT O7DN20JIWjmKqdM5XoIQ7Gf6KMuQChEAE3BBjC+qmIgLo1HW39Eo6KaaJFSf2c1XjKDamW 0fx7yrG801MErPwTGYK7CvOKoxG8HVY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xEEAkkFa; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gQZgk6Ry; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xEEAkkFa; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gQZgk6Ry; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AF8411F7C9; Wed, 4 Sep 2024 15:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725464458; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UGnCm+5KpvBBOcZ7VQpXPQJk0GjrSJiZzzkHGzbvUYg=; b=xEEAkkFa4gJM4sPzgF5n6HTFy2xFabnvCN4/wYMxFnIqzhArPqQSfecHlpf4I2/ZhcMz1I S475ShaLq2KNdv18dDiD9a3XRp5nUkNH5mQwje3vrYrvZeSTJzloU1ZjfJW24Li+MPKU9D vwp2IG4VuP1xoXTlD3PGjEgXHJ4WV5s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725464458; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UGnCm+5KpvBBOcZ7VQpXPQJk0GjrSJiZzzkHGzbvUYg=; b=gQZgk6RyZoW1q7Z2rj2ixZ4cYcftcMQyigfZh5JtBJREgfaQMs40jBEbhLvoW5qQ0TisJo mGBNLf4pkxwChYBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725464458; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UGnCm+5KpvBBOcZ7VQpXPQJk0GjrSJiZzzkHGzbvUYg=; b=xEEAkkFa4gJM4sPzgF5n6HTFy2xFabnvCN4/wYMxFnIqzhArPqQSfecHlpf4I2/ZhcMz1I S475ShaLq2KNdv18dDiD9a3XRp5nUkNH5mQwje3vrYrvZeSTJzloU1ZjfJW24Li+MPKU9D vwp2IG4VuP1xoXTlD3PGjEgXHJ4WV5s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725464458; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UGnCm+5KpvBBOcZ7VQpXPQJk0GjrSJiZzzkHGzbvUYg=; b=gQZgk6RyZoW1q7Z2rj2ixZ4cYcftcMQyigfZh5JtBJREgfaQMs40jBEbhLvoW5qQ0TisJo mGBNLf4pkxwChYBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 97A14139E2; Wed, 4 Sep 2024 15:40:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id T21hJIp/2GaVDgAAD6G6ig (envelope-from ); Wed, 04 Sep 2024 15:40:58 +0000 Message-ID: Date: Wed, 4 Sep 2024 17:40:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 12/15] slab: create kmem_cache_create() compatibility layer Content-Language: en-US To: Mike Rapoport , Christian Brauner Cc: Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-12-76f97e9a4560@kernel.org> <20240904-storch-worin-32db25e60f32@brauner> <23eb55c3-0a8c-404b-b787-9f21c2739c4e@suse.cz> <20240904-absuchen-gockel-8246820867b4@brauner> <24717bab-7d5d-4ed1-a17d-65d4676e22a9@suse.cz> <20240904-gegessen-kalziumreich-2817b07433b7@brauner> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: ajheoiqmdkmf8qubzajoxiqei8j6zydd X-Rspamd-Queue-Id: 9C6E81C001D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725464460-275963 X-HE-Meta: U2FsdGVkX1+dxuSr7s/k2dWfwxVswVAvKIj61D6cVnUhQ9IBfjJMiDl8SqqNVCexVy1Rsmr2mwcoJLKfKmiUrhhbQipTGoZQEYjpFEuJYhhQFjhuVJ6yggwK/QxjTSvi6fiqMG2HT3il/T0XDKI00f3bsuYTM57dqe/AXzK7S+yz1GNG9aZpPlkS9yA+YRqgt7yH6ynUhgi33NKlIwxIQSg4iRHT1//O1qrJMr2GJx4/MhJ/LtVy2b/ZKqpkmEIHqp6n36V0KXl4WZzs7RjEgX+rnH1ov/Ov5djl6ODXhiebZsm/5BtYNcn9iwRRnVaP2LxXHU14tvGb5jNVpTF5HBHJS9Qe4glFdXjfjraK6xcYf2ILWmAPQGD9wkviH++I27DfnReQnQubaEdYGBBKKY+mNrfTH6YI+ZNfy9silX6CouRoQ4sDinPCtuUlxaDSjTuEv2TJdsI3OyldadakONkRstvL03RyPVBOOHL0YfJ9WpQvnqZauiOZnAfoENj/hz4FrmQniHO8CmBdXY+NiNgfqBg8tPKDPeOFwb6IM1+QyixwgzMp/oQ90x8G7YOIVhIP5AdYf4Rh9YsSLurfgDViiqfYtJsIUG2/WbV+rAsbb3MnQ5BNadwacGkTXVMYgkqelk82bWs//CZUsw1u9n9p58+KQoF39GrXEAd49w0M1D9EplQWYhpFU1vmYW42ZOZI8GM2n8X9PsXgot72QasfvSwOeISecU0nbHOmwA+/dRt2qVlqciPM8a/jliZ4vkqI0aD2cctya+ERPZji5DOWCNKgHFUFSzPq97ETnPNMbN1qsy/+bgaEYC4HSWmrodInYk0fB9HDD3A/bQsxpbiw9IwjKxcOHByngHKXvsxp2oAlcbgZkCZOtMYxPgeOxjtqpgRe03Xd1i8Y3fBJfN3WwqSsMf9DhI2xRmlUpEgmBOBeIlWYwVNDDFdi7onGRgcHWrLuNf7zFkpswXd CKMCT5Gg cOa3X8VHWDD8TPBCjQyT5FbKZojr4v7PmnE/zlA+gLqT8wS0YOAgoE+25tWoayO82wsL0SGEZPWdmJKc5FB/6nT0oRoIoEskj2RsyOS8syh9X0SAEj4/taa0MUFyvYmikx9pSsoDJ0A1OwKHtLiu17K5lbcSFTmzabWL+D/I/ewW3USiG2YvoVqM95Jt6A09gKINCbCbELiFEiUiDAqWil+d6Rmu1L5Q9mBv/mXSxO8wQd12+a3l4OvtdSrbNC1AsCaWSZES+Zmu1hvbs+hrNjjqv7Jf5Ey9E+Qwq5mup2LehudzzvPka2yC43uMvsE++IdPsBPKJqaJ9QVQ4CycTggZkKLiwe0Vb23GF4bXOHoNlE6Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/4/24 17:11, Mike Rapoport wrote: >> >> Oh, I see. I read it as a expressing taste and so I didn't bother >> replying. And I really dislike single underscore function names so I >> would like to avoid it and it also seems more confusing to me. > > Heh, not quite. I don't like kmem_cache_create_args essentially becoming a > replacement for kmem_cache_create* and I'd prefer __kmem_cache_create > naming. It's __kmem_cache_create_args(). If it didn't have the underscores, I'd agree it might be misleading into being used directly. But like this it doesn't bother me much. > As for the single underscore, I don't have strong feelings about it, but I > do think that it should be renamed to something else than > __kmem_cache_create to leave __kmem_cache_create for the core function.