From: Xin Hao <xhao@linux.alibaba.com>
To: SeongJae Park <sj@kernel.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 2/2] mm/damon: Modify the display form of damon tracepoint
Date: Fri, 10 Dec 2021 11:36:23 +0800 [thread overview]
Message-ID: <b6142e6f-266d-1dec-a3b6-83e622280462@linux.alibaba.com> (raw)
In-Reply-To: <20211209164611.32858-1-sj@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 4038 bytes --]
Hi SeongJae：
On 12/10/21 12:46 AM, SeongJae Park wrote:
> On Fri, 10 Dec 2021 00:33:17 +0800 Xin Hao <xhao@linux.alibaba.com> wrote:
>
>> When I use the perf command to record damon monitor data, like below.
>> # perf record -e damon:damon_aggregated
>> # perf script
>> ...target_id=18446462667479739520 nr_regions=13 281472805928960-281472942936064...
>> ...target_id=18446462667479739520 nr_regions=13 281472942936064-281473080008704...
>> ...target_id=18446462667479739520 nr_regions=13 281473080008704-281473216634880...
>>
>> From a user's point of view, the 'target_id' and 'damon_region' which displays in decimal
>> are not very friendly, So there do some changes, keep the 'target_id' display consistent
>> with 'dbgfs/target_ids' interface and 'damon_region' is displayed in hexadecimal, just like
>> below.
>> # perf record -e damon:damon_aggregated
>> # perf script
>> ...target_id=5522 nr_regions=14 ffff716a3000-ffff79893000...
>> ...target_id=5522 nr_regions=14 ffff79893000-ffff819dc000...
>> ...target_id=5522 nr_regions=14 ffff819dc000-ffff89bd9000...
>>
>> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
>> ---
>> include/trace/events/damon.h | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h
>> index 99ffa601e351..67de51814f4c 100644
>> --- a/include/trace/events/damon.h
>> +++ b/include/trace/events/damon.h
>> @@ -17,7 +17,7 @@ TRACE_EVENT(damon_aggregated,
>> TP_ARGS(t, r, nr_regions),
>>
>> TP_STRUCT__entry(
>> - __field(unsigned long, target_id)
>> + __field(int, target_id)
>> __field(unsigned int, nr_regions)
>> __field(unsigned long, start)
>> __field(unsigned long, end)
>> @@ -26,7 +26,7 @@ TRACE_EVENT(damon_aggregated,
>> ),
>>
>> TP_fast_assign(
>> - __entry->target_id = t->id;
>> + __entry->target_id = (int)pid_vnr((struct pid *)t->id);
> I think this would break physical address space monitoring. Have you tested
> this change for that?
Yes, you are right, But I encountered some problems while testing
physical address, it seems that my operation did not work
I did some test like this:
# echo "42 0x0000000840000000 0x000000103fffffff" > init_regions
# echo paddr > target_ids
# echo on > monitor_on
i get the physical address from my kernel startup log.
15 [ 0.000000] Early memory node ranges
16 [ 0.000000] node 0: [mem 0x0000000040000000-0x000000083bc7ffff]
17 [ 0.000000] node 0: [mem 0x000000083bc80000-0x000000083bffffff]
18 [ 0.000000] node 0: [mem 0x000000083c000000-0x000000083c03ffff]
19 [ 0.000000] node 0: [mem 0x000000083c040000-0x000000083c0fffff]
20 [ 0.000000] node 0: [mem 0x000000083c100000-0x000000083f3dffff]
21 [ 0.000000] node 0: [mem 0x000000083f3e0000-0x000000083f46ffff]
22 [ 0.000000] node 0: [mem 0x000000083f470000-0x000000083f47ffff]
23 [ 0.000000] node 0: [mem 0x000000083f480000-0x000000083f59ffff]
24 [ 0.000000] node 0: [mem 0x000000083f5a0000-0x000000083fffffff]
25 [ 0.000000] node 1: [mem 0x0000000840000000-0x000000103fffffff]
26 [ 0.000000] node 2: [mem 0x0000001040000000-0x000000183fffffff]
27 [ 0.000000] node 3: [mem 0x0000001840000000-0x000000203fffffff]
28 [ 0.000000] Initmem setup node 0 [mem
0x0000000040000000-0x000000083fffffff]
29 [ 0.000000] On node 0 totalpages: 8388608
Is there anything wrong ?
>
>
> Thanks,
> SJ
>
>> __entry->nr_regions = nr_regions;
>> __entry->start = r->ar.start;
>> __entry->end = r->ar.end;
>> @@ -34,7 +34,7 @@ TRACE_EVENT(damon_aggregated,
>> __entry->age = r->age;
>> ),
>>
>> - TP_printk("target_id=%lu nr_regions=%u %lu-%lu: %u %u",
>> + TP_printk("target_id=%u nr_regions=%u %lx-%lx: %u %u",
>> __entry->target_id, __entry->nr_regions,
>> __entry->start, __entry->end,
>> __entry->nr_accesses, __entry->age)
>> --
>> 2.31.0
--
Best Regards!
Xin Hao
[-- Attachment #2: Type: text/html, Size: 24913 bytes --]
next prev parent reply other threads:[~2021-12-10 3:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 16:33 [PATCH V1 0/2] mm/damon: Do little changes Xin Hao
2021-12-09 16:33 ` [PATCH V1 1/2] mm/damon/dbgfs: Avoid target_ids display wrong pid value Xin Hao
2021-12-09 16:33 ` [PATCH V1 2/2] mm/damon: Modify the display form of damon tracepoint Xin Hao
2021-12-09 16:46 ` SeongJae Park
2021-12-10 3:36 ` Xin Hao [this message]
2021-12-10 8:18 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6142e6f-266d-1dec-a3b6-83e622280462@linux.alibaba.com \
--to=xhao@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox