From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A431C47DD9 for ; Mon, 26 Feb 2024 01:43:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDEAC6B012A; Sun, 25 Feb 2024 20:43:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D8EA36B012B; Sun, 25 Feb 2024 20:43:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C56806B012C; Sun, 25 Feb 2024 20:43:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B6E376B012A for ; Sun, 25 Feb 2024 20:43:32 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7EC6D1601F9 for ; Mon, 26 Feb 2024 01:43:32 +0000 (UTC) X-FDA: 81832257864.14.DA7D6EE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 37A95C0005 for ; Mon, 26 Feb 2024 01:43:30 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Mze7/Vwa"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of xiubli@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708911810; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lmMqCI/dOuk22TO51t0Np8k9xwWwCikISvrBZRgIdGg=; b=nrg/blRFlxrhpo11vSzRzmFLHKK74Svee3Iy9SGU8QkuDZ/zZrEZRPcQE5UXheo6TQPzMC O9kGL3N35wyXxESOJOGI6j2LzfacpXQkk31Yxqt9ABQO7ml/eX5OHbiTzVo2SR791P1pt9 Fd7aYqtYAVc0nYlHCwkWPcu3PSRz+Ek= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Mze7/Vwa"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of xiubli@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708911810; a=rsa-sha256; cv=none; b=WD8d26XOwYt9X/FzJu9yix110tCaoYljFn96iQij03VaOiGMZSL1FIGhz7ZLIHqvq3MkcJ uFDl5klOQPR9lna1ut5C3Z2u2r6eHzIx78mYvpI6p9AQLU98x95izduK2rUI9g8Xl1QQYA 9mYZxVO4roIh/G/vh9G+6phIVgphOOs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708911809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lmMqCI/dOuk22TO51t0Np8k9xwWwCikISvrBZRgIdGg=; b=Mze7/VwaJsIRJFylNyR1m42Gq3WmPILBF1Gi2wnES4v+axYBHJ3SHwNOvc/VUMFsi5TDG4 JdiQiOswl3chACckUvxfQ17cZQwSdA5sQPS2dvfPDuPgNv7Rtjc1hSRSGI/bwxgqV2hhEQ LppAu7cA6k+oMUOuzdWcGX9siAZRNLA= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-225-fd0VRPc9NJWPVLo_QzODnQ-1; Sun, 25 Feb 2024 20:43:25 -0500 X-MC-Unique: fd0VRPc9NJWPVLo_QzODnQ-1 Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-5a04ee4c112so2313580eaf.3 for ; Sun, 25 Feb 2024 17:43:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708911805; x=1709516605; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lmMqCI/dOuk22TO51t0Np8k9xwWwCikISvrBZRgIdGg=; b=xIHBgyCCtJwgINpLbpnSGDjfLhdDo23m8tPEu8FnC0fAVNb35qC6AoHuYU9FIlfJRi J8o1BwP7CvfHsZWMppzqpfZoiu2uCTDQmU4sGctpre9XyfKWHsMpNnWXGJ8pZBmRSgUf q493cQ3FrVbJE8sG5nao9JJhb/pTJbUab9E6bx3SbFXh96ITL6VTMzrqYXgxpL9PDSNa WusVkAs+PmYctrDeobFyDY3pKXbocXs99KKQStiraNpQKXN8kJlnYHXu6Adv5jxrNEKj 7x1IH4J0rq6TBGSE8iQMIIHIkLXb03W+UVabpz3Fc1s/Yep5mnl4Sh61B7QS/BCMAdQX TUJg== X-Forwarded-Encrypted: i=1; AJvYcCU1pTvSJXebad7ODAHGpjt5XLfGpy6D3vFpCBogjktoxpZFeAYumbwvounpxsIdXt3KNifufgWflaFgsFD6XclWTO4= X-Gm-Message-State: AOJu0YyAixV2j89c3r0s3AFKDgDEg6RwlEst80UHn/lMM+WPAD6dueGc 91I6mOvyQX3HtKnOxSjtEg0ybZASxxYegEshuVBqcrnKTDWND7mUMhr6fpiwxrN5LVFun6jQCfs izaFsXoKkzt7Qx5NpmWypfB1vRYHwUQiqlPTqsAJyVlHTtyPr X-Received: by 2002:a05:6358:e491:b0:178:75b1:c403 with SMTP id by17-20020a056358e49100b0017875b1c403mr9350608rwb.9.1708911804950; Sun, 25 Feb 2024 17:43:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IFa5F8YzBb5iYXJsjW1TiccfqBN9TvPu4sLUOXFO2MTebLlMq/RCQI18Qsh2vGE7IwOLIQfnw== X-Received: by 2002:a05:6358:e491:b0:178:75b1:c403 with SMTP id by17-20020a056358e49100b0017875b1c403mr9350595rwb.9.1708911804680; Sun, 25 Feb 2024 17:43:24 -0800 (PST) Received: from [10.72.112.131] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id li16-20020a17090b48d000b0029ab712f648sm1409442pjb.38.2024.02.25.17.43.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Feb 2024 17:43:24 -0800 (PST) Message-ID: Date: Mon, 26 Feb 2024 09:43:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ceph: remove SLAB_MEM_SPREAD flag usage To: chengming.zhou@linux.dev, idryomov@gmail.com, jlayton@kernel.org Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com, Chengming Zhou References: <20240224134715.829225-1-chengming.zhou@linux.dev> From: Xiubo Li In-Reply-To: <20240224134715.829225-1-chengming.zhou@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 37A95C0005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: qh7f1cyw8php1j1yjn93s5g361yr8y3j X-HE-Tag: 1708911810-183602 X-HE-Meta: U2FsdGVkX19AszI+LqcGbcH8Z2+R176chQNO2VgZwrGB0Z4PJ+YNCatpB4qSjTwALgrq7Ggmj9JJ9AyzBcD5JdHq5S4KtZ+3AcMDa0jHwVSdQCVhmSszjl+Av8uNFHHloqpfuHCPEEjdFLpY/Xt5VDqGGG4WeLgu51JIu5dfkmf5xA/hK84x+AOrqsscebZPYX2UvVQH6JrkNUyH77TxACixnclJbBf0pRZisoF+BVBhPao4JuhEa2yhXiqWi7ZOmkNkp09BCkjW06h3VCXp9kXcJBbtNZotfYZ+b2b5B5YlAGz1cQFhjGLB4jVQY0m0l5jztTJ5lDy6r3HWtZng0FbMStxNXprkAVn3yqwO7vyLCyKt+IwLzKCBYv5sEEseL9xqiD+YepiXNXAmuGKlqufb8C2cKvuF+jl0w0WmIML5OIUJFk6dvGN6UqPgOSoAiYWm+YTbtZ6z4zgcr7JiMWImfbyu5r5DWwRf+GCh43t60CNegOj8UtxHn6Psw3A9wfqy1JskSCIRFQ4tC20Ki+W95Cze5KuvJ4jiyamakRu0iDVIU07J6w+YRdB/f8uYtn9owiyCX9hzTLmPR3j6CBFMCKEifssTI6pleoBYfv6gc4ocvgwivlX7mJCtxwtG40TC37vgktJB6kHMp9kvmh8BNl0vNxhnTwGn/7bTz7y6AuoulS9NfzqLPfG8LulbevL0C8b1nAd/56364IFYlyMxCbsUpt9oek+EaHMR6iHSUNcSGoc9oudlE/vpFC0/zpnP2X8LBw53OjkHOuG1MtG37Y1lhDd1CyCwo4vmK6BE36IctWC6xjExqVBNBGCQAZtE7GMhEmLYd2epEsofYc0mpGgMgYIxtVJMLtXb9afVgx3kC77E75OvNOgVeN6DTdrZrjF2uFKIWTtSslgwrbMbjU8bqAoy0swavWhcbygFcd7WUK8uHMizn41qH2swx4gOGF9wau19ldGDVi/ iNyzectW aWM0Q+lfBuwfzGDCEBJuH126NyI884IE24V62L3cHBbbLKxVRVA5CwqNFWnr1SLTA9fFll/X/KFjG1Ym//MLOfXZcoUMqGUvAUU/YLHHOpKVsEO65+nDVcTqJaj2gCMH66DTfM+0hCm+IhWQ/sIl6faYKpxRdtne4cCqILb21IgOe20fTwggCAb6YN/ZbK4qYkf/1yY+QgcHma2lW/2FEOmwTD3yWcqbF2G6WwTmQ303rXojG+6dDxnLaR3V4uYa6TgLEbxr+68upVhKXDxZ1i4k/HkmmhOcMdfvBT7czkIJGe1+yGIVVmWZXP/gXyXoYRQ6eHn1H5ZK6XfEMY6+yXylK/jBHmSTnc/Egd/5Ry7SsftelBY0bI7aevqkb3q+JdgtQHW0zxsX90EFnjHIXpLrGARDjlONXaD6G/UlOfSeV7AwdFthvYizIjYPw5Z4WfuI2wPzexeuwm0S/5OtplSvqVLpt43JfiYDBLN6ezXaIEP9S3SDz4uZbtjI/7TOFgucX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Chengming, Thanks for your patch. BTW, could you share the link of the relevant patches to mark this a no-op ? Thanks - Xiubo On 2/24/24 21:47, chengming.zhou@linux.dev wrote: > From: Chengming Zhou > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove > its usage so we can delete it from slab. No functional change. > > Signed-off-by: Chengming Zhou > --- > fs/ceph/super.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/fs/ceph/super.c b/fs/ceph/super.c > index 5ec102f6b1ac..4dcbbaa297f6 100644 > --- a/fs/ceph/super.c > +++ b/fs/ceph/super.c > @@ -928,36 +928,36 @@ static int __init init_caches(void) > ceph_inode_cachep = kmem_cache_create("ceph_inode_info", > sizeof(struct ceph_inode_info), > __alignof__(struct ceph_inode_info), > - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD| > - SLAB_ACCOUNT, ceph_inode_init_once); > + SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT, > + ceph_inode_init_once); > if (!ceph_inode_cachep) > return -ENOMEM; > > - ceph_cap_cachep = KMEM_CACHE(ceph_cap, SLAB_MEM_SPREAD); > + ceph_cap_cachep = KMEM_CACHE(ceph_cap, 0); > if (!ceph_cap_cachep) > goto bad_cap; > - ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, SLAB_MEM_SPREAD); > + ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, 0); > if (!ceph_cap_snap_cachep) > goto bad_cap_snap; > ceph_cap_flush_cachep = KMEM_CACHE(ceph_cap_flush, > - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); > + SLAB_RECLAIM_ACCOUNT); > if (!ceph_cap_flush_cachep) > goto bad_cap_flush; > > ceph_dentry_cachep = KMEM_CACHE(ceph_dentry_info, > - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); > + SLAB_RECLAIM_ACCOUNT); > if (!ceph_dentry_cachep) > goto bad_dentry; > > - ceph_file_cachep = KMEM_CACHE(ceph_file_info, SLAB_MEM_SPREAD); > + ceph_file_cachep = KMEM_CACHE(ceph_file_info, 0); > if (!ceph_file_cachep) > goto bad_file; > > - ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, SLAB_MEM_SPREAD); > + ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, 0); > if (!ceph_dir_file_cachep) > goto bad_dir_file; > > - ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, SLAB_MEM_SPREAD); > + ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, 0); > if (!ceph_mds_request_cachep) > goto bad_mds_req; >