Re: [PATCH] ceph: remove SLAB_MEM_SPREAD flag usage

[Xiubo Li <xiubli@redhat.com>]

Hi Chengming,

Thanks for your patch.

BTW, could you share the link of the relevant patches to mark this a no-op ?

Thanks

- Xiubo

On 2/24/24 21:47, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
>   fs/ceph/super.c | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/fs/ceph/super.c b/fs/ceph/super.c
> index 5ec102f6b1ac..4dcbbaa297f6 100644
> --- a/fs/ceph/super.c
> +++ b/fs/ceph/super.c
> @@ -928,36 +928,36 @@ static int __init init_caches(void)
>   	ceph_inode_cachep = kmem_cache_create("ceph_inode_info",
>   				      sizeof(struct ceph_inode_info),
>   				      __alignof__(struct ceph_inode_info),
> -				      SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD|
> -				      SLAB_ACCOUNT, ceph_inode_init_once);
> +				      SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT,
> +				      ceph_inode_init_once);
>   	if (!ceph_inode_cachep)
>   		return -ENOMEM;
>   
> -	ceph_cap_cachep = KMEM_CACHE(ceph_cap, SLAB_MEM_SPREAD);
> +	ceph_cap_cachep = KMEM_CACHE(ceph_cap, 0);
>   	if (!ceph_cap_cachep)
>   		goto bad_cap;
> -	ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, SLAB_MEM_SPREAD);
> +	ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, 0);
>   	if (!ceph_cap_snap_cachep)
>   		goto bad_cap_snap;
>   	ceph_cap_flush_cachep = KMEM_CACHE(ceph_cap_flush,
> -					   SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD);
> +					   SLAB_RECLAIM_ACCOUNT);
>   	if (!ceph_cap_flush_cachep)
>   		goto bad_cap_flush;
>   
>   	ceph_dentry_cachep = KMEM_CACHE(ceph_dentry_info,
> -					SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD);
> +					SLAB_RECLAIM_ACCOUNT);
>   	if (!ceph_dentry_cachep)
>   		goto bad_dentry;
>   
> -	ceph_file_cachep = KMEM_CACHE(ceph_file_info, SLAB_MEM_SPREAD);
> +	ceph_file_cachep = KMEM_CACHE(ceph_file_info, 0);
>   	if (!ceph_file_cachep)
>   		goto bad_file;
>   
> -	ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, SLAB_MEM_SPREAD);
> +	ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, 0);
>   	if (!ceph_dir_file_cachep)
>   		goto bad_dir_file;
>   
> -	ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, SLAB_MEM_SPREAD);
> +	ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, 0);
>   	if (!ceph_mds_request_cachep)
>   		goto bad_mds_req;
>