From: Randy Dunlap <rdunlap@infradead.org>
To: "Deepak Gupta" <debug@rivosinc.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Conor Dooley" <conor@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Christian Brauner" <brauner@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Oleg Nesterov" <oleg@redhat.com>,
"Eric Biederman" <ebiederm@xmission.com>,
"Kees Cook" <kees@kernel.org>, "Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <shuah@kernel.org>, "Jann Horn" <jannh@google.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Benno Lossin" <lossin@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org, linux-arch@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
alistair.francis@wdc.com, richard.henderson@linaro.org,
jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com,
charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com,
cleger@rivosinc.com, alexghiti@rivosinc.com,
samitolvanen@google.com, broonie@kernel.org,
rick.p.edgecombe@intel.com, rust-for-linux@vger.kernel.org,
Zong Li <zong.li@sifive.com>,
Andreas Korb <andreas.korb@aisec.fraunhofer.de>,
Valentin Haudiquet <valentin.haudiquet@canonical.com>
Subject: Re: [PATCH v24 25/28] riscv: create a config for shadow stack and landing pad instr support
Date: Thu, 4 Dec 2025 14:17:27 -0800 [thread overview]
Message-ID: <b5feba48-7e7c-4ab9-a193-072f3980f525@infradead.org> (raw)
In-Reply-To: <20251204-v5_user_cfi_series-v24-25-ada7a3ba14dc@rivosinc.com>
On 12/4/25 12:04 PM, Deepak Gupta wrote:
> This patch creates a config for shadow stack support and landing pad instr
> support. Shadow stack support and landing instr support can be enabled by
> selecting `CONFIG_RISCV_USER_CFI`. Selecting `CONFIG_RISCV_USER_CFI` wires
> up path to enumerate CPU support and if cpu support exists, kernel will
> support cpu assisted user mode cfi.
>
> If CONFIG_RISCV_USER_CFI is selected, select `ARCH_USES_HIGH_VMA_FLAGS`,
> `ARCH_HAS_USER_SHADOW_STACK` and DYNAMIC_SIGFRAME for riscv.
>
> Reviewed-by: Zong Li <zong.li@sifive.com>
> Tested-by: Andreas Korb <andreas.korb@aisec.fraunhofer.de>
> Tested-by: Valentin Haudiquet <valentin.haudiquet@canonical.com>
> Signed-off-by: Deepak Gupta <debug@rivosinc.com>
> ---
> arch/riscv/Kconfig | 22 ++++++++++++++++++++++
> arch/riscv/configs/hardening.config | 4 ++++
> 2 files changed, 26 insertions(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 0c6038dc5dfd..f5574c6f66d8 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -1146,6 +1146,28 @@ config RANDOMIZE_BASE
>
> If unsure, say N.
>
> +config RISCV_USER_CFI
> + def_bool y
> + bool "riscv userspace control flow integrity"
> + depends on 64BIT && \
> + $(cc-option,-mabi=lp64 -march=rv64ima_zicfiss_zicfilp -fcf-protection=full)
> + depends on RISCV_ALTERNATIVE
> + select RISCV_SBI
> + select ARCH_HAS_USER_SHADOW_STACK
> + select ARCH_USES_HIGH_VMA_FLAGS
> + select DYNAMIC_SIGFRAME
> + help
> + Provides CPU assisted control flow integrity to userspace tasks.
CPU-assisted
> + Control flow integrity is provided by implementing shadow stack for
> + backward edge and indirect branch tracking for forward edge in program.
> + Shadow stack protection is a hardware feature that detects function
> + return address corruption. This helps mitigate ROP attacks.
> + Indirect branch tracking enforces that all indirect branches must land
> + on a landing pad instruction else CPU will fault. This mitigates against
> + JOP / COP attacks. Applications must be enabled to use it, and old user-
> + space does not get protection "for free".
> + default y.
Default is y if hardware supports it.
?
> +
> endmenu # "Kernel features"
--
~Randy
next prev parent reply other threads:[~2025-12-04 22:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 20:03 [PATCH v24 00/28] riscv control-flow integrity for usermode Deepak Gupta
2025-12-04 20:03 ` [PATCH v24 01/28] mm: VM_SHADOW_STACK definition for riscv Deepak Gupta
2025-12-04 20:03 ` [PATCH v24 02/28] dt-bindings: riscv: zicfilp and zicfiss in dt-bindings (extensions.yaml) Deepak Gupta
2025-12-04 20:03 ` [PATCH v24 03/28] riscv: zicfiss / zicfilp enumeration Deepak Gupta
2025-12-04 20:03 ` [PATCH v24 04/28] riscv: zicfiss / zicfilp extension csr and bit definitions Deepak Gupta
2025-12-04 20:03 ` [PATCH v24 05/28] riscv: usercfi state for task and save/restore of CSR_SSP on trap entry/exit Deepak Gupta
2025-12-04 20:03 ` [PATCH v24 06/28] riscv/mm : ensure PROT_WRITE leads to VM_READ | VM_WRITE Deepak Gupta
2025-12-04 20:03 ` [PATCH v24 07/28] riscv/mm: manufacture shadow stack pte Deepak Gupta
2025-12-04 20:03 ` [PATCH v24 08/28] riscv/mm: teach pte_mkwrite to manufacture shadow stack PTEs Deepak Gupta
2025-12-04 20:03 ` [PATCH v24 09/28] riscv/mm: write protect and shadow stack Deepak Gupta
2025-12-04 20:03 ` [PATCH v24 10/28] riscv/mm: Implement map_shadow_stack() syscall Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 11/28] riscv/shstk: If needed allocate a new shadow stack on clone Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 12/28] riscv: Implements arch agnostic shadow stack prctls Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 13/28] prctl: arch-agnostic prctl for indirect branch tracking Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 14/28] riscv: Implements arch agnostic indirect branch tracking prctls Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 15/28] riscv/traps: Introduce software check exception and uprobe handling Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 16/28] riscv: signal: abstract header saving for setup_sigcontext Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 17/28] riscv/signal: save and restore of shadow stack for signal Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 18/28] riscv/kernel: update __show_regs to print shadow stack register Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 19/28] riscv/ptrace: riscv cfi status and state via ptrace and in core files Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 20/28] riscv/hwprobe: zicfilp / zicfiss enumeration in hwprobe Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 21/28] riscv: kernel command line option to opt out of user cfi Deepak Gupta
2025-12-04 22:13 ` Randy Dunlap
2025-12-04 20:04 ` [PATCH v24 22/28] riscv: enable kernel access to shadow stack memory via FWFT sbi call Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 23/28] arch/riscv: compile vdso with landing pad and shadow stack note Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 24/28] arch/riscv: dual vdso creation logic and select vdso based on hw Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 25/28] riscv: create a config for shadow stack and landing pad instr support Deepak Gupta
2025-12-04 22:17 ` Randy Dunlap [this message]
2025-12-05 18:24 ` Deepak Gupta
2025-12-05 19:41 ` Randy Dunlap
2025-12-04 20:04 ` [PATCH v24 26/28] riscv: Documentation for landing pad / indirect branch tracking Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 27/28] riscv: Documentation for shadow stack on riscv Deepak Gupta
2025-12-04 20:04 ` [PATCH v24 28/28] kselftest/riscv: kselftest for user mode cfi Deepak Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5feba48-7e7c-4ab9-a193-072f3980f525@infradead.org \
--to=rdunlap@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex.gaynor@gmail.com \
--cc=alexghiti@rivosinc.com \
--cc=aliceryhl@google.com \
--cc=alistair.francis@wdc.com \
--cc=andreas.korb@aisec.fraunhofer.de \
--cc=andybnac@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=atishp@rivosinc.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=charlie@rivosinc.com \
--cc=cleger@rivosinc.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=debug@rivosinc.com \
--cc=devicetree@vger.kernel.org \
--cc=ebiederm@xmission.com \
--cc=evan@rivosinc.com \
--cc=gary@garyguo.net \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=jim.shu@sifive.com \
--cc=kees@kernel.org \
--cc=kito.cheng@sifive.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=mingo@redhat.com \
--cc=ojeda@kernel.org \
--cc=oleg@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=richard.henderson@linaro.org \
--cc=rick.p.edgecombe@intel.com \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
--cc=valentin.haudiquet@canonical.com \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox