From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1004C83F27 for ; Wed, 16 Jul 2025 05:19:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 400866B0092; Wed, 16 Jul 2025 01:19:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B0716B0093; Wed, 16 Jul 2025 01:19:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29FAF6B0095; Wed, 16 Jul 2025 01:19:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 15C656B0092 for ; Wed, 16 Jul 2025 01:19:16 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8E7FA1D3B6D for ; Wed, 16 Jul 2025 05:19:15 +0000 (UTC) X-FDA: 83668974270.13.FF74D87 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by imf19.hostedemail.com (Postfix) with ESMTP id 47F5C1A0006 for ; Wed, 16 Jul 2025 05:19:13 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=B5m41XmO; spf=pass (imf19.hostedemail.com: domain of xiaoyao.li@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752643153; a=rsa-sha256; cv=none; b=OQkiZeLdEqGmWJUbLVUsD/hGSdFUnFOwBAimiXSJxgHNhBYYLRvoO75gDY2cFMKuntpmb9 djLl8R7p98zsyWRFAt218BCOnvvgCuIcN5ausn6LcVIXil4GgzleZ+8d+U7USHl3p+ygNU uFSeFUASSEAGWMuSbOpYQGbTCbzm9z8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=B5m41XmO; spf=pass (imf19.hostedemail.com: domain of xiaoyao.li@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752643153; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sDvZsi2x/ZGCyu5BNUn7pqUONEoO4As5cRlcf9rP8jw=; b=Xu3O5BYIq60RKOEd09JTp2v+9aq8T33RrBvSUXgDtZC2CRPH0g9u7zTyKJxQikADvAUnKC OZk4akifpcaopvrhjMhp7qnhGRpVGT1KUbh0GQIgCzKIF7yjINUig+qeldij26agi6dSDW 0Ec6Ekse2PwlF/eNXPYqUc3QcuRrVE8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752643153; x=1784179153; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ACeJsjJgiO+CHQEq/zTw4r/Vew4KL7aqSzVje7WzBRk=; b=B5m41XmOTBew0oX+2fGe6ovlLac7NWs52TXQxUJrJjclBT4J7mhShwO0 mLRQWo/+WLegJYTrG80xmwN06EQvaoaPOIFoILpeesKv7ae2JdSiNh2U1 jURR7/xosN0LTr9MjsIB/0lZh0M2LS9yxS7Y3Go2sjeDpNSkYokqVMOTf m+3iX+0sNusvzqMhVgDheR/GoxWOJvav7+nlWCb2YX2wP5HohR/sm/9K+ 8xPw2AxLaZvIY0Ksa1yGV0KxnDNi9m7oy/wJNqfDm25Vhbm32eI3O4Fvc SLjtmdxAPfFmgyFjveHNRbidA0ggmxTsOQUzBHEyplNBJ05qVYY/GwzYp g==; X-CSE-ConnectionGUID: sJhQJmT8Sv+PMRcAXuko4w== X-CSE-MsgGUID: 48bXrKWpSIWgiYA3w0EEhQ== X-IronPort-AV: E=McAfee;i="6800,10657,11493"; a="72450039" X-IronPort-AV: E=Sophos;i="6.16,315,1744095600"; d="scan'208";a="72450039" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2025 22:19:11 -0700 X-CSE-ConnectionGUID: j7EXiFajTcaQq4oFn8LIVg== X-CSE-MsgGUID: 2VAAn0VzTD6hSHKhcdVWfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,315,1744095600"; d="scan'208";a="156804591" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.124.247.1]) ([10.124.247.1]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2025 22:18:55 -0700 Message-ID: Date: Wed, 16 Jul 2025 13:18:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 04/21] KVM: x86: Introduce kvm->arch.supports_gmem To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250715093350.2584932-1-tabba@google.com> <20250715093350.2584932-5-tabba@google.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: <20250715093350.2584932-5-tabba@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 47F5C1A0006 X-Stat-Signature: 1i8r8a8s7g1ty31toq53i18jr5m8qe6s X-HE-Tag: 1752643153-117058 X-HE-Meta: U2FsdGVkX19vYNxws1U3XcOL8pyAIFYYbnOHNXPOtcdum1DOVNcEb0DfGPm8zwMKrCVHso+Iqm65K3XyPqxAdQ5fil9Qc4+sWD+Euz08fvdNJ4GeAM2MW+7/gOigFGrIN2WJ6hsf9B7XEhmV66HfuOV2NdA5ftGY05NGzfgO4f+x3Cpx9WS8BBvwRZCX+BR9awSkpwobLE6E8bjZN6m9ZUdg04SsImEIuhDteRbVhBGWVLPckdMiDB99pODjMBsI9KbuujbhMdB+zIDNNYkI9+z8L+vLHLvOPRVLL062bJqw8g+NGWBixj+sSTr9WmSwd1nsKS6AvMIj6Jh0bovMST8ZEvgn17gxStrFwJR9hwG+2W+d1MNKT4qDWVMeRXb3KBm4remgI/eoLDjY5z3ewpCEkJnRfYhVSj7GQXGkw74TukCrXOm34BWsCNTVXcyHt4e7dFaPDc6c3Xxy6183N9erAO+oSMgmQ7z5wKdZzyV/LUIQjoLffvF+0IroIegXHfzxsJlWqQ2ItzK9yZbyQdLmIaaLUt+C5BlguN1h3Z4IqWnGyiX+0V7UXIUkNG2W1ch6qgazTJVVPeAxSWEepts0uFRq0u/K5xShIJ3R3LOdqYnKhizUvUR8v4hmfZe9fOBZn06UexdmHov7mSSCwjpcN52kK9D4ppNJu1XxpsNs2IOaAC0odhaany/yN2XzrL28P785fVz5N9wXF3/+eWk7CiD0CJ5uxSf4piVFt7Ay/oRocfzfSe4H65UP9etzjpaTBW3a4W3XGKigpmykwJbdsL8QijYrpPD0EronnoziTaov6mo7aq/vCTOiedcdMszL/wsvWB+m67TMPENtVha1ZAdu4GMAgXVPGZA08S/OujE7DU7auP2RX2NScVLkBYmT5blA6yWlezXIQGoqawKUvMD1jqvQI9T6QY9KzAQ5qzhHCzY9/noywhgKOY9gscheIsJHL29j9gxk6OP jMfKCVur 816jqL8NZEmxPnqNwU6WP2vBJd8AIFbiRz2Z9XrN9zc7SoRtWgycqwd5avrxhf4GZt/aZ52BUs4w565uW4DwKgSl6OkT5G65NT2AI8XvB5O6TBkGmqVm5PNYSBeSh91EtluVKeW1v0bqcZAMOcOanioPsDsmlrzwkFlmJlXGmm2Ugo5aJ7zPyy+ULsDkbRjbHFOSicDt/zd0hl/Zcw2+qkP6fNJpkhanMiJ1kcNPEcPWThL2sFl7rsAI28zOjupZK0bMgOPYo1gbaMKdczf1r3hNIyR6oi0MfSWeI+kwfqRp0C5yD43pZgCf9mIkJPhPCF/fHhoDL997wfUln6yOwYrAZGuHwq6u8AfYZArXdEXL9GLSfxuEusRk/04ehfeET082+jz+TJnJtSUtqlS59LSXAbLBm7PxiNevL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/15/2025 5:33 PM, Fuad Tabba wrote: > Introduce a new boolean member, supports_gmem, to kvm->arch. > > Previously, the has_private_mem boolean within kvm->arch was implicitly > used to indicate whether guest_memfd was supported for a KVM instance. > However, with the broader support for guest_memfd, it's not exclusively > for private or confidential memory. Therefore, it's necessary to > distinguish between a VM's general guest_memfd capabilities and its > support for private memory. > > This new supports_gmem member will now explicitly indicate guest_memfd > support for a given VM, allowing has_private_mem to represent only > support for private memory. > > Reviewed-by: Ira Weiny > Reviewed-by: Gavin Shan > Reviewed-by: Shivank Garg > Reviewed-by: Vlastimil Babka > Co-developed-by: David Hildenbrand > Signed-off-by: David Hildenbrand > Signed-off-by: Fuad Tabba Reviewed-by: Xiaoyao Li Btw, it seems that supports_gmem can be enabled for all the types of VM? Even without mmap support, allow all the types of VM to create guest_memfd seems not something wrong. It's just that the guest_memfd allocated might not be used, e.g., for KVM_X86_DEFAULT_VM.