From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1B4CC433EF for ; Tue, 14 Dec 2021 16:50:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70B3B6B0080; Tue, 14 Dec 2021 11:39:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BAC66B0081; Tue, 14 Dec 2021 11:39:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AA746B0082; Tue, 14 Dec 2021 11:39:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id 4C1E16B0080 for ; Tue, 14 Dec 2021 11:39:51 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 16367180B7E18 for ; Tue, 14 Dec 2021 16:39:41 +0000 (UTC) X-FDA: 78916960962.13.CDAD153 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf24.hostedemail.com (Postfix) with ESMTP id B68E1180005 for ; Tue, 14 Dec 2021 16:39:37 +0000 (UTC) Received: from fraeml715-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4JD3vJ1m02z67qfF; Wed, 15 Dec 2021 00:37:32 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml715-chm.china.huawei.com (10.206.15.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 17:39:38 +0100 Received: from [10.47.83.94] (10.47.83.94) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 16:39:37 +0000 Subject: Re: [PATCH v2 05/11] iommu/iova: Squash flush_cb abstraction To: Robin Murphy , , CC: , , , , , References: <6326303c396e28fd3b9ed89d82673dfcf159b8c6.1639157090.git.robin.murphy@arm.com> From: John Garry Message-ID: Date: Tue, 14 Dec 2021 16:39:14 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <6326303c396e28fd3b9ed89d82673dfcf159b8c6.1639157090.git.robin.murphy@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.83.94] X-ClientProxiedBy: lhreml701-chm.china.huawei.com (10.201.108.50) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: B68E1180005 X-Stat-Signature: qpwbgadxmdr1qoquq8whpqxxkmeep4mh Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of john.garry@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=john.garry@huawei.com X-Rspamd-Server: rspam11 X-HE-Tag: 1639499977-960144 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/12/2021 17:54, Robin Murphy wrote: > Once again, with iommu-dma now being the only flush queue user, we no > longer need the extra level of indirection through flush_cb. Squash that > and let the flush queue code call the domain method directly. > > Signed-off-by: Robin Murphy Again seems pretty straightforward, so FWIW: Reviewed-by: John Garry