linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: liuq131@chinatelecom.cn, linux-mm@kvack.org,
	kernel-janitors@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/sparse: remove redundant judgement from macro for_each_present_section_nr
Date: Fri, 7 Jul 2023 17:17:43 +0200	[thread overview]
Message-ID: <b5f5c493-11a4-4349-d78d-c52d61afa06a@web.de> (raw)
In-Reply-To: <20230707060501.29184-1-liuq131@chinatelecom.cn>

> The next_present_section_nr function has already ensured
> that 'section_nr<=__highest_present_section_nr',
> so this conditional judgment is removed.

Please choose an imperative change suggestion.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94


> Signed-off-by: liuq <liuq131@chinatelecom.cn>

Would a more unique real name be more appropriate here?

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n411

Regards,
Markus


      reply	other threads:[~2023-07-07 15:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-07  6:05 [PATCH] mm/sparse: remove redundant judgments " liuq
2023-07-07 15:17 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5f5c493-11a4-4349-d78d-c52d61afa06a@web.de \
    --to=markus.elfring@web.de \
    --cc=akpm@linux-foundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuq131@chinatelecom.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox