From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B9EDC27C55 for ; Fri, 7 Jun 2024 09:44:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 250336B00A1; Fri, 7 Jun 2024 05:44:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FF036B00B3; Fri, 7 Jun 2024 05:44:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EE036B00B4; Fri, 7 Jun 2024 05:44:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E4DFE6B00A1 for ; Fri, 7 Jun 2024 05:44:23 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9D20F161381 for ; Fri, 7 Jun 2024 09:44:23 +0000 (UTC) X-FDA: 82203607206.04.8FC16E5 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf06.hostedemail.com (Postfix) with ESMTP id C087E18000D for ; Fri, 7 Jun 2024 09:44:21 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=0edyv3px; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf06.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717753462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HDjQPIHL0H9v7s08tmQO2o5EsAH+JdltksHP3LDa1ck=; b=O9w3llvcZvpJEOVqz1blIv+hz9rScuB64zrz6Kdsor4ac8YfCRfrmJo+hQt43orDZd1PkW PMJcDBVHr+0oOHjZd+F43bDRj351THFNCuOBV6l59KQgmeh9FvQMGz3ZKNV8gwmStG+zXs 7lt3DGA+DM2v9qM5z3sFrwchL0Q3eq4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=0edyv3px; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf06.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717753462; a=rsa-sha256; cv=none; b=XSugK0h0APPghmVn36Ok1yV1Qc3mIhAVIoWkIVBk+qvMIaY65Z3Eo50qCJChvftUjDKiuY ZLjmQAEwVTQNN5UwaleX0vyWBbDL45q4mK0iEGAc2ueKGXWR1CQv/ivJE9Wkc2MCFMmG2B ier2Bde36avoloIEikIoWag/o9S6ZxU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1717753460; bh=dQkXUytkyefTpJTOjW53oGPquKBi+JFRsTG1LaCoypQ=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=0edyv3px19syu5RPaQqFOA4Iew+3rFhQjoIYCjce4DL3tIFEGwZKamNgJjlD0Yvoz jRaJsNZlpwkfRyRa0GE4my+Vs60ypVSOtmOtdr8fVNTvTszWFiYt+D55PpfVwFhENa WEQ3tPBWskovf5o0I7eyFIPrtYXysUuGRf5O0Dxr5HLcb8MvoWSa9SjXPxvooCK6OJ 43J+gZbTV1wg6L89aiSF+h7hqJarpw8rEM03kc943zgD7hi7L9faVKxOUBdCVB7/WJ LCswp/yySfsku6IWwcgnqava8tY+ZAy2gk/TX9U+P2n3B4yD62q/c/8wsyyTbDLYCs k3yKZ1yVnkjSg== Received: from [100.113.15.66] (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id E306537811D1; Fri, 7 Jun 2024 09:44:15 +0000 (UTC) Message-ID: Date: Fri, 7 Jun 2024 14:44:50 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , cmllamas@google.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, llvm@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH v1 1/2] selftests/mm: Include linux/mman.h To: Edward Liaw , shuah@kernel.org, Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Andrew Morton References: <20240605223637.1374969-1-edliaw@google.com> <20240605223637.1374969-2-edliaw@google.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20240605223637.1374969-2-edliaw@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C087E18000D X-Stat-Signature: 76nnhcdm811r9oryadsjcxcp7g4y3jdp X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717753461-198414 X-HE-Meta: U2FsdGVkX1+t0i8jqm5BjVTKEspeiNUdGjrY2ysww6u/YN1BVvBOoj/9skaZp+IVt55UxIveW69T/2p/mmbQdqMIjEMRQ0xxVDim27yRBKWfMT22RAF//tym6urgIQMdZgm5Zk0YgaEL+ctisrE9I1DTMsN+xdRQ2/lIT+YaLf7YwAVNdhxH0+EyXVe4xZ4G2aFeZ7nJTmq7bj5aelBv39E4A54S2bFQ9j4Y0ToKEV8FiqZc1bllt4iqi2d2bAI8YTpfu3xGmYhahr4ynXSxGK53SFG9nJkvktxe6L/SlUdF/MqT66SYB1nB2p+XcZ+5VKueYY1MRapQ1wJQcH4badfZ+7BlJUCSonMNLyxLYQ58GHgDVWfdzyFx6WBKLWxKjMWZL+O1GfZ8aefuWI3AwmbsHr4kHNj1XsMiwJ6IkPTQ8qAbSegcDN/ozVQZxrB+jV55eCb5MOTi7zfe3lTEUvETzhfPWQYM7iSfnudZJkD0YAXDOJiJbb6F+pyeHpsvdLlXelKsRv/XMwoANg4LxAum6KBDm//Go5asV7Nt1s0R/ogOkpwZjHyQH4U/r8EQwQ+cXAMMT0uxtQ8drNs6IcGWjdIha/m8NsAoGFICyBVwCbTP87Ja6hUhw9ZBcXHoqlkZHEaTKfgCIpYE0aRsPGUUOyYt3io4lD8vkDgPq8mKDObRZsUDb0SDjQ6ulNj/bI5/VKEw1F9GS9N/QLLFmKefQCm/uOd1wgDcb1bfaNCxrqRkOneuYIr3tfVYyserOBRyd99fAYVTggAxze3yYWw4A3tLtJ5PAroAD/ORD+bL3ap/V01XNyqdJoKFMaw7wmyjd1LrJKau4SYf8AJJJmjNZO4YXRKJzT36ZWiFb2Hgc7GPxjihLHH7QhMbZ0HoWN8wtM2GBFXyyW+GXxN61XIWI0wFIcfZBvPntQaa9FY5T1GuP7mCwAEG1MNHq/L69ceyaQkYzcvMHgaAlI1 jCst+SyT 2MB/9CVfLieSTCW/QNYaMehoQ9iCjpWCxdUGFUVzDA/HHZaHflBf4w8E4WnG3y9lX1+9pwu3A3+DuAbzWPFYSGSEzkv2RFM1QpS9POVoZ9O8U/1iSaBrasMDJe8W6gR4J5nxOm/OWvjegH3JSMi2F3vXdkGBzXtnPEZtI4Ho0RAqYOqwcO/XDneTn6adxKAIdkwBRA81N/qi81s3UaMut0bD2MxUQggIyMA7XyElnXvApFA2zCWkp5J53yLvrhg+qdyoeL1R1AHsz9rRnv7fTQNKQPbtd6GW44zyFBWz54jvlj8fFwmXTipy7dd4bwHO0YQGZri7fa/z6o6LLHxDQ7gRQq0GCL5KeKE41ViH8d4fHCDos5oyt/TllOXLmchFsBndYZBaEM/VQE/SgKd6g7hLIjnhJ28s6sOxI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/6/24 3:36 AM, Edward Liaw wrote: > thuge-gen defines MAP_HUGE_* macros that are provided by linux/mman.h > since 4.15. Removes the macros and includes linux/mman.h instead. > > Signed-off-by: Edward Liaw > --- > tools/testing/selftests/mm/thuge-gen.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftests/mm/thuge-gen.c > index ea7fd8fe2876..034635317935 100644 > --- a/tools/testing/selftests/mm/thuge-gen.c > +++ b/tools/testing/selftests/mm/thuge-gen.c > @@ -15,6 +15,7 @@ > > #define _GNU_SOURCE 1 > #include > +#include > #include > #include > #include > @@ -28,10 +29,6 @@ > #include "vm_util.h" > #include "../kselftest.h" > > -#define MAP_HUGE_2MB (21 << MAP_HUGE_SHIFT) > -#define MAP_HUGE_1GB (30 << MAP_HUGE_SHIFT) > -#define MAP_HUGE_SHIFT 26 > -#define MAP_HUGE_MASK 0x3f Totally makes sense. Reviewed-by: Muhammad Usama Anjum > #if !defined(MAP_HUGETLB) > #define MAP_HUGETLB 0x40000 > #endif -- BR, Muhammad Usama Anjum