From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C394EC7619A for ; Wed, 12 Apr 2023 12:31:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44F25900003; Wed, 12 Apr 2023 08:31:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FC79900002; Wed, 12 Apr 2023 08:31:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29D40900003; Wed, 12 Apr 2023 08:31:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 19DE5900002 for ; Wed, 12 Apr 2023 08:31:13 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B8ED616010E for ; Wed, 12 Apr 2023 12:31:12 +0000 (UTC) X-FDA: 80672673984.27.F8D849B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 75CCF1A0015 for ; Wed, 12 Apr 2023 12:31:09 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f7Iw8poO; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681302670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=blrnCpTcS5ZianZmqVUuhTTwLp6B2ozOa080drqpcNk=; b=Y6N4WOrvA/t/04uHKwNpsa2rIfDXDa+MhLFnbo8AiMZ8TU1w2NHSfNPO8a1YEePR7VRbIF QoVhAPmoJcyNkyRDNLxYQgrq2eC5WoJmrLziGjzOFlUeHntDx+ET+XkVNy3x/oFwRGTtaF 34oZbpZRPs6sOigDRWPzFy1W7VUf4ms= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f7Iw8poO; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681302670; a=rsa-sha256; cv=none; b=ct5K9EvLPDTWa8dIRErf5DFiwcqYCEr4j1EqWkufLIsB48TrkHUYbMAN8esMOnydRnIsAk M2GNjAhveJlDxaCX6Hj4XYNkXgA03ohaBsz8yIbfNCjvDoLdmLNhGP6+e6q939KcFYJYDU GeGQ2Mti+s0yh4a8VQ8sBUgfsvHSzV0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681302668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=blrnCpTcS5ZianZmqVUuhTTwLp6B2ozOa080drqpcNk=; b=f7Iw8poO5gt0UBv5D0pIBskkQSN2vz5y+DGW2LqqkNczY9ipU7X12uh+KKOD0VRZZvoF50 +yJ9RK2QeQbx82VBfEY7ZJvJcVsZ/xrwO7Zt9NRGsd5D609dIG50jgf0RcGHqdMgDIIxu0 lxpcM3FWwlMp7l2obvkjakIMFToNbz4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-4hlQygKNNAuBvAFp62nN4A-1; Wed, 12 Apr 2023 08:31:02 -0400 X-MC-Unique: 4hlQygKNNAuBvAFp62nN4A-1 Received: by mail-wr1-f70.google.com with SMTP id e25-20020adfa459000000b002cfe70737d2so1808721wra.1 for ; Wed, 12 Apr 2023 05:31:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681302660; x=1683894660; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=blrnCpTcS5ZianZmqVUuhTTwLp6B2ozOa080drqpcNk=; b=oGxs3pa679hV8RCbNnCWQBuDy3sWwOUqSrSqsPLlu90H5dTVTDXd7wbxFS4xg0FHJk 1rrUV91dajT5WzCNbBRWBN6wfexZk2LgFMqZMtQHdno95lm1H2ZZ+5JYSsDlZWpAKk4o mY3JXEHWLuOvOjRtb5uqkW5bb8RIhVOk4H2qOvcuLJ+AcF6n1PE2Pr1ciOVYQtcJGN1R dcgrhClUbOde2uuaBi7XDIoYSghnkimHgAeiTsVWMFVTX/C8KM/pjmoG8K8CA289pO6A EHSKgrP86MWJ2+TISIzIMrjz42tKoC2Lc2r3xskgQk1fxDxzE6NDZYzaw403Lg2L0nku Xd9Q== X-Gm-Message-State: AAQBX9dhyHB1M7zH6+CBGEMKOOOxRSAapmD6DU97sI0yWQjtawWG0Ks+ fHkPYgPpkiPRR+LmZmg9tIFV6CHxHnqPOVq97n2bhaCXox5alNPx5cngd+dPj/Jw39AFvZI0Gfr z7dBLPk3fl24= X-Received: by 2002:a7b:c389:0:b0:3ed:3268:5f35 with SMTP id s9-20020a7bc389000000b003ed32685f35mr1999658wmj.18.1681302660619; Wed, 12 Apr 2023 05:31:00 -0700 (PDT) X-Google-Smtp-Source: AKy350b4K/3OVCcip+JnxiMy5/dD33dZGeMKTqg1Z1LDfrRMSsp30yfO/Pr8lzVdPaorZJ0aIgTe/w== X-Received: by 2002:a7b:c389:0:b0:3ed:3268:5f35 with SMTP id s9-20020a7bc389000000b003ed32685f35mr1999645wmj.18.1681302660313; Wed, 12 Apr 2023 05:31:00 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4b00:c6fa:b613:dbdc:ab? (p200300cbc7024b00c6fab613dbdc00ab.dip0.t-ipconnect.de. [2003:cb:c702:4b00:c6fa:b613:dbdc:ab]) by smtp.gmail.com with ESMTPSA id n20-20020a05600c4f9400b003ed51cdb94csm2313468wmq.26.2023.04.12.05.30.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 05:30:59 -0700 (PDT) Message-ID: Date: Wed, 12 Apr 2023 14:30:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] mm: huge_memory: Replace obsolete memalign() with posix_memalign() To: Deming Wang , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230412104502.1836-1-wangdeming@inspur.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230412104502.1836-1-wangdeming@inspur.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: qm1gst7f7ju5xz17q5ckwjogt16hq77k X-Rspam-User: X-Rspamd-Queue-Id: 75CCF1A0015 X-Rspamd-Server: rspam06 X-HE-Tag: 1681302669-147917 X-HE-Meta: U2FsdGVkX1+gM1NCFaavvqU9EIdhF2/yVaWSZC91H2Kpkfk8czP6PyVnKk5dAUQH5E0bcTw5ei1drhrmoQL7cr5g72jeVjVpIVeSNvDRuTQg+sIvBBoHAWrCi9kw5+UBvXcCA6j7CslfHsFFC+5/ITtYTPav9sBKudq0VqjJB7DIz+pCNm+YD+H+o6qeB5VIp8wBBLopAG4mzmb/l/FqhMYg2a0koshRxNBZvPw1j5RvKYlwuiyNy/zr90B1HxUDwhkEHy3+MeL3CgQoKNAMmTrXP8K17nFbXqX6aIXMOA5oWybXD5KzFlHP8sQE5/oC7CQh8yiaVwtgA2zpRP+M1ND3g1Xx/gj2etDuwea2Vk0ru6/Sgk6SBpWk91gMwSejYHS34s14jEe/q+OiLD48NSBx+ycRMJ13eMuXqkTiucbpmTuxT7Yz0P4f7Vn+esn2B50CdeVZPuk/2hg8gklg9uVvN74xz3M66j8ZfB6pieMGlgCfe3kGIWPuMpokhjLyWh8QLyLF5ddvj+dDGapshHD+dPpB5O4WGcm/5SVy11TtViQeVm7k1/jlsRbSj0zmai3OaZbEeO14fRHgUxJu7v6x+dUZKuvXBhCLqaMwAxT180OtPAm4bs+b8sHdBFFlVSH1L/VPicSJI7RdKc0SA/iSA+R0tVY8vYQABtFGQZlh6V+ObUmITM1s/zaaRfuqNYMG9FeMXojKycEMtx+I9YCK1aic8n+WN6Oti2UfmbPBGc5TIyfzsMZty5z1iWQtlUltR5CY2Qinl9xSL39N00sr6PemCY9D9Blg9Fsu/4brrXTGyYKRuVVw0SHWi9bJUuSTRRhE+3IyFmaAMBZzzvPaMb4yT6snqI2H5e9qQaCy0X8GxMLXhPm7nWfO+IVsiERR1E7Xu8BDvZi9tAN71ZyBV3nzc745TSJ1X7z/Dq/BtC+hplIHoir9eOle/VlKv4NKdFLHBJzEBGoZi0a XSYDWF5W NFVyXoOsWCEBkqT+SzJM4JdcYjjxgOTc/wl+Jj3M//ksnAPKVN3rR26tUv6tgQZUpOSn7IniOQ+ojBl8fE1m5mkqqllQZhDH7IASpJTSRqvhaL98d7cAM0CxxFwLr09ovBJeFqIu5w708onx41DrBnJ+WLiepsQRQgPT1v7HA0SAFFfKfFVGxlj7XGYJgHmaq8Vmox7wgvkYw/JsbBsKDCz4MPQw9ag8Ey7myAwFv7Va56u8440kH+9xN6Nj+PdntV2U4YJZ6aA44D2StqlvuKKEMWcCRueZe8T4585rDCEdkgP6B7A2eaBdNrVDFFLpbNtlay5mEiygHJpMv0ITACR8L/jBdh0XnSijatALoroGzyAiAS1eRLXq8sZ8+GpRmn6SVLJ96H+087wfoWZodha+yNbNxPQe1cHnB8vQ597IYu5b4X5t5wzEYX3NtB/41Hj8kUWxBupxMEI80g5JIZrjFEnFaek4nRfd2aYRDgeoUemYKsYhHx/Cql8EGqaMNymGR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.04.23 12:45, Deming Wang wrote: > memalign() is obsolete according to its manpage. > > Replace memalign() with posix_memalign() > > As a pointer is passed into posix_memalign(), initialize *one_page > to NULL to silence a warning about the function's return value being Where is the initialization to NULL done below? > used as uninitialized (which is not valid anyway because the error > is properly checked before p is returned). "p" ? > > Signed-off-by: Deming Wang > --- > tools/testing/selftests/mm/split_huge_page_test.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c > index cbb5e6893cbf..94c7dffc4d7d 100644 > --- a/tools/testing/selftests/mm/split_huge_page_test.c > +++ b/tools/testing/selftests/mm/split_huge_page_test.c > @@ -96,10 +96,10 @@ void split_pmd_thp(void) > char *one_page; > size_t len = 4 * pmd_pagesize; > size_t i; > + int ret; > > - one_page = memalign(pmd_pagesize, len); > - > - if (!one_page) { > + ret = posix_memalign((void **)&one_page, pmd_pagesize, len); > + if (ret < 0) { > printf("Fail to allocate memory\n"); > exit(EXIT_FAILURE); > } -- Thanks, David / dhildenb