From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DEEDC28B20 for ; Sun, 30 Mar 2025 19:48:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64396280004; Sun, 30 Mar 2025 15:48:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F63A280001; Sun, 30 Mar 2025 15:48:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BB01280004; Sun, 30 Mar 2025 15:48:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2C48C280001 for ; Sun, 30 Mar 2025 15:48:03 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1938DBAADB for ; Sun, 30 Mar 2025 19:48:04 +0000 (UTC) X-FDA: 83279253288.15.B82F4DB Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf15.hostedemail.com (Postfix) with ESMTP id D00D7A0008 for ; Sun, 30 Mar 2025 19:48:00 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b="KhAHzr/p"; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf15.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743364082; a=rsa-sha256; cv=none; b=sJ0Q2mHqa647r8v+jGf+WdxSv+RA0nsTD5bjw4DN9/cxDVcKEnLUC7I/K8ZcJ9Zw2sx8nS BlHz+hPUZ52/ZQh7baG2q6zzSR3jhOGMecidWgcWZULltNRz4R7mjYf1VK6b7rWB8N/9aL BEjNphij2n4ShWBD+48MDpf3sO7IlNA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b="KhAHzr/p"; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf15.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743364082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hDzgxzm6+nnwBoWRdISKTCyqXH05hjRnwQePjY0a93Y=; b=Ux309zObFhN/ELNaLSCTXc1Em70VZ174d9C4yFf8BojPl/wG7V+XCsIpuAEDnHSnMUhBGa QW1FQcwCC0j2aMrU6DbR/MA4hBuuewQAciZ5veYRAc97eMEMRRrobKIGl876K0b6VePER0 coDIMa+9opI/DhUOPhMsDX/Cw0i0Xxk= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1743364077; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=hDzgxzm6+nnwBoWRdISKTCyqXH05hjRnwQePjY0a93Y=; b=KhAHzr/pzHui8uLn4cnM0cfnMY70aNTw1YTVfspQi9vSZA9Xi1H2ZKbqTbRZRhcOsJDgP8f20LH0gaHFb/vmpJBEe3cbkiowcUmHaGqBEAj1hlbXxMlXVsfE3OdE4XRDwSSTqrq1NI0DhQzsy6ehYxPWP/3RxEtOdkA3+TSjE/A= Received: from 30.58.211.89(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WTNbr6D_1743364070 cluster:ay36) by smtp.aliyun-inc.com; Mon, 31 Mar 2025 03:47:55 +0800 Message-ID: Date: Sun, 30 Mar 2025 20:47:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] selftests: mincore: fix tmpfs mincore test failure To: Zi Yan Cc: akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, david@redhat.com, 21cnbao@gmail.com, ryan.roberts@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <99a3e190d38b08a2b96ede952a29893bffdb3432.1742960003.git.baolin.wang@linux.alibaba.com> <992DD536-7047-4C2C-97EB-7F23100143E3@nvidia.com> From: Baolin Wang In-Reply-To: <992DD536-7047-4C2C-97EB-7F23100143E3@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D00D7A0008 X-Stat-Signature: pmzq6nw5swjmouforu11t8eq9fxofx3d X-Rspam-User: X-HE-Tag: 1743364080-680575 X-HE-Meta: U2FsdGVkX1+FMBcsdOxSG7hObk74zszg6ibx2Gy+1eAIvg3XDEnxYEqu9c5Z6ZX7f6CPQOT3DGj5aZOtLh56RYaa+BuhvrMTt2vPo4ByVaizU3POmM4DqCtKf7qygAS+6FOgTRoAl6es4xlBJjYhf+EdHG9YoLPa0Rwd7apAbfTo70yliqbBVl8aAYrDggauFBUup8wGeZvxPgdqFoNi/xZI5ZZycwQfqkp6rOvVocaXzze0S7Ipz2Iy+koBfUY5fVIs0V/rGfkr39Rdk/Tsxvg6uMw8W791/j/6KEUFApccGhFGy7/HheES0zp6dBPXPQqXBltVhdYA4n8nrdqyMq71ChzVunH4HCMnVjk5s2xq0qOZ0SWXilaKZ4RKcAcq0vswXVBR+15aUKuHmL/65gH9J8pYyglqibKdbNeWT0OmbonaaAPB47Q7zOVrMa0/m6AW6YAiw96Sf5HAD1j5JOQ8747F/b9/mXvPuEwKp8yJeSfLhNu8OIFGDpRaqTCb+kbNSf8ZJANE9NpTWb+HxETIx+02HANMCT9DNyFoeRM6Gwww/lSxdoP2jag1wPwkMZwRmylCyoo0viPvSy8PG0btZAjaF2UgBugtLARlBneXQqWmbGWz7S3Q7H3XquaJojSSfe7Iu0TOe0EO8vYNOvKb4Ie9dgb28J4VAnOkpENZF3uQSVCXpkSEeJD2q1lOKULEYKBITu31BHHMV3v3CId3c5dDQkfIyAqQVP+6dXZikfFIBOkDuEEWeP9nMGKFwnW+eC2EVxKsmHo4pXYkRs4kgjyAqaSGsyGg1T8wPGD0+xJH5i8gV7a3v0W9b6Acfrxkh20ISNRzZw+UP94DIw1D2HYBG+goCV90BssUCTQIzSo1wS5FQI9Umx6eiiFnPRf5b2hQGJmhTDiXKU9RxfiZMiLRc7PErXGTF69K/n0PQ6EGXTrfJp7/KIlKo1SCbC0NNebLAQsBAQiQ4/E uDMn10s7 Zdp0eyLhH9Z/nG/QA/kIvT7NLbW8P8SmRmd8Lf+NHEgGn/AE1u5idK3MOXBxVQwg5iWzxrW/BVZgWhdPTh8qJTeE4UQ5ZC83212XnN8uPcLIMLcd2S4mT4MjKW9wt5RRil+wsOXNbadoKsYQJ1HsCYxqR4RM/GY2ae+ZDmKBOIKANCdeuHDV96Ls1nVuC7zBmiWHt3DUf20Yfjj0gUaxjabSnrvvAvDJr4YSBoeWx6nx9FrfFsdrr7izUv7pyLB6nCJ4wKkaCuYqwTSlQEj/fa4dyfsZX/dOynKoNnubKuZh2yUA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/3/27 22:36, Zi Yan wrote: > On 25 Mar 2025, at 23:38, Baolin Wang wrote: > >> When running mincore test cases, I encountered the following failures: >> >> " >> mincore_selftest.c:359:check_tmpfs_mmap:Expected ra_pages (511) == 0 (0) >> mincore_selftest.c:360:check_tmpfs_mmap:Read-ahead pages found in memory >> check_tmpfs_mmap: Test terminated by assertion >> FAIL global.check_tmpfs_mmap >> not ok 5 global.check_tmpfs_mmap >> FAILED: 4 / 5 tests passed >> " >> >> The reason for the test case failure is that my system automatically enabled >> tmpfs large folio allocation by adding the 'transparent_hugepage_tmpfs=always' >> cmdline. However, the test case still expects the tmpfs mounted on /dev/shm to >> allocate small folios, which leads to assertion failures when verifying readahead >> pages. >> >> To fix this issue, remount tmpfs to a new test directory and set the 'huge=never' >> parameter to avoid allocating large folios, which can pass the test. >> >> Signed-off-by: Baolin Wang >> --- >> .../selftests/mincore/mincore_selftest.c | 25 +++++++++++++++++-- >> 1 file changed, 23 insertions(+), 2 deletions(-) >> > > > >> >> errno = 0; >> - fd = open("/dev/shm", O_TMPFILE | O_RDWR, 0600); >> + /* Do not use large folios for tmpfs mincore testing */ >> + retval = mount("tmpfs", tmpfs_loc, "tmpfs", 0, "huge=never,size=4M"); >> + ASSERT_EQ(0, retval) { >> + TH_LOG("Unable to mount tmpfs for testing\n"); >> + } >> + >> + retval = snprintf(testfile, INPUT_MAX, "%s/test_file", tmpfs_loc); >> + ASSERT_GE(INPUT_MAX, retval) { >> + TH_LOG("Unable to create a tmpfs for testing\n"); >> + } >> + >> + fd = open(testfile, O_CREAT|O_RDWR, 0664); > > The fd permission is changed from 0600 to 0664, but it probably does not > matter. It is just a temp file, so it doesn't matter. > >> ASSERT_NE(-1, fd) { >> TH_LOG("Can't create temporary file: %s", >> strerror(errno)); >> @@ -363,6 +382,8 @@ TEST(check_tmpfs_mmap) >> munmap(addr, FILE_SIZE); >> close(fd); >> free(vec); >> + umount(tmpfs_loc); >> + rmdir(tmpfs_loc); >> } >> >> TEST_HARNESS_MAIN >> -- >> 2.43.5 > > Otherwise, LGTM. Reviewed-by: Zi Yan Thanks for reviewing.