From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7AFEC3601E for ; Sun, 13 Apr 2025 20:03:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E68282800F9; Sun, 13 Apr 2025 16:03:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEEAC2800F7; Sun, 13 Apr 2025 16:03:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C43422800F9; Sun, 13 Apr 2025 16:03:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A1F942800F7 for ; Sun, 13 Apr 2025 16:03:03 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AD238140FA0 for ; Sun, 13 Apr 2025 20:03:03 +0000 (UTC) X-FDA: 83330094246.15.F0B3FD1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 50BFF1C0007 for ; Sun, 13 Apr 2025 20:03:01 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="VX/00LAU"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744574581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=63ad4fTCOD0p5TrFn4wdTZ3MlAv2F5Vw3+XL7aN8auY=; b=KD/qq1I1yZQc2Inxco/iPpNuT/pupSfraXT4issuUY1YM8PtnfHLTqDBo1znWYXcNdzzmr MUsd/Qfv77gdyhCpWNN2c72iQQXztgf2VQ87hnJD5S6z+s823vFIs+ZjMvpPmHYNiVaKR1 YObA2v/5kuYSCp9qNi5KwuDCuww/a8k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744574581; a=rsa-sha256; cv=none; b=ble+4bKztmEOrzip8b4JdK2cWMVWUclvOc+dCw/P2hXvlLvEIiK1PazGJfH9yy1MKVp6Ny 8fYiktyk/hYDo+AknXOVRdQGExekehT9Feequd7p9h5m4Kk5UbSChvWLqKzdd4YO41rZEP EQ9HNf33TklY3YtQpcs+5Nl2XFjZEdY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="VX/00LAU"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744574580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=63ad4fTCOD0p5TrFn4wdTZ3MlAv2F5Vw3+XL7aN8auY=; b=VX/00LAUQfE2ePetZWpL5X7XnPFrV0Zb3j4zjrlZU85wh93lKxpJ63UqN4GIbtSd8E1nHf 9r2xpTI9SI5MqgBhc6RHCGV75iNak+pwrYubLJwlSMsW8MbEba+taxK61fX1jWQzvwSgnS S7APugcLr2uQkrmuwAo87Lsj+ewIELQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-al1H-1-2OKqz3viOcZyA2g-1; Sun, 13 Apr 2025 16:02:59 -0400 X-MC-Unique: al1H-1-2OKqz3viOcZyA2g-1 X-Mimecast-MFC-AGG-ID: al1H-1-2OKqz3viOcZyA2g_1744574578 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-39ac9b0cb6aso2239030f8f.2 for ; Sun, 13 Apr 2025 13:02:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744574578; x=1745179378; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=63ad4fTCOD0p5TrFn4wdTZ3MlAv2F5Vw3+XL7aN8auY=; b=Mf8OGQZfPQioMVnNUo12o8lEXbRX+/Ih9aPRj5+79nxEdQ7cSnMOGClKw729aTUkmK XzuNfDqQH1K9szxoHF9dxNgnrSmJy6U9GUBwzUUZhRvMICPXrpzPFF5xtyUxn+Ovwz4L 3ipWftJLyzJ4vEgn3cLUKoKXg/QdCKP7RY+57AQBO4aUSw9wo+xHw6rykofzeZbVK5v0 p/fUtmDiBhIn0ij0K1gpI47WF4rQz0opbDj+vpf9bLNHakNT0PVI+/LeXZ64/zr0K8Li zOXXYkLrAt0bxNhhM9TPUKw3TZTX+UnW1Ht9MJRYjX90srgj5z7VwuDAvZkgb+IBMxcs R0ew== X-Gm-Message-State: AOJu0YzB2wmLMDzfCF1Q4MsJVfZtdlAZc19hNzgQhVCKFnj+e5o6JXQH 1vmGCErRqozVoBCrBRFjrkdZoLMvcFhHMgiLkGx4JqhQPONo+Jioz46HixmZNnmaAUQKLDhNwCa iQ69dy2Wlz9jco24EkZ/jnsTttLM1gMiCNRgkiojc+WcdzmVz X-Gm-Gg: ASbGncsvbAtV8bfzTY1g+FeJFf0lmahkGKCdPXDnZ66m//9qU5lXyHEjD1g5ECPUM5H hgs8Sw8h3AJZOUTMoTdBQ29GGUVfndNwBDS6Uh2IcBELloOjPEEGk85OeVRbADeRaEyzmVKqkuo cx1NuyXWiZrpDqn8Rf2LXw3RIBGvsDmtJ+u1QmwQwoeUPvPnLOYVqWDazuwB3zSTPtOp+B55+yi OBjGCwyGoUcMGlLdKD6MJEqg7W4NA2NiiF4FRawV7YYBNOQU/AOkeNoIMGLztXMCiK3QbnQRx9i OrywqOfftfKHvRwUBXjMolJO3Qc06VLEA7zG+YSgYXx34bj8ZK838uFD4LsEyHhm13T2pFu0UZ8 UVLfh7ivlsVN9zlzKiSUUg1Up2cmZ9uxEyMOdefQ= X-Received: by 2002:a05:6000:18a2:b0:39c:1258:7e18 with SMTP id ffacd0b85a97d-39eaaec7d0amr7425614f8f.57.1744574577631; Sun, 13 Apr 2025 13:02:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFC6elm7Oi5iDPiKnsLQ1d73dgjttu042978TXC+X8rsZnB7bNdTTMjBo07JiI9gRom78QS4g== X-Received: by 2002:a05:6000:18a2:b0:39c:1258:7e18 with SMTP id ffacd0b85a97d-39eaaec7d0amr7425603f8f.57.1744574577225; Sun, 13 Apr 2025 13:02:57 -0700 (PDT) Received: from ?IPV6:2003:d8:2f02:2900:f54f:bad7:c5f4:9404? (p200300d82f022900f54fbad7c5f49404.dip0.t-ipconnect.de. [2003:d8:2f02:2900:f54f:bad7:c5f4:9404]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eae96c684sm8891758f8f.33.2025.04.13.13.02.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Apr 2025 13:02:56 -0700 (PDT) Message-ID: Date: Sun, 13 Apr 2025 22:02:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/4] mm/gup: clean up codes in fault_in_xxx() functions To: Baoquan He Cc: linux-mm@kvack.org, akpm@linux-foundation.org, osalvador@suse.de, yanjun.zhu@linux.dev, linux-kernel@vger.kernel.org References: <20250410035717.473207-1-bhe@redhat.com> <20250410035717.473207-5-bhe@redhat.com> <332ce477-59f6-47f9-9687-10b642b86230@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aP-NgcDG5SQgQKlIHVlS6nbrnTOUSmySVE62yPAjrsc_1744574578 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 50BFF1C0007 X-Stat-Signature: 4febx7or18rrecbyyzamb9xqexgmz1q5 X-Rspam-User: X-HE-Tag: 1744574581-190292 X-HE-Meta: U2FsdGVkX1/UTsz0qmjPMy9YQJ/WFeNTZ121g5MH5yOlJ5LyEjnQ+r3pa4z1umguxLyEJ6OmlfInhk5bnweKvbboDYgwTsCsHAq1jflP/42cekwsTXtIwnHOBr7k4Fymj8zaCg1m4obUO0xKGBchEn7XJKS/V9UQ16l0piI23qhyA39TuSqQIpFAklty9lRTUQR3OlxD31LX1nGnrnGr4ZC0GbMW1aVq5gdNJMCS5837LtMq6LhAACUaYtM+b64lW9E2QLls4bjTNV3Bqnn2uvt4YZdGj2yHdf2UaIy8IPH2pNJUDFlxS/plY4caCt6RmohSbZ2W6ktswxZnwxLIB2BrSkHLPNhsRuVMbiGGod5JdX0D46EbuN92q4K43YNDDCl8RhBf0Vy8uNPfrwbyR33l85gN2TdEKjN3kpur1dueEmlSLpinSHVfkOgHfPPXNLlMBdAZx3GHyqUSzZD+aylLSumzRf1cQQq2HeGomGiUBzQoUKLg/k0wNZNTv0ESoiAvTrd/eYYwALjUC6Y6kSd5/roqltgXmnJgS4BpT1QbR9xoiWEjL+b7aGMw1xww22fWsUZXBqsLh9sNGdCvPNMpaKKSTZbDArfRiQ4E9A+lWf5rnXdZF+tmNzb73rU6TgFGmp97I1IQFfcHRkoCMju4chmKX0esp5Ox1v9/Cjx32AroCDBAN/FU1w2wOibIOorHWO2SC7Y2FPCsRFPN46OPpG/J4rl2kjmU7hFx00Xd+QEgGNvm9xlHEi7ZFHd9V5ep+a/hgikKtyFWmZ5rPvC6xiwsTIspToHyXQEPBWomj3xJUw9kzzgsUmuCBByMw6nPEeXvNjwR6rYl/ieFJqcPXUCO5ilL3e9Oqte8l80AVRFkWUcjHmyJeMyGJLn22vRI4EMO1SBRgElIqqyEe3vNm9lRNB9ubk1FF0gwCzvKJg/fu5/OIT3wfp+YKbGHEF3O5R3GOZd9eFdJMln TxMt9lrO 4r+zvrmFcGckohFdCD/+08LhVNcFdM5IgW0tSuT6+fe5naqOTsvK0HBQ1Gjv7ZFWFsYB5O34gE68wempsEsw24XE0WwwYl6jLQZ4nivsms3hSb/ZAWy6HazzpzF7t59frWhJwSy7zQI48A96KJdRhrdrrJHSR/74Xq6l9J2nofuNo8ihPzZIkJW6vlQCSd9JR+U1PZsEZJjRkdMbixGN+wbRfNIyZqHVN/bWvKzb8kjb0ZYYzBbd5SY4FdScCTRLDyiqjvo+Eek5TU49e5PjIy1G8lji5BjY5HygpT9kl0McNjFgCVunZxo6KrkbXxq1fVtL3r/bJwkPHsdXwxBLdhG2jkA2f6dzeBXm8e0PAYo1k9vzpvHklO1JDND+wIkDxX/wydlqNPob0+KKPXYlKEajKDVXfvH9XQa4M34fZdfXcORlBTGcTs1NuUvx6wu/xgfPQdxDICYp1pL3hg6y/dWXenA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.04.25 03:07, Baoquan He wrote: > On 04/11/25 at 01:41pm, David Hildenbrand wrote: >> On 11.04.25 13:15, Baoquan He wrote: >>> On 04/11/25 at 10:54am, David Hildenbrand wrote: >>>> On 10.04.25 05:57, Baoquan He wrote: >>>>> The code style in fault_in_readable() and fault_in_writable() is a >>>>> little inconsistent with fault_in_safe_writeable(). In fault_in_readable() >>>>> and fault_in_writable(), it uses 'uaddr' passed in as loop cursor. While >>>>> in fault_in_safe_writeable(), local variable 'start' is used as loop >>>>> cursor. This may mislead people when reading code or making change in >>>>> these codes. >>>>> >>>>> Here define explicit loop cursor and use for loop to simplify codes in >>>>> these three functions. These cleanup can make them be consistent in >>>>> code style and improve readability. >>>>> >>>>> Signed-off-by: Baoquan He >>>>> --- >>>>> mm/gup.c | 65 +++++++++++++++++++++++--------------------------------- >>>>> 1 file changed, 26 insertions(+), 39 deletions(-) >>>>> >>>>> diff --git a/mm/gup.c b/mm/gup.c >>>>> index 77a5bc622567..a76bd7e90a71 100644 >>>>> --- a/mm/gup.c >>>>> +++ b/mm/gup.c >>>>> @@ -2113,28 +2113,24 @@ static long __get_user_pages_locked(struct mm_struct *mm, unsigned long start, >>>>> */ >>>>> size_t fault_in_writeable(char __user *uaddr, size_t size) >>>>> { >>>>> - char __user *start = uaddr, *end; >>>>> + const unsigned long start = (unsigned long)uaddr; >>>>> + const unsigned long end = start + size; >>>>> + unsigned long cur = start; >>>> >>>> I would initialize cur in the for loop header, makes the loop easier to >>>> read. >>> >>> Both is fine to me. It's to satisfy checkpatch.sh which complains about >>> exceeding 80 char in the line. >> >> Did checkpatch.sh actually complain? You might be happy to learn that the >> new limit is 100. :) > > That's great to know. I never noticed this and always wrap via vim's > indication. Note that coding style says: " The preferred limit on the length of a single line is 80 columns. Statements longer than 80 columns should be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information. " So 80 is still recommended, but there is nothing wrong about exceeding 80 if there is good reason. -- Cheers, David / dhildenb