From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D2D1F0182A for ; Fri, 6 Mar 2026 11:43:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDAD66B008A; Fri, 6 Mar 2026 06:43:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C9C1E6B008C; Fri, 6 Mar 2026 06:43:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA7D06B0093; Fri, 6 Mar 2026 06:43:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A8E896B008A for ; Fri, 6 Mar 2026 06:43:38 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 784AD16054A for ; Fri, 6 Mar 2026 11:43:38 +0000 (UTC) X-FDA: 84515453316.26.C220BF8 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf18.hostedemail.com (Postfix) with ESMTP id E5E491C000A for ; Fri, 6 Mar 2026 11:43:36 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AoTL4X7f; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of ljs@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=ljs@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1772797417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3xfiT735TcU8/K9g/c1W8MgWJHA/YY1WqLFZxp9RB/Q=; b=geJIwkHWUVtYZIPwhVtBu+g8JX7E2p+GaUkXdYhmOmYIOu7z4iizYAUm7gkZsbXgiQohS3 idc5jy0Nwx/yItjkVhXUpuvtQ7R3bFbJO3su0jq7Fr14fUQFlvLAN77tS1K6IykNBGcKfP Yjzd5F4dtqtzjZgfSeOL6tFoHEsCCI0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1772797417; a=rsa-sha256; cv=none; b=SlrA4FQC2SBIq62ifraipEm4OOGKRQsLrjO5lbzMW6bOcNaf6Lho0rUSGz6dzUe578Qd/6 7I9KbitX2KvKO4Qc3TXDiiMK6yCz6SdUR+6ml4+zz/NtxXrwmAPrQqTEZzQYwsD0/fHk0K p6cy0L80wVLG4JwkzC/kwauDMKQ+uKM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AoTL4X7f; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of ljs@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=ljs@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id ACAE1437E7; Fri, 6 Mar 2026 11:43:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB45CC4CEF7; Fri, 6 Mar 2026 11:43:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772797415; bh=GowoyTsR4CI3ewxQ0f2lHFy7dHsKMkcXOPtOrZuLkR8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AoTL4X7fkCCo0RpTHoieQY0AotRrEjVyuQ02wvcgh1owSajcJbmcQEtWizAtCSsK/ X+mc0JnVWTe165uGDV9E7WpAYYzGMULmVtno4EZukM7QoACh09oHoPUhdwygslZKvl UA8JGFtIK2G8zIIAmjqKqpT+tyil+49Wti7f3MPsrXYEUnfS45na2IEnXoSRELDO6M ZL6z80bBwk4W9VVHCHJBf7g9N26hSrTQ1VOPLG5slPyq9X33Zeti35mCcJQiMAS9Er ddlmGUcS+LRPdDZ43n2TXxhXjJ5UL+qfVn18k94Sk3SHS399+2vt6KziT54vb18xV4 c6KUFHbeprQ4w== Date: Fri, 6 Mar 2026 11:43:32 +0000 From: "Lorenzo Stoakes (Oracle)" To: Tal Zussman Cc: David Howells , Marc Dionne , Jaegeuk Kim , Chao Yu , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Matthew Wilcox , Dan Williams , Jan Kara , Alexander Viro , Christian Brauner , Theodore Ts'o , Andreas Dilger , Paulo Alcantara , Trond Myklebust , Anna Schumaker , Mark Fasheh , Joel Becker , Joseph Qi , Steve French , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Chris Mason , David Sterba , Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko , Andreas Gruenbacher , Muchun Song , Oscar Salvador , Ryusuke Konishi , "Darrick J. Wong" , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Jason Gunthorpe , John Hubbard , Peter Xu , Johannes Weiner , Roman Gushchin , Shakeel Butt , Jann Horn , Pedro Falcato , Brendan Jackman , Zi Yan , Hugh Dickins , Baolin Wang , Axel Rasmussen , Yuanchu Xie , Wei Xu , Qi Zheng , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-ext4@vger.kernel.org, netfs@lists.linux.dev, linux-nfs@vger.kernel.org, ocfs2-devel@lists.linux.dev, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, gfs2@lists.linux.dev, linux-nilfs@vger.kernel.org, linux-xfs@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v2 2/4] fs: Remove unncessary pagevec.h includes Message-ID: References: <20260225-pagevec_cleanup-v2-0-716868cc2d11@columbia.edu> <20260225-pagevec_cleanup-v2-2-716868cc2d11@columbia.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260225-pagevec_cleanup-v2-2-716868cc2d11@columbia.edu> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E5E491C000A X-Stat-Signature: kd8nk9rnd9cxy9d9aqyiwbp6zwozda7z X-Rspam-User: X-HE-Tag: 1772797416-194405 X-HE-Meta: U2FsdGVkX1+JH1vQeFvoTsRM0IIOGEDtWavW7FQ4tll16/nYd/ZTX8Z0rlidUn2HIi43biD9A5m0micCIUWxtu0O7GT4Pzkct7J7vNsiuCEviMyS905jaQF0Zy2rL3c5pNIHocMMUVsmHHpUj208di4roUbK/GzHZbZ6k5yYxy8BCWjTSdignmrim+sw0NHVKaJuz/TuwAV48hiAIDTzOgtTWJ+H7kjnWaElsLWRkNYhbdkJavWHvtL2ULMeDWptZLT7cXaUz9nFG16MUHUhbHe3d7K0VJcmvFuGjTdfsHwBKlzyvXXVergNZHLSXSgharEfSLEa9DRLLMgmdvSkaIGbpIFM1G7GDqSEN+5pXCBGMjQNvmyv7bhYnUm4R9DQqzzIQA0A1oynlXVfwDsk4OfWvVWrCBJ58R7s4wxzk6o5jN6Z8fiYSyzSD5IuecyKWbb7rlPReQXk1L/2i+mSoHx2Ft+QS+17hz0MdFIFnsrcILdVAOLl9Z6wG52e9jc1WGKB4Woe94C0i/b3bs2KBX2Wa+Nu50DfA/V/wbb6APsAad211J8A1g4UspH/R7G1kEpjvKpiawm+zt2cDeHGLoXUY+RIWlQYzCgj7qmerVzkkd7IO5GeEF8UXKBIhZ45s3UToSlm6Qzf8kdmKdGKM3obOcpI4ZFGH9ktd0sLQEQnfvpWfSsi4ycraO328i47XHi+/jNzn+FArJeUqRPnnQGh4MOOJV134vFlosK273X97TJPIZ0BuB4I/SXYeTpC1H5f+nutzFMryDCIyx27e3xq7HnJHeFfO+g402UmXwtEFzZOYewcSbCmGK9MkqXyEMaYDcLFAi5HvapZ5Fd2fSPq8cY+mxFpOQXCBDMNGwmOm5NTvSKY8UQBttBpjBHXUF+27T5Cnb4PQaQbiU8u/oiunZ6VCncyKrsoDjDPsHyFKi/ukiF53CzuMYEHjLOgXZL8T1ZoJu+x2KBzPBR Is35YUaK p8somn/b7u1h4b1a1VfW7cki+ig== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 25, 2026 at 06:44:26PM -0500, Tal Zussman wrote: > Remove unused pagevec.h includes from .c files. These were found with > the following command: > > grep -rl '#include.*pagevec\.h' --include='*.c' | while read f; do > grep -qE 'PAGEVEC_SIZE|folio_batch' "$f" || echo "$f" > done > > There are probably more removal candidates in .h files, but those are > more complex to analyze. > > Signed-off-by: Tal Zussman Nice, LGTM so: Reviewed-by: Lorenzo Stoakes (Oracle) > --- > fs/afs/write.c | 1 - > fs/dax.c | 1 - > fs/ext4/file.c | 1 - > fs/ext4/page-io.c | 1 - > fs/ext4/readpage.c | 1 - > fs/f2fs/file.c | 1 - > fs/mpage.c | 1 - > fs/netfs/buffered_write.c | 1 - > fs/nfs/blocklayout/blocklayout.c | 1 - > fs/nfs/dir.c | 1 - > fs/ocfs2/refcounttree.c | 1 - > fs/smb/client/connect.c | 1 - > fs/smb/client/file.c | 1 - > 13 files changed, 13 deletions(-) > > diff --git a/fs/afs/write.c b/fs/afs/write.c > index 93ad86ff3345..fcfed9d24e0a 100644 > --- a/fs/afs/write.c > +++ b/fs/afs/write.c > @@ -10,7 +10,6 @@ > #include > #include > #include > -#include > #include > #include > #include "internal.h" > diff --git a/fs/dax.c b/fs/dax.c > index b78cff9c91b3..a5237169b467 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -15,7 +15,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/fs/ext4/file.c b/fs/ext4/file.c > index f1dc5ce791a7..5e02f6cf653e 100644 > --- a/fs/ext4/file.c > +++ b/fs/ext4/file.c > @@ -27,7 +27,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c > index a8c95eee91b7..98da200d11c8 100644 > --- a/fs/ext4/page-io.c > +++ b/fs/ext4/page-io.c > @@ -16,7 +16,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c > index 830f3b8a321f..3c7aabde719c 100644 > --- a/fs/ext4/readpage.c > +++ b/fs/ext4/readpage.c > @@ -43,7 +43,6 @@ > #include > #include > #include > -#include > > #include "ext4.h" > #include > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index c8a2f17a8f11..c6b6a1465d08 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/fs/mpage.c b/fs/mpage.c > index 7dae5afc2b9e..e5285fbfcf09 100644 > --- a/fs/mpage.c > +++ b/fs/mpage.c > @@ -28,7 +28,6 @@ > #include > #include > #include > -#include > #include "internal.h" > > /* > diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c > index 22a4d61631c9..05ea5b0cc0e8 100644 > --- a/fs/netfs/buffered_write.c > +++ b/fs/netfs/buffered_write.c > @@ -10,7 +10,6 @@ > #include > #include > #include > -#include > #include "internal.h" > > static void __netfs_set_group(struct folio *folio, struct netfs_group *netfs_group) > diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c > index cb0a645aeb50..11f9f69cde61 100644 > --- a/fs/nfs/blocklayout/blocklayout.c > +++ b/fs/nfs/blocklayout/blocklayout.c > @@ -36,7 +36,6 @@ > #include > #include /* struct bio */ > #include > -#include > > #include "../pnfs.h" > #include "../nfs4session.h" > diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c > index 2402f57c8e7d..0d276441206b 100644 > --- a/fs/nfs/dir.c > +++ b/fs/nfs/dir.c > @@ -32,7 +32,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c > index c1cdececdfa4..b4acd081bbc4 100644 > --- a/fs/ocfs2/refcounttree.c > +++ b/fs/ocfs2/refcounttree.c > @@ -31,7 +31,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c > index 33dfe116ca52..9e57812b7b95 100644 > --- a/fs/smb/client/connect.c > +++ b/fs/smb/client/connect.c > @@ -20,7 +20,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c > index 18f31d4eb98d..853ce1817810 100644 > --- a/fs/smb/client/file.c > +++ b/fs/smb/client/file.c > @@ -15,7 +15,6 @@ > #include > #include > #include > -#include > #include > #include > #include > > -- > 2.39.5 >