From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB004E77188 for ; Mon, 13 Jan 2025 03:29:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F1FB6B0089; Sun, 12 Jan 2025 22:29:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A1976B008A; Sun, 12 Jan 2025 22:29:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26A736B008C; Sun, 12 Jan 2025 22:29:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 08C416B0089 for ; Sun, 12 Jan 2025 22:29:29 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A7BBF120800 for ; Mon, 13 Jan 2025 03:29:28 +0000 (UTC) X-FDA: 83000998416.23.6E2DDFE Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf10.hostedemail.com (Postfix) with ESMTP id DC961C0003 for ; Mon, 13 Jan 2025 03:29:25 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736738967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2rHZlrPOLeNWvOf+vqacZRHTfV3VPZKLdTp/KNEqbEQ=; b=TnwjVqdGgoS2vOIhfVHxsKj940i/0+zjABXjRB8Fuiv1RmepSyzilkE6lKFkcnqzjoXzId Vo4DNaAxfOTXRfv2wYdutpof5pzYOuRpOjfXFeM8m5sm0+qrM8pS5C9idHLmpUqGw0Cak6 y8izLPdbU53/tbk3vK8HF7qDBz5QZTw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736738967; a=rsa-sha256; cv=none; b=Ne5xu8og74ghgwCpmY4pFvUn8NeD+7QOtMJ2/jiTEFOlHMYF25DTEOhUVxexqh4xmlqDVd Exli0FAqjnSE0O8c3AQL2I0Z7oMHBvcH9EwIwDAr7ltVPTktMZNoCa4AGTX6L+DZpRxyx+ xr1ycMRAx9bHsTyfWwrGACQ1bPREzRU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4YWd1p07gjz1W44j; Mon, 13 Jan 2025 11:25:34 +0800 (CST) Received: from kwepemo500009.china.huawei.com (unknown [7.202.194.199]) by mail.maildlp.com (Postfix) with ESMTPS id D7951180087; Mon, 13 Jan 2025 11:29:21 +0800 (CST) Received: from [10.67.111.104] (10.67.111.104) by kwepemo500009.china.huawei.com (7.202.194.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 13 Jan 2025 11:29:18 +0800 Message-ID: Date: Mon, 13 Jan 2025 11:29:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hugetlbfs: check dir in trace_hugetlbfs_alloc_inode To: zhuxiaohui , , , , , , CC: Xiaohui Zhu References: <20250113030702.58502-1-zhuxiaohui.400@bytedance.com> Content-Language: en-US From: Hongbo Li In-Reply-To: <20250113030702.58502-1-zhuxiaohui.400@bytedance.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.104] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemo500009.china.huawei.com (7.202.194.199) X-Stat-Signature: 79zihb5u8uhh7ypop99y36uwtxiqkdg5 X-Rspamd-Queue-Id: DC961C0003 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736738965-652269 X-HE-Meta: U2FsdGVkX19rC7UfWCCDS2tz0YB9ClNW14OnLMmkoYX78Sdu1Kgk3RVcQBfL++b0c6Zuwt1quQwW1l9kSkbLDKg4UlAU1/rzmv7OERCRLwM2qhQV2mWQqUX19rAUWz+GyA5G/POjgVcHoXEqLksRK4ZjW2V8ukRRrgHfIOiTkWoJW9tVStPaREyUnb/AU0OlFN8ZutlVmeFBYFBBrL4vjksTbCIfaXai3FzHe1qeqXNzHFDk+q4Kij/LdykEQD1038HgL7Y0UCc0sLJG6xzWMTKBbl2CR6WITfoTTxbToaYpdMPDUl+H6hGKC2MBgB1YwWVhfssZGmhSkCj8gQ3jnACTIGlrhgsH/PGeJKrGt/qhkyPo45OINdsgh7thDGfBgySkAlHgyzIwBySAQNb20YvgMNkqa7JfgYQ6mDRKZ2/cnnTxKFUBVQ4+ZhmC6iEJD9o9JrNvUzBpDwGZSY2LfmOR2sEyB8yPvrp/QUVZwGazcD3yhPddAf6yjdoHQkKzM7tnhA2o/QAp/p7JILdryVn3vYmdM439AIoORzDLrbX+LsRf6EPeT6PKKMoGX+AGG1kvTfmOQqI5XM4J13fq052wWmC6/cxwhkUU31JpYEqAUpn4DS0u8cv3oaMm003A5RMGKyh6K3lKxDgLbIM0k/w8HO+kunGKIt+Px6wjWscc7JQrK0JXGVJ585Z16vsb5Az11t3NYNsA5p49kMo9ZdfCLyb69BxQ5TN5xRXmGjw/gBl0MRKz9gplu4dDTzlvb6I0/JL3IXEJhuOWrTKurzCvyOkM8hPzKYRupRzR2Em1Z9fZl1xWcNbV35a45+zsf5mFtfENEzj25mF9MWwfqOhRJxdDNMNrjo+9ux4Od4pUfi5MW7Q/XUFmhBgAGB1ECTy7dSuivSc/AWEaZ/7vEWDSAZYFirsNClvBO6BBhGNpblCUqZOVH1mcIZGRN9ehXLk+iaB3/cmdifnWNKJ YavA/7er 6b/8xbREshdFTsDEAApbx66NoppY8DUO44HZMrQI3NitByaaRVic+nr3goIyO+mcJvzdZvi6hQeK2nfBJ2M/I3HBkKSI+vraGxnC6kky/CaIW3JaDt3PZrEkPkNM/qJveHLLDmQZJ0OXbLHEHDRVKuyEza5M8/yb2uKdAO+a1clhOiOwyXnCJMXwWjTxuXuD3ktygV3bpMflDIbEmm1sfJ8s6qFgsdUMBXTDFfdBL+5LXXVCG1g6XqlEksSWnXcURq0U3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/13 11:07, zhuxiaohui wrote: > From: Xiaohui Zhu > > Anonymous huge page has no corresponding directory inode, > which cause a null pointer crash when access dir with the stack > > trace_hugetlbfs_alloc_inode > hugetlbfs_get_inode > hugetlb_file_setup > ksys_mmap_pgoff > > Signed-off-by: Xiaohui Zhu > --- > include/trace/events/hugetlbfs.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/trace/events/hugetlbfs.h b/include/trace/events/hugetlbfs.h > index 8331c904a9ba..5daa52053edc 100644 > --- a/include/trace/events/hugetlbfs.h > +++ b/include/trace/events/hugetlbfs.h > @@ -23,7 +23,9 @@ TRACE_EVENT(hugetlbfs_alloc_inode, > TP_fast_assign( > __entry->dev = inode->i_sb->s_dev; > __entry->ino = inode->i_ino; > - __entry->dir = dir->i_ino; > + __entry->dir = 0; > + if (dir) > + __entry->dir = dir->i_ino; It has been fixed in [1] by Muchun. Thanks, Hongbo [1] https://lore.kernel.org/lkml/20250106033118.4640-1-songmuchun@bytedance.com/T/ > __entry->mode = mode; > ), >