From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 775E1C27C6E for ; Fri, 14 Jun 2024 12:08:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99C8F6B0104; Fri, 14 Jun 2024 08:08:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE4A76B011B; Fri, 14 Jun 2024 08:07:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F39B26B016F; Fri, 14 Jun 2024 08:07:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C33ED6B0119 for ; Fri, 14 Jun 2024 08:06:41 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7473E1206B9 for ; Fri, 14 Jun 2024 12:06:41 +0000 (UTC) X-FDA: 82229367402.18.7B49E03 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf21.hostedemail.com (Postfix) with ESMTP id 8EC2C1C0009 for ; Fri, 14 Jun 2024 12:06:38 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CmgIodLM; spf=pass (imf21.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718366796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KHG/yGyCiGvKudRrmafp28uTXE2vDuh3tAitczZGb/k=; b=3ACxJFUCOS7RAo0wqSgsMg4C4+y4+5khU9CDeZ8fe21s/XtC+KchBtNGjN0roKj9Vbp6DW RVa8BZzVk1fqfpWNXxtNN6wF1zsbgnoujiFOh6nRM/hwHBbFUUUpP6lots75OOs6Y70xop BlZwLLJnBcx9jZFyT3PWblyvqN0ELpc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CmgIodLM; spf=pass (imf21.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718366796; a=rsa-sha256; cv=none; b=8GtZ84/o1tmjYCFXKcN3B0zJVsXgmRbDVyPFFmq3trKmE7B76tViQDclCVlxCLK1Tqf/fJ oqZ2K3UEgk9stA3j/DPZcZ1lAy3CZQBihKcj/rBcZXLdyq4XhrhV2alTAjB8oDvq7o+tPk ZEKtIjT1O94pvtCjpl+Qb6SgR4Gu5A8= X-Envelope-To: usamaarif642@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718366796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KHG/yGyCiGvKudRrmafp28uTXE2vDuh3tAitczZGb/k=; b=CmgIodLMnVHV55Tk4LUvWAhewejUmuErW/ZxAwKOLzaqoVqUg3MHmyCQV1CORFrWVF7fMB X6PUvmq2hcEXKCEfppE92NJinO95mWrhmKEi6+3q1SqU772wMV0DxfT1YHvY26BuhmFToC PMy+wBgFRxTRjIeyYBtTwvDFeKkwNoI= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: shakeel.butt@linux.dev X-Envelope-To: david@redhat.com X-Envelope-To: ying.huang@intel.com X-Envelope-To: hughd@google.com X-Envelope-To: willy@infradead.org X-Envelope-To: yosryahmed@google.com X-Envelope-To: nphamcs@gmail.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: kernel-team@meta.com Message-ID: Date: Fri, 14 Jun 2024 20:05:48 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v5 1/2] mm: store zero pages to be swapped out in a bitmap Content-Language: en-US To: Usama Arif , akpm@linux-foundation.org Cc: hannes@cmpxchg.org, shakeel.butt@linux.dev, david@redhat.com, ying.huang@intel.com, hughd@google.com, willy@infradead.org, yosryahmed@google.com, nphamcs@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com References: <20240614100902.3469724-1-usamaarif642@gmail.com> <20240614100902.3469724-2-usamaarif642@gmail.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240614100902.3469724-2-usamaarif642@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8EC2C1C0009 X-Stat-Signature: dub9yee6o6wmu3aachsi9zbxf5ck96fb X-Rspam-User: X-HE-Tag: 1718366798-788151 X-HE-Meta: U2FsdGVkX1/8rCmnOlN4Ras40tZ9zURAKTBNNDMja5ekkYzzjIzBSmYoSsbcdAeMsNtj+wbTXrT6Gaw8P5tv2+9eaqIJKuwOGVysFFtUKY6qchT7EUC0+/Y2Ihcwn3WpiJ+zZDpws31V7jn0vqk6fAR6z3PyKtzodjLsn7pzcxQ/u5BE55joldO8vHvD8owM1vowfXdU0xNuL25z4+CXqopyD/wpvIDf8FYMtolmo2yMwTL6SYhxTPiwGWlh0AQWWz+E94UfLm/mfS3pUvxg9Ow4ehzuS5XahE6Uj54wtfJ2eh7EwwawzIgBqwAMxiG2oJC041afHWLnbM+U+xQJ9dQVRBVQNZ6ug9sJL4xtXzibJ6rx6vE+EHRIK1rdn4Lxy/eS+OR/EMIEODXOa41KpHCOWtKeQqK//CzsCQjTq6LzSr1wZKO1W3llBYMiORFJlXnmDTzqNF3v7fZ6qb2QlrDWCzR/WDECYZe8AMoZyRIt0GR/ZyeeY5Utppf5QxjEyPgsXLZECgSWbnhwrM9m3z6blr52EPhfHdZ8rD4KXNNO2VAMdV3NtRAv+XZzFaXVv18EI8JZHb3hDNA7XDEuuKG/LkpRjR2dI4Bp5Z9X8pCdHS3aXw+4RS2tIu7ErHx08nwGkmcahnV8dg3B8kVHSYG24naS9Kh5bHQoSaWFhtsoW45XQtnBjdjc4Ug3BwIk5Hq+lMTb1H0gTk0mzDAk2zWKqfkHuIRnrXCiMrSI0xqgKAIjkOXUxThSx1fNVXCQ+1Y+rd2v3n7/kuKjWxYvGQ7XoKkzZxNQJKrri2X89bnBf1pT1LPEY8F46gQZSZmUOf76VWhAHk5DCGeiOUzg4xKA+Nz7850NBzkRVCiXCka/MFzWApXgmZ4l58zyNX6QJvcaFo3fyOy5ySwxKjNYFzxSZKpDhy4MVig/9C+6HJ0E6zg3LhbwgcrYwl1s8YCyY1SiAnMiJJWfpt0GW/4 QyuvTkJ6 LleFl0fB6abeeGbc1AJT/QaIMW/Jw+OtGl2RvzUZOOxxCbENykpDGQ4DCDNrA/WuF+k2PY/RpMN8TT0+Zt09xVE4xtBanDYVU/RoRXnH53AkZGpNA4GNodSm2XXQimxU2q0k+ywYSqs0fh53D8bmvPITFOKA2eGWZ+p78WrllTQvRuz30oIpszvHuKqPC0/sP8qfUlGxAnjn9vRg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/14 18:07, Usama Arif wrote: > Approximately 10-20% of pages to be swapped out are zero pages [1]. > Rather than reading/writing these pages to flash resulting > in increased I/O and flash wear, a bitmap can be used to mark these > pages as zero at write time, and the pages can be filled at > read time if the bit corresponding to the page is set. > With this patch, NVMe writes in Meta server fleet decreased > by almost 10% with conventional swap setup (zswap disabled). > > [1] https://lore.kernel.org/all/20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p1/ > > Signed-off-by: Usama Arif Looks good to me, only some small nits below. Reviewed-by: Chengming Zhou > --- > include/linux/swap.h | 1 + > mm/page_io.c | 113 ++++++++++++++++++++++++++++++++++++++++++- > mm/swapfile.c | 15 ++++++ > 3 files changed, 128 insertions(+), 1 deletion(-) > [...] > + > +static void swap_zeromap_folio_set(struct folio *folio) > +{ > + struct swap_info_struct *sis = swp_swap_info(folio->swap); > + swp_entry_t entry; > + unsigned int i; > + > + for (i = 0; i < folio_nr_pages(folio); i++) { > + entry = page_swap_entry(folio_page(folio, i)); It seems simpler to use: swp_entry_t entry = folio->swap; for (i = 0; i < folio_nr_pages(folio); i++, entry.val++) The current code is good too, no objection. > + set_bit(swp_offset(entry), sis->zeromap); > + } > +} > + [...] > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 9c6d8e557c0f..0b8270359bcf 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -747,6 +747,14 @@ static void swap_range_free(struct swap_info_struct *si, unsigned long offset, > unsigned long begin = offset; > unsigned long end = offset + nr_entries - 1; > void (*swap_slot_free_notify)(struct block_device *, unsigned long); > + unsigned int i; > + > + /* > + * Use atomic clear_bit operations only on zeromap instead of non-atomic > + * bitmap_clear to prevent adjacent bits corruption due to simultaneous writes. > + */ > + for (i = 0; i < nr_entries; i++) > + clear_bit(offset + i, si->zeromap); I'm wondering if we need to clear bits at all? Since the current locked folio is the owner of these bits, we always update correctly when swap_writepage(). So if these swap entries freed and reused by another folio, we won't load from backend until that another folio has gone swap_writepage(), which update these bits correctly. Maybe I missed something? Anyway, it should be no harm to clear here too. Thanks. > > if (offset < si->lowest_bit) > si->lowest_bit = offset; > @@ -2635,6 +2643,7 @@ SYSCALL_DEFINE1(swapoff, const char __user *, specialfile) > free_percpu(p->cluster_next_cpu); > p->cluster_next_cpu = NULL; > vfree(swap_map); > + bitmap_free(p->zeromap); > kvfree(cluster_info); > /* Destroy swap account information */ > swap_cgroup_swapoff(p->type); > @@ -3161,6 +3170,12 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) > goto bad_swap_unlock_inode; > } > > + p->zeromap = bitmap_zalloc(maxpages, GFP_KERNEL); > + if (!p->zeromap) { > + error = -ENOMEM; > + goto bad_swap_unlock_inode; > + } > + > if (p->bdev && bdev_stable_writes(p->bdev)) > p->flags |= SWP_STABLE_WRITES; >