From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC95EC4332F for ; Wed, 14 Dec 2022 22:53:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CEA28E0003; Wed, 14 Dec 2022 17:53:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 47E728E0002; Wed, 14 Dec 2022 17:53:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F86B8E0003; Wed, 14 Dec 2022 17:53:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1E52A8E0002 for ; Wed, 14 Dec 2022 17:53:26 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 042C740141 for ; Wed, 14 Dec 2022 22:53:25 +0000 (UTC) X-FDA: 80242414812.07.2510231 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2077.outbound.protection.outlook.com [40.107.223.77]) by imf25.hostedemail.com (Postfix) with ESMTP id 16E83A0006 for ; Wed, 14 Dec 2022 22:53:22 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=amHWwd8i; spf=pass (imf25.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.223.77 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1671058403; a=rsa-sha256; cv=pass; b=fQ7isen3GTvg7e+Z7HK+5Dpc4gKP380ySmpFXambojEnCN9NM3Bma8lQoMpcbQPoiT35P4 94c4y6X1RUA/DqZFdABuUlaGCfShc4LJeqmrFRXT0QZOK8K35kYETHZI8N/VlqsrUJVnQV POc7fCOCDDosFmG9bVgLZf1b+zWRo30= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=amHWwd8i; spf=pass (imf25.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.223.77 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671058403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GdpjlXwwFP2hUEiotfnwS41G2dytZo4F0ypQ4lfXuEY=; b=nmffTMWDbOTArVwfMDRXG1G4J/2bcJFBHGAAZMLLpNwPS4g6Hhv6xuP3kSLbkSCB8D7IKI nOK1AsNu/ynpa8Cy0IuKmhay2Z5E0/XSgMLJzRR14lL+MFTxQaZnyUKbGfQDanNCyFUjSL 5kIrNrRj+4DWWmJJeVoaK8YbgXNWWLo= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EgBj32tHAVJFmaQty9Qd5Dmc3+Abk0hH+9ViX8KMuY8R9cjZYFg6N/5SjwEnj/2/tFvBHHkht7YPVYts8qHKup5YdU6MPJ6F+nOH8nE18rStqEV1RLq571QQDSCU/qda8Bgeuyj/wMr3Defct8XQosOzEBVGaPmar0sVX6UfJarEhzXl8s1bJ3zcV6jkpL+xr2ER6HMXJptCWgSZf0jJjYhAXsY6jwXQkWInSwzCPqAgvLPSUOVKcf24HdNF59YoaUxfQyybV29hWDgJZ05bs5FwOptu13udhVUdmNzmCq6QfdOFxCR66fhdGOTQl9uVd2VxpBbKaxidrSB+VhnOQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GdpjlXwwFP2hUEiotfnwS41G2dytZo4F0ypQ4lfXuEY=; b=mXeCi9g94H4soy72PTVNeq9NZJJOmKL98cBc3i1qqM6ivge/tfo0pBfE7ZCtPdGFsoaxA/75CPd55jRpAlaZLKRC7kG1dnn0ZJawJTPDQvGReEZdmVzRgQECrORwtMt329TMq47KtL2+OC6Sbd+d7zNuC5y3HppkmA+I7cb2N+28p1aEE7m+r8pHDFw9qelzr3mFK2aOurvlSZ8AKltwdCxerr0RjAP8KrH/9dpt0evl7kLcyRZg1p9to3oPyEy0t5j8FIiy3axRa6W38YmzWijxcusitvB6nnbJBkPGPHTboYNFjTPVR6TXNTYk6iSMikeGaw/opnkNa11jpe+wOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=oracle.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GdpjlXwwFP2hUEiotfnwS41G2dytZo4F0ypQ4lfXuEY=; b=amHWwd8irpxE7V56t2fdtufn9FUbdArxP89C3j9pW8n9DulYPaKe87As4JMboa6XDHdmTI0PtjSqeU3K0KKRvqw9jZTIzKvjKhXKAMsygRhuY6QN1raubkrwSSecRFMWyEDDmQJHUkMdS1tpvT133ic5qjzGjr2QXsCvqH8Au9wLuNFZbMSmLlsubgMNOc2+Vcl/nyIkL6igdN9470Y0nBzZ/ZDDI6s0N4meCXP1KEdkd31gf8pybvKR5WLlxVEgAaFOYMyIC3oEKw/nUii+rL4/SiVphSxcXVzZurhnBBBxwXTgL0fxiVu0GqMIwQ0XGuOY96J4t8W+cRoYUXcOyA== Received: from BN9PR03CA0360.namprd03.prod.outlook.com (2603:10b6:408:f6::35) by DM4PR12MB5038.namprd12.prod.outlook.com (2603:10b6:5:389::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.11; Wed, 14 Dec 2022 22:53:21 +0000 Received: from BL02EPF00010208.namprd05.prod.outlook.com (2603:10b6:408:f6:cafe::a9) by BN9PR03CA0360.outlook.office365.com (2603:10b6:408:f6::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19 via Frontend Transport; Wed, 14 Dec 2022 22:53:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF00010208.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.8 via Frontend Transport; Wed, 14 Dec 2022 22:53:20 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 14 Dec 2022 14:53:10 -0800 Received: from [10.110.48.28] (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 14 Dec 2022 14:53:09 -0800 Message-ID: Date: Wed, 14 Dec 2022 14:53:09 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH mm-unstable] mm: move folio_set_compound_order() to mm/internal.h Content-Language: en-US To: Sidhartha Kumar , , CC: , , , References: <20221213212053.106058-1-sidhartha.kumar@oracle.com> From: John Hubbard In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00010208:EE_|DM4PR12MB5038:EE_ X-MS-Office365-Filtering-Correlation-Id: c9e28382-4c08-4f65-a5c6-08dade25ff93 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bqb1tMi47Azvf2WjUXH6CR+IXkqh0NtKc2pfZWj61qWEXLebS0pBzZlorXjyln+rjZ8O4r2u1TwbTpfbv1NEREtGLx6RwNZ5DsSeXInuDeuAJJuytshOQu0mAETPrmWplENxkHz6F3HeEAEHU0PBoeLAKK61SCzzHOd1v3lVIuvJ2qT0tUnpnwsrEwLQO9CBzCY/41JN1RiPb27WbDqs6VJVpuFnNnytVFVCg7aj+jeAU2N5IvBq8LUYG+JjHxaW4VSES7DBMm2IhtWf7Z8+SViUkKsqG6FsbTQaVkGu2lsL6SyfRoWy7HNPfPTUv9cyZVVGzwTCECUO5lN5927G1spBAzKJKFhYTfkHLTOysapRbLBGKymz1AjaA/L3zbIoVov9JbP3MyHx+bjR1KJlU0Am9PLAV4mhiN0U8qlZSZRVzI7w5W45589vwxt7u0Od9tm5xkKuwwOMB2eklCJ7eGcQ1m6/FG9Ca2zqEwLQHjogyL+8wB+EtBO5AgSxEOV+MS7zOCeteDRsjzVaMgpOP7zTSujgOmFn23LSu7B10AOJd/an/5IBaqGzhFqQOawUth4CbX0Y1Aa6qw9fML8K5U099xjsBLK/QMcpCIGEJ8EZwN4gdBNiQX3ppH+MD/rYcNHHSvmJlnVh2U4+PXP1ocFZtwJRvU+0hmaRdbOu+fLwOgvEOPx9vUOECa0FhPnq6lDXnO81bYv++POAHNDWIm1OOH/K9bHUjhwsORiUksuX0HYWfhepgefC+Fg5DeLq X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(36840700001)(40470700004)(46966006)(2616005)(31696002)(86362001)(426003)(7636003)(83380400001)(82740400003)(47076005)(356005)(2906002)(8936002)(336012)(5660300002)(40480700001)(40460700003)(36860700001)(82310400005)(4326008)(26005)(41300700001)(16526019)(53546011)(70586007)(478600001)(8676002)(70206006)(316002)(110136005)(16576012)(54906003)(186003)(36756003)(558084003)(31686004)(43740500002)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 22:53:20.7337 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9e28382-4c08-4f65-a5c6-08dade25ff93 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00010208.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5038 X-Rspam-User: X-Rspamd-Queue-Id: 16E83A0006 X-Rspamd-Server: rspam01 X-Stat-Signature: srxthcqipjkrduje1h31jht1ryp3ex5k X-HE-Tag: 1671058402-340825 X-HE-Meta: U2FsdGVkX1/d8EoY+GO3MLSgUYDM0xh1NkLaXrXFsnR6O0VGhnVDogu4lUEKJOhMVCXRvchohu3Foy1UUPPkXTencv041F1KEcsy1v/nsSO+wbFa3Rz2atAeF6rJzBuqvWfIQP1Dlx/mt4KPRJzZAq6FGuB5xGG6Hhyz0C6OUPMQ2byxrVBK8mF3ywfRJNIlfAxNnjUaCyNbVXU+ZCi4hGiC57E3koWfyxtglmuaRrkZwyzSD6De3cKmZT2B5MzWbZK/uquZoAlpc54ZhFksJjldHe6Gj0M4R7DB64vH6OWj5Frd9EDrIQCKBadQKs6WMoMrngi9f5apI2logYZ1e1VITlxn+PkcBFvnudStszRd0r2kdtMeaI/SHysrXSK68+YHe1Yv0WaJciRBbotOPqt6mzaTT1PW34ernhZL7LzjmONjiQzXd4HfGS5KW8fHRV9d4ybTHQmWlykRJCtDHnU1K0j3lxacAl8sz6LbZ3uiR6yB9z/a5mQC77344Pz6/M4R2fQrqAiMq2Pig+n/52ippBWZ6uTHdLwwI3rubfgVGK0xDHEUc7RKJfNol18y/ThnFdmA5bMTPJvjrAKQvsTiCTjtLxVL2BIi5jM9RkobNuBxI+ho+PuwF2vJZNyO4g+1IlNML9SLqxDXUVrwWfmsmqLebOKmnHe49PYC2/rWZz1OsJLRldBMh9xowpfwmwgKyywQ/9k5p3FpPxSTJ1oMHAJBWwzFARq6UWhFjdqdl8sC6AlAVr2a2pn3UE/oKS9nX8PAkL8mfpzqcmVFqgqYPRHnsKXvbTLWUXiucQQ6j91idZvW9mrjW7aV0oOZ3Uar4Gv00NPMc1+uP5Wy1dvVkwDoCt4kAn0bLYw/0E+zv/YBZEO0MZDzgpl5gathMvrZ/3FRMLNZCiLsVxUgaIwzgjOTvSHxEOB53Sx87g5TX0VOJUHTLA1s0OdlLmtLeuqDOIUJVc2CxRXPXAM ijidhxcl E/l8Bf8OuIuBLKLpMUCvuBGLiyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/14/22 12:35, Sidhartha Kumar wrote: >>     if (WARN_ON_ONCE(!folio_test_large(folio))) >>         return; >> I agree that warning this way is clearer, I will change in a v2. With that change, please feel free to add: Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA