From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F517C32771 for ; Mon, 26 Sep 2022 14:34:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 272708E0060; Mon, 26 Sep 2022 10:34:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FB3B8E0047; Mon, 26 Sep 2022 10:34:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04E1A8E0060; Mon, 26 Sep 2022 10:34:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E36D58E0047 for ; Mon, 26 Sep 2022 10:34:06 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C00A3C0A25 for ; Mon, 26 Sep 2022 14:34:06 +0000 (UTC) X-FDA: 79954481292.22.469641C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 6A55E40019 for ; Mon, 26 Sep 2022 14:34:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664202844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a+FbxJJgt3y17YKBT0+Ib2+k/YUWasKnHCMtA7UgjaQ=; b=TRcqMuamlBOIpa2vXOmeWk6vbWXUC45j06EoRlHKo2QpLguMSAVlGVlF82DCXb8/RAHK2w o7wT3pBgbgEwZQHJ4OaVL/bLmDtOXPHDWS7trRbj5/5ZM5BC/f/6iynnhb8ht1Ine5FF3P Q9lXtN3URWCInv6+Ehz/tsUOcuZRSkQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-493-Eiou3hcDNHeAY_1aP2KXxA-1; Mon, 26 Sep 2022 10:34:03 -0400 X-MC-Unique: Eiou3hcDNHeAY_1aP2KXxA-1 Received: by mail-wr1-f70.google.com with SMTP id f9-20020adfc989000000b0022b3bbc7a7eso1248699wrh.13 for ; Mon, 26 Sep 2022 07:34:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=a+FbxJJgt3y17YKBT0+Ib2+k/YUWasKnHCMtA7UgjaQ=; b=iC52B2nedbLPFbiHcOozHRFagI6Ygk32nOicNt7fcK5fc46x0FywNJzuE7rRZgI7Jp 7OMOTHhayPapNrl/6OGIAGH4zehexotbHhDBoOf2jVJzVihyNQNa9PV2DdzWjTqP8lVb YJe84XITbbq0YD+LXGyNljIgoDAXig7ToYhQRVWtRd/dy8ITdQKk31fEgtlUwY6vvvpQ 9tjPEigU2AnQCcIFOpL59IU+XoLcmiiKVUzdT3WJTv+TnlbQzTU/hZzK/i1b9lOdLU1x 6wGkVniQ+QCbjeZc5u5SgjD7riuJSJjl4NCvShbvPrvfNCDqkd1GHlyZDh000vaSu3rM oOsA== X-Gm-Message-State: ACrzQf29IVgO+BW8CGi+3QnrBgarJVzNeQ/S22VLut9HmB5Zn977nOrl LeCfH1P3C2WiMNlZP1VjcpN1ymegCjtfPl4yXg6WCAoWqeJhNsnT5AhBAHTxiuh2mv/oPQrpcqD XuT6JhgyUp0w= X-Received: by 2002:a5d:6dad:0:b0:22a:ec41:309c with SMTP id u13-20020a5d6dad000000b0022aec41309cmr13255078wrs.127.1664202842605; Mon, 26 Sep 2022 07:34:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM47qXl6c/bnzvFCKghYBKa/lZpTTAD7Qpzyx1A9Yjx7yK6jVwg6jBbBDTDTkeIxiqZnZnvovA== X-Received: by 2002:a5d:6dad:0:b0:22a:ec41:309c with SMTP id u13-20020a5d6dad000000b0022aec41309cmr13255050wrs.127.1664202842258; Mon, 26 Sep 2022 07:34:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:4b00:e090:7fa6:b7d6:d4a7? (p200300cbc7034b00e0907fa6b7d6d4a7.dip0.t-ipconnect.de. [2003:cb:c703:4b00:e090:7fa6:b7d6:d4a7]) by smtp.gmail.com with ESMTPSA id s6-20020adfdb06000000b0022ae4f8395dsm14423463wri.96.2022.09.26.07.34.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 07:34:01 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 16:34:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] mm: use update_mmu_tlb() on the second thread To: Qi Zheng , akpm@linux-foundation.org, muchun.song@linux.dev Cc: chris@zankel.net, jcmvbkbc@gmail.com, maobibo@loongson.cn, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Bibo Mao References: <20220926115621.13849-1-zhengqi.arch@bytedance.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220926115621.13849-1-zhengqi.arch@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TRcqMuam; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664202845; a=rsa-sha256; cv=none; b=bfUDuBoB6JUoS04IyGJkYfNfSMoibBuzWDChQJXrbT2OMVk7thVMHQYqn6eEjDG0SLOqQQ U3UXGnS1uh1UUoT4Jv/+1+ny8Jd7wgK/D2e1fWfQubsHklBw4rbK9M49+/FAyPgQ3SYYnl o1FXA2RnEuIdiMkel34wzc+zoPWdqzA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664202845; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a+FbxJJgt3y17YKBT0+Ib2+k/YUWasKnHCMtA7UgjaQ=; b=sSZ5YRxe0q+e8Vma2NxR1cyItuzHEFaqrXPS/vQQO4O9neTlFGzdqd+Ck1Ov3WFuLnKb7s s9Y9gMQvWzs5tz1PEkPqiGdZ763VIZz1MvGgPM+Esdf1yCXVv8KkTbFPIhDgQo7XRaNHYX RmVEZ9ya1RWDIenAQHvLhzfdYtlC87M= X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 6A55E40019 X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TRcqMuam; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: rzn7d6y6iz67hs5f56m3s1ptppo7onfm X-HE-Tag: 1664202845-914457 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.09.22 13:56, Qi Zheng wrote: > As message in commit 7df676974359 ("mm/memory.c: Update local TLB > if PTE entry exists") said, we should update local TLB only on the > second thread. So in the do_anonymous_page() here, we should use > update_mmu_tlb() instead of update_mmu_cache() on the second thread. > > Signed-off-by: Qi Zheng > Reviewed-by: Muchun Song > --- > v1: https://lore.kernel.org/lkml/20220924053239.91661-1-zhengqi.arch@bytedance.com/ > > Changelog in v1 -> v2: > - change the subject and commit message (David) > > mm/memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 118e5f023597..9e11c783ba0e 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4122,7 +4122,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) > vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, > &vmf->ptl); > if (!pte_none(*vmf->pte)) { > - update_mmu_cache(vma, vmf->address, vmf->pte); > + update_mmu_tlb(vma, vmf->address, vmf->pte); > goto release; > } > Staring at 7df676974359, it indeed looks like an accidental use [nothing else in that patch uses update_mmu_cache]. So it looks good to me, but a confirmation from Bibo Mao might be good. -- Thanks, David / dhildenb