From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BE2FD10399 for ; Fri, 25 Oct 2024 01:22:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 342186B0093; Thu, 24 Oct 2024 21:22:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F2896B0098; Thu, 24 Oct 2024 21:22:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B9CD6B0099; Thu, 24 Oct 2024 21:22:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F36226B0093 for ; Thu, 24 Oct 2024 21:22:50 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 26053A029E for ; Fri, 25 Oct 2024 01:22:16 +0000 (UTC) X-FDA: 82710374376.03.4975785 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf16.hostedemail.com (Postfix) with ESMTP id 3AC1A180003 for ; Fri, 25 Oct 2024 01:22:26 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of chenridong@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=chenridong@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729819316; a=rsa-sha256; cv=none; b=GjeynS9N+fodj3TbnAThf7iHdy4qo13S4EXSbOnrrMj7s/d4k50Bn4ao7zwL9H9MtRic/S 8712rR0VpNoyHgONFaA9VaXMPUU8f+Gd8DXw3dBZ/erZdanDPzGRmuq2iz33CUtlgSROom Wo65XldE2O0x0oUuhB7OAREYEceghD4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of chenridong@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=chenridong@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729819316; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=38oq1WSVEYOZHbHKIj8JVBKfNwB8I3DB3f+0suIHssc=; b=ILKVSAKDQa8UTGOnavdOcSWQ9iLflNMl/mtwW2Kn4yousk/qpfs7XqFck5QTX603gGiViT VK2VN6Ry/Ucn3bBJAcAu6QZQcKRs760SII7pzeoqMI1cC/7MPykvJyAji8x2nN4GqXm5D2 ve986ONm0P2hI1zq7IBIqfJrXPRNCTA= Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4XZQ4f433fz4f3jsy for ; Fri, 25 Oct 2024 09:22:26 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id ECAD51A0568 for ; Fri, 25 Oct 2024 09:22:38 +0800 (CST) Received: from [10.67.109.79] (unknown [10.67.109.79]) by APP2 (Coremail) with SMTP id Syh0CgDnZVvb8hpnVB4aFA--.37378S2; Fri, 25 Oct 2024 09:22:36 +0800 (CST) Message-ID: Date: Fri, 25 Oct 2024 09:22:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: shrinker: avoid memleak in alloc_shrinker_info To: Vlastimil Babka , Roman Gushchin , akpm@linux-foundation.org, david@fromorbit.com Cc: Muchun Song , Anshuman Khandual , "Kirill A. Shutemov" , zhengqi.arch@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangweiyang2@huawei.com References: <1BD74B20-879A-4159-B957-1223553217C1@linux.dev> <0b883f9e-451f-41c2-805f-7f5bc7eebee2@suse.cz> <1625e2e0-06ad-459c-b941-41fadea2008d@suse.cz> Content-Language: en-US From: Chen Ridong In-Reply-To: <1625e2e0-06ad-459c-b941-41fadea2008d@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CM-TRANSID:Syh0CgDnZVvb8hpnVB4aFA--.37378S2 X-Coremail-Antispam: 1UD129KBjvJXoW7tw1fZrWktF13Gr4kZF47Arb_yoW8Wr4Upr WFgFW2kF4kJr17CFn2gw13ZFWFv3yftw13Wrn5tryku3Z8trnaqrW7KF1q9F95uFnYkF42 93yUXr9Iyw4YyFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUv0b4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7MxkF7I0En4kS 14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I 8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8 ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x 0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU1 7KsUUUUUU== X-CM-SenderInfo: hfkh02xlgr0w46kxt4xhlfz01xgou0bp/ X-Rspam-User: X-Rspamd-Queue-Id: 3AC1A180003 X-Rspamd-Server: rspam01 X-Stat-Signature: hdfcw5iuhtnwmbranpb95osyshtt3yse X-HE-Tag: 1729819346-66041 X-HE-Meta: U2FsdGVkX1+S8/jgWISxHfjVmeov8DELk+nAtszxMYQ44M5fDVe46eWkGQdo/3vzegt3Mx1HG4Q4I6NbPp5X2mxmT3UZoJcxweqXTIUaUVQm0EV6dUN+h4+bGf8HuVB5VYLDaTvCzos5itMqx1U3j7oUxIH24NaTV5uhGVPQQEtoHHw3BWvshX6ZgeGygYnaw9x0tVJn/Mr/viueme35Hi09JrRdL/l9mseJUrseThicf/8TyO1QZeT6ZFV+3Rbiar+4y/tb/ZBLVt1Cq/A+6Emhs331BEOKNUusLm4S890fFeJgYMfJNPb40aZepsF37jJfIFKq4AtgEsDXWPX63ajoLoOvZfrX/H9+yPdEIqpgKI2nC4k1keSQTBA+QluA/eqtnCEV6lGVc0uYypAFVKdX8YO5ewlejt5502kpA2boznJSDJKKSm1kRPnsMgkdxnc+CA2hzHHdJXvIy7yIcJIdM8zQVrNddvbbMxeSdQ8mx16RCufQHL+tNdk/6bp+bJZ4p2puKXXSyip8RP1LoFOYyB6EDKfqS40EsmbXw2czQ4AnVEzszRRpjgMh5cRJhefZeLtCrRd13G2Rq2MdRn9WcdA1YAvvMC0ATxWg6P2oJFnl8gEvfv2B+vtD9lihjSBmS1axQjM5K6Ri7xNShxF+xYJz5TlnloddNLmhUlzjyO4ZhuNG6UPmP6TuvUpm4gKqUM+4qBLs/BYQ2fQwndL3SLh8/CO9CY/ym/+1XpSkmWMWO4efQSBzVD15fi+ZXNhu4wdk6lPotvHmDxKDFmxXcFYadeJ71ZPKNTM5TDXfRq/+NHxnbTQPeagzu9SvMFA54UvnCrD5mapMRZkExeYVeyZ6+tsygGNfv/NpI+Srdg1kd+HUr9AmofdTUuAObkngjDBx5XDVXRBYqohsvWb0GHeJiLriIoqhqKEJiTolL2VrCy1YAtw9PZdSAXc9k/2aS0TmPnS5TK59AaJ gqWnJSqx /bZVThzRLKHPoj9UFTRAbg3ZHKMPcCcIQtwWrMJCUYadYITpCR2jFdf7eQz8AuWWgeqaC9OltgD6RUzHhaMxdGveI2+uMR9Sl3j2N5iy9OX36oukb4oYz/0PPEHlUCIxOdSnjUTfAODn0KZ9VkGrrE+UmaSJS7SZzEd/RiqsT8xOXXxnncg2haVRr2AwkQ5uxpJ6RP+cHrBYSuguq8vx1Iw5eOAkMMP2ryfl0zy+QLWGMaP1kAxQ2v8UiWrhAQx5qa2Dn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/24 17:08, Vlastimil Babka wrote: > On 10/24/24 03:26, Chen Ridong wrote: >>>>> For example, if we use his v1 proposal, we should do >>>>> the cleanups again for info. But for goto-based >>>>> version, we just add another label to do the >>>>> cleanups and go to the new label for failure case. goto-based fix is what I insisted on. I copied my previous suggested fix here to clarify my opinion. >>>> >>>> Again, info is a loop-iteration-local variable, v1 fix making it truly local >>>> is the way to go. If there are further cleanups added in the loop itself in >>>> the future, they could hopefully keep being local to the loop as well. >>>> Cleanup of info outside the loop iteration is breaking its real scope. >>> >>> +1 to that. >>> >>> I don't think it's such a big deal and both versions are ok, but I strongly >>> prefer the original version (without introduction of a new label). >>> >>> Please, feel free to use >>> Acked-by: Roman Gushchin >>> with the original version. >>> >>> Thanks! >> >> I agree with Roman. >> Hello, Andrew and Dave, Do you have any opinions? >> >> The original version: >> https://lore.kernel.org/linux-kernel/4184c61f-80f7-4adc-8929-c29f959cb8df@huawei.com/ > > Hi, > > Can you resend the v1 as v3, but also move the declaration of "struct > shrinker_info *info;" inside the for_each_node() block? Also you can add all > the acks collected for that version and mine too: > > Acked-by: Vlastimil Babka > > Thanks. > >> Best regards, >> Ridong >> >> Will update, Thanks. Best regards, Ridong