linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Christian Brauner <brauner@kernel.org>,
	Jens Axboe <axboe@kernel.dk>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Jann Horn <jannh@google.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Mike Rapoport <rppt@kernel.org>,
	linux-mm@kvack.org
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] mm: add kmem_cache_create_rcu()
Date: Wed, 28 Aug 2024 17:16:44 +0200	[thread overview]
Message-ID: <b561fe23-891e-4b4a-8fc0-45a7b33f8c9c@suse.cz> (raw)
In-Reply-To: <20240828-work-kmem_cache-rcu-v3-2-5460bc1f09f6@kernel.org>

On 8/28/24 12:56, Christian Brauner wrote:
> When a kmem cache is created with SLAB_TYPESAFE_BY_RCU the free pointer
> must be located outside of the object because we don't know what part of
> the memory can safely be overwritten as it may be needed to prevent
> object recycling.
> 
> That has the consequence that SLAB_TYPESAFE_BY_RCU may end up adding a
> new cacheline. This is the case for e.g., struct file. After having it
> shrunk down by 40 bytes and having it fit in three cachelines we still
> have SLAB_TYPESAFE_BY_RCU adding a fourth cacheline because it needs to
> accommodate the free pointer.
> 
> Add a new kmem_cache_create_rcu() function that allows the caller to
> specify an offset where the free pointer is supposed to be placed.
> 
> Signed-off-by: Christian Brauner <brauner@kernel.org>

Reviewed-by: Vlastimil Babka <vbabka@suse.cz>

Thanks.



  reply	other threads:[~2024-08-28 15:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28 10:56 [PATCH v3 0/3] fs,mm: " Christian Brauner
2024-08-28 10:56 ` [PATCH v3 1/3] mm: remove unused root_cache argument Christian Brauner
2024-08-28 15:05   ` Vlastimil Babka
2024-08-29  8:38     ` Christian Brauner
2024-08-28 10:56 ` [PATCH v3 2/3] mm: add kmem_cache_create_rcu() Christian Brauner
2024-08-28 15:16   ` Vlastimil Babka [this message]
2024-08-28 16:36   ` Mike Rapoport
2024-08-28 10:56 ` [PATCH v3 3/3] fs: use kmem_cache_create_rcu() Christian Brauner
2024-08-28 15:17   ` Vlastimil Babka
2024-08-29 15:58 ` [PATCH v3 0/3] fs,mm: add kmem_cache_create_rcu() Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b561fe23-891e-4b4a-8fc0-45a7b33f8c9c@suse.cz \
    --to=vbabka@suse.cz \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=jannh@google.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=paulmck@kernel.org \
    --cc=roman.gushchin@linux.dev \
    --cc=rppt@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox