From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 040E1C54EE9 for ; Fri, 23 Sep 2022 01:56:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB534940008; Thu, 22 Sep 2022 21:56:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6101940007; Thu, 22 Sep 2022 21:56:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0128940008; Thu, 22 Sep 2022 21:56:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BF0A3940007 for ; Thu, 22 Sep 2022 21:56:43 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8C23A160433 for ; Fri, 23 Sep 2022 01:56:43 +0000 (UTC) X-FDA: 79941686286.15.89464F0 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf24.hostedemail.com (Postfix) with ESMTP id 6ECB4180004 for ; Fri, 23 Sep 2022 01:56:41 +0000 (UTC) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MYZsS4yGrz1P6nx; Fri, 23 Sep 2022 09:52:28 +0800 (CST) Received: from dggpemm100009.china.huawei.com (7.185.36.113) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 09:56:37 +0800 Received: from [10.174.179.24] (10.174.179.24) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 09:56:37 +0800 Subject: Re: [PATCH v3 1/8] cgroup/cpuset: use hotplug_memory_notifier() directly To: David Hildenbrand , Andrew Morton , Waiman Long , Zefan Li , Christoph Lameter References: <20220922141904.3245505-1-liushixin2@huawei.com> <20220922141904.3245505-2-liushixin2@huawei.com> CC: , , Kefeng Wang From: Liu Shixin Message-ID: Date: Fri, 23 Sep 2022 09:56:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663898203; a=rsa-sha256; cv=none; b=BWbR9tXggPmMcV/7/IKrKUZy03wcEVpuepCpjQZmofUUrM8tcg0V6uLdQeL1Xf0zTlMSyE jWvKtor3dj6NS6hJMqF43fVYHtwuUX4jpF4f45YbG0Fyos1dWZgvBuiQ3EPCe2LUP8qvO8 /S/S7hPcu0hUL563dSzIunug7WTK9DI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=liushixin2@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663898203; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1OvOCTwaYfYScwDcYDZBlazwzHp3aHnkHH58GSAurTk=; b=Na9+LCwm/Ek4ukncytJnC5i8CEO/mnioEEJAfPN/BwT4y1IqXSBD6caaQjG6InUuptbE0O 8c0WRQIkoHnbkTR65QL9VwXvCE8GcW/N7ttOdO3a6YMk5hp+utbiybRtHCMygWIt6WY3si 98WLWvXromVxir1BodZRzJLE8P7OtRg= Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=liushixin2@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Stat-Signature: zmb59jbqsecaref5eym1nped5ykdk6z1 X-Rspamd-Queue-Id: 6ECB4180004 X-Rspamd-Server: rspam02 X-HE-Tag: 1663898201-847777 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/23 1:56, David Hildenbrand wrote: > On 22.09.22 16:18, Liu Shixin wrote: >> Since patch 316346243be6 has already updated the minimum gcc version to 5.1. >> The previous problem mentioned in patch f02c69680088 is not existed. So we >> can now revert to use hotplug_memory_notifier() directly rather than >> register_hotmemory_notifier(). >> >> Signed-off-by: Liu Shixin >> --- >> kernel/cgroup/cpuset.c | 7 +------ >> 1 file changed, 1 insertion(+), 6 deletions(-) >> >> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c >> index b474289c15b8..0c6db6a4f427 100644 >> --- a/kernel/cgroup/cpuset.c >> +++ b/kernel/cgroup/cpuset.c >> @@ -3630,11 +3630,6 @@ static int cpuset_track_online_nodes(struct notifier_block *self, >> return NOTIFY_OK; >> } >> -static struct notifier_block cpuset_track_online_nodes_nb = { >> - .notifier_call = cpuset_track_online_nodes, >> - .priority = 10, /* ??! */ >> -}; >> - >> /** >> * cpuset_init_smp - initialize cpus_allowed >> * >> @@ -3652,7 +3647,7 @@ void __init cpuset_init_smp(void) >> cpumask_copy(top_cpuset.effective_cpus, cpu_active_mask); >> top_cpuset.effective_mems = node_states[N_MEMORY]; >> - register_hotmemory_notifier(&cpuset_track_online_nodes_nb); >> + hotplug_memory_notifier(cpuset_track_online_nodes, 10); >> cpuset_migrate_mm_wq = alloc_ordered_workqueue("cpuset_migrate_mm", 0); >> BUG_ON(!cpuset_migrate_mm_wq); > > > Please don't drop Reviewed-by or Acked-by tags. Otherwise reviewers have no clue which patch they already reviewed -- and they always have little time ;) > Thanks for your reminder, I'll keep it in mind.