From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF9DBCDB482 for ; Tue, 17 Oct 2023 09:05:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3857F8D0101; Tue, 17 Oct 2023 05:05:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 335878D0007; Tue, 17 Oct 2023 05:05:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 223E58D0101; Tue, 17 Oct 2023 05:05:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 109EB8D0007 for ; Tue, 17 Oct 2023 05:05:18 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D626A120EE9 for ; Tue, 17 Oct 2023 09:05:17 +0000 (UTC) X-FDA: 81354369474.07.7C5AFDA Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf09.hostedemail.com (Postfix) with ESMTP id BC5F414003F for ; Tue, 17 Oct 2023 09:05:14 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697533515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IUKFmLvafupbQaGJcIlytw3lVHoYXSaf1Vy1dzwhQ+c=; b=cSEohZ5/jIJEGzkeZ98MgcBnc1F4JGZRRojIU3/8eQzQyMscSOd1Zf6y6yUTYRLKYA7WaF xBpcnYehsPrcIoyCGjDMjutl4F/MVM5+MuehKu4c6aBAw0583z0B7dD62Ih6h2AEoAAm1v tamqhUxmMZ0D1H3FV3EuX5Ms45mpSTQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697533515; a=rsa-sha256; cv=none; b=6s08EsWaX7bd1g5NND4ni4XqQ7azNP5OZ+YhYHpoEdF26iug5TUCkH7uJA3PTBETFxTh9T d7/eqKZEmtnBS3RKqbLhArjvGCeswBk/MCpx5T3Q6xqmHcIfXF3D8F1eM2SQJO84qRXL4X rwQ9mgJSIEVxVnMG1HHSLmZh4ZDetJk= Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S8nzX3y0DzrTWv; Tue, 17 Oct 2023 17:02:00 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 17 Oct 2023 17:04:42 +0800 Message-ID: Date: Tue, 17 Oct 2023 17:04:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next v2 17/19] mm: convert wp_page_reuse() and finish_mkwrite_fault() to take a folio Content-Language: en-US To: kernel test robot , Andrew Morton CC: , Linux Memory Management List , , , , , Zi Yan , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot References: <20231013085603.1227349-18-wangkefeng.wang@huawei.com> <202310171537.XhmrkImn-lkp@intel.com> From: Kefeng Wang In-Reply-To: <202310171537.XhmrkImn-lkp@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: BC5F414003F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: kx46bngaong7p3d6e3673wtqzu11bs1k X-HE-Tag: 1697533514-67066 X-HE-Meta: U2FsdGVkX1/hPm/hecKGSBhoxOoCaPna7yDXm10gfB0tN6z+OcheTa/dLcWC2AVXqYqgW6p7t3RuBQ31b8vAlfiHDj/QKlZn9uTL1efSWQfI38esv8KFFOXuhyPiK501ewmb+dyA78vOjFA4WIVS/rh54iXDaqafrOpQzdMFKOtebTALKLhK86QmvqzgHgOigUC554dnc1593PA10euj777WzMFUO3aaQvuBzYv4fc1/NsDepbWz2DpwyURHVhtdncV7EhPANeJmthuXmZb69cMauDJRXqyqSE5bEXf8UQNzhFlkRyd2/jnAN0jRJCQ/sNhDNRgVLMgaUSPz3wnVPW1OQKoBoliimjaqlKfJzVMm1SpKhoDv55u4kk74FupWfM7RziekHpc4exCkmXEtVgaBDGC+8M5KjYoU1QY8IwYTFYa0bU9kV7LKpEY6RCizd6sXMrtdpsq3aGtwrZtTunCgsRSc8ldRIl7Zw+9/hZdcCrqb9zssFFANRTN99Lob9UvCV2JRYcINd1fqueX+RFsWH+0SU9FWTBqUwzY5lw9AusRj+tuy0zMgRiaDUTU7gbO5tUn9ATmtASvuFSlcnBsmfUSrBmWTocvtLKIaO+/Q2YoAao3fL6aWSTms4FJHWp5w8bF55exKMyc4JYCGSBFLvKbQgR0M3UPl7nEHOdX3oNs38Bs/CE6FwUVw08f0EWqI/1Eb7O/8fiVVA6dlJN8aPexPZWoNVOkCft5EzVp4KqD55VDEqRnzqW4MzHGqos9O2TPPA1lQt7F/YlcK+c2Jput0exj9biZkn8iQug5fraMsJrEGRXkjV6aJn9K57entH3TjJuuDFTRYhXjMBNFeP0l4uofqzzxUQe2nL98MykX1lPpK/t5SLUX9CsTOxPYFdSC8yzLaCBOt03hEkOJV1vpoROOvd1dwXHuToC0yb5Jfiu70kF0/1hzR4HMdLrsrMJ4ocQCAXYEdQQb dC0EoaGm njihOeG9RR5NDptvplEz726DRNHkAt1FHWWYBl6emP7iHoQ55INu/Ycdh8bsRotmgFTbZmVQFfUIB/JsXv9Ss5wJoyB65wshngRtVRDUnGm835VEzJ4LrAw95VH1jIR10/j/dzPkilZ0L+c+SzS7BhRSYdk372Gdy5OHKAzoZbXVFjTNF5GGK/R9ShNvGsAoAD7TEjkoXa5LuEjyjbpYBexdbkH2zvGY5gUPzakVSmT0H5MnXGKRIex0FAZvY2/v/+yejBVEZ3E3DQwu9XS2Qqxgh8olotYV2mAxSfJmglqRjsFVdAutbdyXk2GkORKcot3zlFNKsK9pPKuJWC2k4vPgSX0zHnIiYfdo1Hkq46Cl/cG6UfXi0ibWBXE/1OzTMt5cbE1cVpTPe3q4MlYiZ0s0atAUAcPcV6UUv4RczdbV4GyxY7NnVOwMkBf40FNPJpz/2vDn8DsVcV6r7q23vvU1GGK/vFVSMcjazx6aOa0/3hRAbHBccSvKMeM+9neJHtZ2P X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/10/17 15:33, kernel test robot wrote: > Hi Kefeng, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Kefeng-Wang/mm_types-add-virtual-and-_last_cpupid-into-struct-folio/20231017-121040 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20231013085603.1227349-18-wangkefeng.wang%40huawei.com > patch subject: [PATCH -next v2 17/19] mm: convert wp_page_reuse() and finish_mkwrite_fault() to take a folio > config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310171537.XhmrkImn-lkp@intel.com/config) > compiler: m68k-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310171537.XhmrkImn-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202310171537.XhmrkImn-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > >>> mm/memory.c:3276: warning: Function parameter or member 'folio' not described in 'finish_mkwrite_fault' > Hi Andrew, should I resend this patch? or could you help me to update it, also a comment(page -> folio's) on patch18, thanks. > > vim +3276 mm/memory.c > > 2f38ab2c3c7fef Shachar Raindel 2015-04-14 3258 > 66a6197c118540 Jan Kara 2016-12-14 3259 /** > 66a6197c118540 Jan Kara 2016-12-14 3260 * finish_mkwrite_fault - finish page fault for a shared mapping, making PTE > 66a6197c118540 Jan Kara 2016-12-14 3261 * writeable once the page is prepared > 66a6197c118540 Jan Kara 2016-12-14 3262 * > 66a6197c118540 Jan Kara 2016-12-14 3263 * @vmf: structure describing the fault > 66a6197c118540 Jan Kara 2016-12-14 3264 * > 66a6197c118540 Jan Kara 2016-12-14 3265 * This function handles all that is needed to finish a write page fault in a > 66a6197c118540 Jan Kara 2016-12-14 3266 * shared mapping due to PTE being read-only once the mapped page is prepared. > a862f68a8b3600 Mike Rapoport 2019-03-05 3267 * It handles locking of PTE and modifying it. > 66a6197c118540 Jan Kara 2016-12-14 3268 * > 66a6197c118540 Jan Kara 2016-12-14 3269 * The function expects the page to be locked or other protection against > 66a6197c118540 Jan Kara 2016-12-14 3270 * concurrent faults / writeback (such as DAX radix tree locks). > a862f68a8b3600 Mike Rapoport 2019-03-05 3271 * > 2797e79f1a491f Liu Xiang 2021-06-28 3272 * Return: %0 on success, %VM_FAULT_NOPAGE when PTE got changed before > a862f68a8b3600 Mike Rapoport 2019-03-05 3273 * we acquired PTE lock. > 66a6197c118540 Jan Kara 2016-12-14 3274 */ > 60fe935fc6b035 Kefeng Wang 2023-10-13 3275 static vm_fault_t finish_mkwrite_fault(struct vm_fault *vmf, struct folio *folio) > 66a6197c118540 Jan Kara 2016-12-14 @3276 { > 66a6197c118540 Jan Kara 2016-12-14 3277 WARN_ON_ONCE(!(vmf->vma->vm_flags & VM_SHARED)); > 66a6197c118540 Jan Kara 2016-12-14 3278 vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address, > 66a6197c118540 Jan Kara 2016-12-14 3279 &vmf->ptl); > 3db82b9374ca92 Hugh Dickins 2023-06-08 3280 if (!vmf->pte) > 3db82b9374ca92 Hugh Dickins 2023-06-08 3281 return VM_FAULT_NOPAGE; > 66a6197c118540 Jan Kara 2016-12-14 3282 /* > 66a6197c118540 Jan Kara 2016-12-14 3283 * We might have raced with another page fault while we released the > 66a6197c118540 Jan Kara 2016-12-14 3284 * pte_offset_map_lock. > 66a6197c118540 Jan Kara 2016-12-14 3285 */ > c33c794828f212 Ryan Roberts 2023-06-12 3286 if (!pte_same(ptep_get(vmf->pte), vmf->orig_pte)) { > 7df676974359f9 Bibo Mao 2020-05-27 3287 update_mmu_tlb(vmf->vma, vmf->address, vmf->pte); > 66a6197c118540 Jan Kara 2016-12-14 3288 pte_unmap_unlock(vmf->pte, vmf->ptl); > a19e25536ed3a2 Jan Kara 2016-12-14 3289 return VM_FAULT_NOPAGE; > 66a6197c118540 Jan Kara 2016-12-14 3290 } > 60fe935fc6b035 Kefeng Wang 2023-10-13 3291 wp_page_reuse(vmf, folio); > a19e25536ed3a2 Jan Kara 2016-12-14 3292 return 0; > 66a6197c118540 Jan Kara 2016-12-14 3293 } > 66a6197c118540 Jan Kara 2016-12-14 3294 >