From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4379EE77180 for ; Wed, 11 Dec 2024 20:46:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB1E26B0096; Wed, 11 Dec 2024 15:46:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A615F6B0098; Wed, 11 Dec 2024 15:46:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 979236B0099; Wed, 11 Dec 2024 15:46:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 770296B0096 for ; Wed, 11 Dec 2024 15:46:24 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1F9151A1691 for ; Wed, 11 Dec 2024 20:46:24 +0000 (UTC) X-FDA: 82883859996.03.D064216 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf25.hostedemail.com (Postfix) with ESMTP id 746ACA000C for ; Wed, 11 Dec 2024 20:46:05 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MASDn2bT; spf=pass (imf25.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733949960; a=rsa-sha256; cv=none; b=B1BgZayl9Ka92GA0glYBgbVNl4LRecqKSjSBPmwvZEXlOlbCjDaRuzD7GqIoerA+m7OzOX d716c1Xb/3Fs6vlcpit8lAqvHopK8XvfJD3YJxpKjpBVlCR7zRZSSPBTbv+3r7tWuunRcj bq4tFk5ow0tpXkYIMsbpzn5GiZWl0Fk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MASDn2bT; spf=pass (imf25.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733949960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DiJApXOAc0hwv3kQaHrLDZZL2Fn5Gj1tPRe5/QNMN1M=; b=h1EAgMQd6z8mFQt6w91tp4/f4W9pXoStFm9mWih1y6g5Frny2qUZhXir9IyEwvTK7oB49n smECAXawAgP2Bu35TaEQK23LnrvaVO9SxkJLJk+xPsI9sY6jlaftBrK41fSwDk7bm8EeHC SV8VGyB6Fn8b+egCqQltN2RNmuJVe8Q= Date: Wed, 11 Dec 2024 12:46:14 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1733949979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DiJApXOAc0hwv3kQaHrLDZZL2Fn5Gj1tPRe5/QNMN1M=; b=MASDn2bT7F57NqmN2d3CBeVlxMXlXeLI2D2oKHwsORwXjWLazM9kvsmJnF1n6nffCRd1h1 +nXpHsAaOH7pWYYGPbij5y7dwavnUIzeLUagh0gg8P7vyty1QUiJ7ySHJ/mQ6N84N9vMtU PzDlTD1WvnBCRZtwzXOS7gOATX+ERuk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Christoph Hellwig , linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , cgroups@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] vmalloc: Fix accounting with i915 Message-ID: References: <20241211202538.168311-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241211202538.168311-1-willy@infradead.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 746ACA000C X-Stat-Signature: op87fonrdgayjqwhw3cywa5yx44zckgs X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733949965-588885 X-HE-Meta: U2FsdGVkX19rewOje0eOftmQj6/8c7Bd2AI2bh9sjibm5CQZtWo/zszErT/1q6o/JkCVgsN+qfJKF/jZsCR+7dlp+tMtPduXdtX0e6/HZ8+2eINho1sDGe/tO+KcVZZeziRBDUqSShUSFZzFI0Bf8wRthYWBGVPTfTCRqe6Tl0VzQlEU00CnsSmQ+1IVvr6AmLXDkSCGbTUCJwmDopRrkUkElRDnNxzeMdQGpd5iqTRTh9iXgNSssBN+CWZ8ToWiFdyH1JfiKM8h5Ffe4gyYnxx8U39yKtvNN9Rz9RC0JwjsqPzAABJ1UVyAsi75rWFo1+ApjNd8qlwAOWAILatI6yt97tVQ13CbchZwe0gVMD5RVvIH8GyT7Vyoeg5obN4e7tFsFsQLOLNeruEzlutYydRjsXfR7+eU9qXHn2BmRR+dQUEvG8+sOkS86mmWXbj7fLt5Xogop98WWkI3QE2hSG96K7R+e3GQLTfy+wxi0HZiktKG0ciidyeYXLSF5poduFfGb6fexCjgrU8Xem2G5C0FC7jCJFFxPV2KiJb5cwlxRVP7ZYggHtFOaDzywTOj6H/KoMXOqg/xs/rw+nbvLl/DU1ucBbdhFCW08cNflGDRDw7VOVIvN38IsTSpqS98iKIm6pDN1l5GYQ7uXqFOgl8SnRz+6Af8BGtpn17mf5OyfK01tARh9oO0YNpVsuJS7nd2vXx+/kFLlxIp7ePM326o6HKEf4ykCbk+WMZkwyS5zUYPuik69bJy479R111TpjHwgidvK46Pjao8eVBf+RN3Qt3ig20v1K3YSNQe/MGg35lXhlazmWOusxVJ4M8mom5TnxOMXLh4b4JAIcuIwo1QO5/8G+sqTcj7NOgEsXbq8YOm03NMHWPHDXzZ8b8wxxDrY5UrcOmKUwa8tjeCLZUva86kbPpoIrqKS8MtR1FyJd/As0aT2a7SkZVtNjTw7bFuNhZx9wCeFfN+QYL CorGEE+E guQnLbdlLVa1ZIVSQ7smEdiPI3NhuJg9p67blVdk5Ue0OSc7qP/gMNqg6VJHArpVsHxxnMiRzLYycNbykOrjfnK+MOe1kokHvB3nXdv9jMy3va0JW00mIHHjWwUE9NLsTI4wu8qe97ZHzBb89DKhbSY1s4XN8u+P2qktwqP+ouqizXomQtuNVw4T12XbGSeHWcwEO3NRVRimEnnAeFXgLYV3JrTm/dy7ksl1OdqEiAR1NtBJTcQLpFcQ3FgDlFpMskLlV/cgvTLJL2IuK4aQiKkQgNNtebNgH/2c2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 11, 2024 at 08:25:37PM +0000, Matthew Wilcox (Oracle) wrote: > If the caller of vmap() specifies VM_MAP_PUT_PAGES (currently only the > i915 driver), we will decrement nr_vmalloc_pages and MEMCG_VMALLOC in > vfree(). These counters are incremented by vmalloc() but not by vmap() > so this will cause an underflow. Check the VM_MAP_PUT_PAGES flag before > decrementing either counter. > > Fixes: b944afc9d64d (mm: add a VM_MAP_PUT_PAGES flag for vmap) > Cc: stable@vger.kernel.org > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Johannes Weiner Oh you merged them into one. Good. Reviewed-by: Shakeel Butt