From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22CBBC54E67 for ; Wed, 27 Mar 2024 07:23:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99D0B6B008A; Wed, 27 Mar 2024 03:23:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94CED6B0096; Wed, 27 Mar 2024 03:23:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EC626B0099; Wed, 27 Mar 2024 03:23:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 698EC6B008A for ; Wed, 27 Mar 2024 03:23:32 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 37ABD140A06 for ; Wed, 27 Mar 2024 07:23:32 +0000 (UTC) X-FDA: 81941978664.02.0B66291 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by imf30.hostedemail.com (Postfix) with ESMTP id 22AD580002 for ; Wed, 27 Mar 2024 07:23:27 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=P9kRrlDK; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of przemyslaw.kitszel@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=przemyslaw.kitszel@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711524209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BBdXvE3wRSBplABmuOmzS/nTE1Rw3lhDWj4CkMW6YDQ=; b=09S/3qZQ2V3ayWV3lfl90hCGIuSHlsgjbU07AZ6M6IfqBl00Ba7cdvFdLhmMMJdfsRWr7E qX7gHx1pV3Ws0x4OakTqkm2XHB4/JEfeHt9W5ZHPKh/5+WH1iZlmcBBHuDQBIXJwIqoxAk 70IwS8iyfv4aK1bWjbSnWxAdgOyqJi8= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=P9kRrlDK; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of przemyslaw.kitszel@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=przemyslaw.kitszel@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1711524209; a=rsa-sha256; cv=fail; b=TcO4ESJd9NE72CJWTzv3KgN7y+AAbzmj0aNMHvTEOq/TM0cDKY+UrwAouKgYtIvR5M+9mL vq2Rzy6bXtYB2uGbjzOAC/Yq8+nTnbSj2feaV8pw7m6+Xz74TnhpIvwu8e25nvzI+J/mOT 9tGMRxPQ/Cg7OqRscmElKjxQeKPhzv8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711524208; x=1743060208; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=pk1nTs/zfKmDq1d6QmoxTa/Xa2s7LhivS1k3hPAhqMs=; b=P9kRrlDKCNPBxX8iR/qwFVov3pYQMrSZvTN/jZmG7g61XetamQKpUlXS HRzcanApFA/XVtdWCE6qIEc+n+UnIZ2llWyuTQKFo4WkwBHwKp/UvDcw8 0rocZvMNgYYjqO723gEJ2M1vWKNI3xYe4rtvDQV6eQreTkf9D8DUa8A1t JTPXzzV2HNFNuS83/tjIpHtbMTQ24SXYPTNk15jR4lBN0YEydobzNxO1g yP6fMR2Kp0SZo5lBA/taE6FKVK0jHyUzOBcKXV0HHPGpdQ3ZqMEfcts9h T34rRiKfyAncAXvwP877DMTqh5hSSAFRgL6tJQ1oP10epY+bWedyrpFW+ Q==; X-CSE-ConnectionGUID: VatvFAJYThu5eR8+CjpVLg== X-CSE-MsgGUID: r3iowu5cTeyEYTAmWxeoBg== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="6738891" X-IronPort-AV: E=Sophos;i="6.07,158,1708416000"; d="scan'208";a="6738891" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2024 00:23:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,158,1708416000"; d="scan'208";a="16304377" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Mar 2024 00:23:26 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 27 Mar 2024 00:23:25 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 27 Mar 2024 00:23:25 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 27 Mar 2024 00:23:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MhUyg/cTpi7ZZ1WnjKPCqePw98KPD/1ZxoAhp1QUccfyXPCKT2ZcnVgizilYqqv+iV5eTTKGWDKOyQFcn0E1gHjQNB3AB0qnJNdw8PCKCfSrSZy0TBmi+8BXsd/q493MJHNkBRg/oeyjgH40eQpUDMzwaBJbDI9otGtlqKcTr2XasU9BzViCQAKMTV6S/I2wRHcjZzGtpDiUKSdppHpP1IDy7dk+58jMGczqGGu5Q5ChGE+c7ZWABz77yiX2fLm1tFYgh/3ulpOTcEmJjghS+KniRdVXKrxUWSdvF8NyH9P2TGGx4c+oefUeKvJ8tceNroX/jDUVD76lKShmtscdAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BBdXvE3wRSBplABmuOmzS/nTE1Rw3lhDWj4CkMW6YDQ=; b=LRupf0kPZI6lb3laaus9bTnGlNf/VTUNIoN8ZEKQGi/rA9sKYRZxh8g2zFHS6E4+F+VdHh/soXuQLVg6pzoLZ2cBFg4QlQoDaeP2Godhiiwv7ddvBOL5SKeCCdcpzfMvIk9wEZQMB73nlTKb4rWmbJ3VZ7UOKQf35jM8j0XxopAFNQvq6DkIEgQ4bvN4t7tZoCqEVYZhWrjGHOvs9I2/cm7lgWOAJ2cLCMuiMKnK3wM/faQSBx1MD7f8gamWo4E4xrUoaFXQ3C3CvFY6XXiKezTxopFLzVR8GPMG3da0gT/TQptDa/AHlft+rKG6SDcUr9qIUhWC2Wvq2Y+Yh1TMXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) by PH7PR11MB7100.namprd11.prod.outlook.com (2603:10b6:510:20f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Wed, 27 Mar 2024 07:23:18 +0000 Received: from MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::618b:b1ee:1f99:76ea]) by MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::618b:b1ee:1f99:76ea%5]) with mapi id 15.20.7409.031; Wed, 27 Mar 2024 07:23:18 +0000 Message-ID: Date: Wed, 27 Mar 2024 08:23:12 +0100 User-Agent: Mozilla Thunderbird Subject: Re: Re [patch RFC] mm/slab: introduce KZALLOC_FREE() cleanup-ed allocation macro Content-Language: en-US To: Dan Williams , CC: <42.hyeyoo@gmail.com>, , , , , , , , , , , , , References: <20240315132249.2515468-1-jiri@resnulli.us> <20240321162648.23693-1-przemyslaw.kitszel@intel.com> <6601c9e161df3_2690d294e5@dwillia2-mobl3.amr.corp.intel.com.notmuch> From: Przemek Kitszel In-Reply-To: <6601c9e161df3_2690d294e5@dwillia2-mobl3.amr.corp.intel.com.notmuch> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MI0P293CA0009.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:44::6) To MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN6PR11MB8102:EE_|PH7PR11MB7100:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f62f67a-39cd-45c6-615e-08dc4e2ec61f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KPlPVbXes5BDcBQjAOcMroBLxwGH1T9JoqWEZtMc4cnVSTgxQx3IcCF0JrGD9Qa99qHZ5bT/2GOYQ8NCTuwy9YS9GS2WphANZ3bzJhaSUGBhzFnkLHTK079Sn/LmwT5C8li8T/ufCzfrwp4L/9r+iz1VI7ec5CskN1+ddy3m+eFF7P8O0joHzKPfl+2ub1nDd3JQimM+p9U/Yyh5stAM3DJOKTde1iqVYrrD2RYzANU1ZvmrkS/P2QboUJeG8uQHPN66dW3dxM580gBXOUxF6DGh4PZy5gqiKmhQ/I1tUz3WnVZZlh0fOck5OWCruCEVWrz9c9YpkiI/BDRTcKwrn4rh5plG2jfx+xmKK4LlalKg4IFoze2O2y1cgZbkqCsmn/suKcuj+3p8KaT3CSCk1VgmpHrtNxF9l7VPNjGeXTcOhOQmPbAeAWiIR4I2RSoo0sDAf1uvw6k3lbA+cnFKw+4fk7NSBoyypGGV+dD3CO+Sobnu76CLOHVX7G1D8P3aA3cVwnq28bl/G+T9/EH/41fpHh6pLHEch4c/lyayApflbl1undZbJ4LSyTykxVe8+ZaTz8mMJQTGIfUrO/WUEJuse/UMIt/suPt19t5iWvBpv17+k/wKib056JanpKG6 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8102.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(7416005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1I5eUFzR1RZekVEOTZLeDNUMGhTeXQ5YmJERk9xNmtXNmlXR09reERXOWI2?= =?utf-8?B?NlJ6MllvVmN2emVCSGw4YnViWFYvYmozQWpkLzVQejZHUVRibEs4d3g1aTNa?= =?utf-8?B?dTFyMGtJdkFBdkpIOTBWeFZXcHR4YTB5dW9uUFlDeER6bi9pRXJ2enpJS0Nz?= =?utf-8?B?STkvQXpiOXdLM0lnRkNvQVFwQzRjb05LRTVtQjFKOGFseFdOUzhQdXNxUW1G?= =?utf-8?B?S1ZvTndmSG01UTBUK0hvYlg1d3BzL0FFcHp6Zk5TZTJ4Y0tORjd3cWtYakNw?= =?utf-8?B?QXdEanZJeS9EeWxSbFlxOVdQakRSOWluN0hSRHF3YnVWMFl2MmdoNjFLSndD?= =?utf-8?B?ekdiSmtGaFRiS2NJeWNPTHg1V2tiWDM4dzZsS2RRbWUwajBvOTBpOUk3c1dw?= =?utf-8?B?SldNWmxLcy9VQjlrdTU5RVI4bXE3NXlYc2wwY3loMFV1dnRLckNxVVQybVJn?= =?utf-8?B?ZCtWUXk2SGxKbFBxUlYrNTNSbmI3b3lwdWtyOWgwTEY3VlNzQ24wclc2eVRZ?= =?utf-8?B?djVZaEZRQ1daL1JzV1FHWGpLZFRESFBDczgzS1A3QWlCdU9wVTBTWHY4ckVl?= =?utf-8?B?eGlPVUtrY3pPdE5ZV2lBRERJa1hSZUhraEZVSjA1a2ZsZmRjbU5EWFpYSitH?= =?utf-8?B?OFkyQ0Y1U3NmbVVNakJSaXhQR2IvYi8yYTB1Uk1KOTNmS2tHRWl0M2ZDT09R?= =?utf-8?B?bStwTGRjV3d5YWdYb28zUjRhQUQra0NZSzBWRnkyQjhtdEtuMkF3N20xN0ZT?= =?utf-8?B?dVg2Q0RqMUkyMmdhNjhkYVg3YXRyMkVpY1NVcCt3c2x6Tm5nd0J2WEJLWW95?= =?utf-8?B?bitsb0dKaUZmUEw4WWNSa3hBb0FQSkJ1d0JpbzljMXAyNURhM2FDdWtiQzVs?= =?utf-8?B?M2dDK1daQitNcHJIdzRFY0ZzSEFHTmQrMStIVzRyTlBvRFRKZnZoUFE1V2hD?= =?utf-8?B?WmNFUDdKOG9OTnNwazdIOSs1a3RONmpGbWdnbTFLQUVaL3JhY0IzQUJDMElm?= =?utf-8?B?Z3RDK1FsYjF0enpDOGdmYVd3UzI5c1ZkQWFUUmZjR3NoS2xUNUloeTJZbWow?= =?utf-8?B?b1lWMFc0Vld6b1RjRGF3WXNsYm43bjJ1aEtjOEcyV2JqSE9MVWVDeHVBQWMv?= =?utf-8?B?RkFLalhpS0k2OC9BaUNqekprWThZbWtGNnNqcTRBYmhmZWlrSGFqQ0FFWSsz?= =?utf-8?B?ekcveWE4VjhpVVNrTm1MWUprOXEzSUEwSWF0c29pNlEwcDZZS2VXdWV6RnRS?= =?utf-8?B?WEVDaSs0Q1lISFpRSnJ3bGp6V1R3VXduaUdZY3dSdi92MitTWC9CckZKM1ov?= =?utf-8?B?VC9XS3g1cjhqK3BNTHlPKzkybldlQ2xtY3JscWhhbTRLQVMyWk5OdGEyQzRV?= =?utf-8?B?dDdySGl6eCtTN3JKNjZ4MUNja1h6VXJBa3V1SktVUU11dFB3WWZGZjJCaVdw?= =?utf-8?B?eElFeEJTMnRDR1RISHQ4YjRoREpPSWtraFNiYk5XKzFkK2hvMzRCcVV1NjFK?= =?utf-8?B?MWVlVFA3QmIwS0d0aE9pTmNCZFFBRzdiQ05pWVJZRHVJWWdFSWZxbjBwbUFS?= =?utf-8?B?T0luSzNNTmQrajNweUNVZ3dnVG1WSi9ud0ZiakpvSEMzNHJSUDBVeGNDamI0?= =?utf-8?B?dHFyeFo1ZTJDYVJwQTdjUjlQcjhJREIxTzN0cDhxbjJ4YVJKcXFJdGQxMFZh?= =?utf-8?B?LzNGek1tTFVtWHNHRUNTRFNCcWhHL2dWTGt2NlNhdVhZc1hmV3hWdDdUUkFE?= =?utf-8?B?WlJoYnBjVmVUZzFvdk9HaFcxRWt2cDJRQVlZbXRhMk53eG9uT1NmU0oyUjZv?= =?utf-8?B?RGR5T2FOaFNzL0QxOTU3aGxiYmpzbHFJazlCZlhkTVJNVmlsb3hIY0NFTTdE?= =?utf-8?B?OHNHTXBva3dMZmRxTlBjRGdhbldpZllxVzlXVFl2YndtVForNlg5S3RnMFRU?= =?utf-8?B?c1JjN0FHTURSd0FUVi9FN3dVR09aQ20xZUlVN045SGw4VUpXaUM1YzRTQTNy?= =?utf-8?B?a2JDcnQ2YTZjRll6SmNFZzNocFVNKy91bEwzZmFsN2ozejE5YjdjaVgzWit1?= =?utf-8?B?RE11K1I1V21xamkxZXlNUkR6RVNuQ21YR0tzSTVhdjlDc3VyL3B6NVYwbjdK?= =?utf-8?B?dFhFTlRvak9aN2xoR2UzZm1NSW5PVGFJcm9MbGhsanFoeGxYN1JWVkw5ZUdz?= =?utf-8?B?L1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9f62f67a-39cd-45c6-615e-08dc4e2ec61f X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 07:23:18.1088 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5WCA4MrhoGzIWZwESJhKe7b0RpEoX6VHWEDR/zU/8ja87uRCbSuWZ0vAlacp0WrMe9iL/BXdS2Zzt9JNlydUIsnEIoAmzlw1/qHM61ubrNM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7100 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 22AD580002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: bz33fngd44fghadkz3w8xji4sjt7oiu6 X-HE-Tag: 1711524207-50271 X-HE-Meta: U2FsdGVkX18SuKSwcFDeB5clZ8qjJiSmhTUpRwsAxqB7BDLSmwCH0m+A/fDfCs6AeW3LP+xdJ0YelBzL1/xJjHuIIzS0yRGBCbABpz02TgVhMCT3aAVDr0k69dbTdeBo9Do8/HvcQ5+DhITp5s1RB4p0ryP9qTmP/E/9hlbWt7YtsVNHZjqwN4OA+oASDq6Kzytt3bBTRQznFEDRMsgVMzXNrvK7PdGefeo9+2mg3db/mXykgt1x2yN/YnYInca6WK+9x31dbPecPmWmqhR42LcHxn8hpIZNVdfnuc4XYhLdF9Gc7H7iF7q9OfjFv/e0yz3kwxVbkSXKzMcIdiw6Fbs/aBGEdmoTr9HwuXsVM4MYn1jBjfsetMlj3MAeuniFrnoUrErRhb+UAdZfvscRNnhC7I3i4Bj6sQyDWw9EDykTAha6z8KmzPyvvIBlaSkYWHjWgTf4bnDUG5w9Q9euwxEz7Isu8PH1eNhzG2uliE6/SwYN5MzvrvS2SPS83oAKkCLvtCkYD12oO3LxeO6PzH7vqe4hhmGPl8ERtMekPhrArk6QT3OW8Qe61xRf7PoFrqS6THswWH6pv0LDyoW3o4dpEQ3VThYqSmT8Kq1lNw1ykzUavBcd24+dvxZnEtcRf3qHlP9/bHgAPqfx2w9csHZlkwgzTrTvWHGm3yP5R8s8Q0hbN1GHasEiunpWEOvc3HCGI3FAiHjJqi0L0ZHp1VLua/q7ccP5bpI2NPWu6KI8yDOfSczumUX+MnTZYYfthObcqQLnFIbLOjUAuaT7mL1ZsLfCNi8FN+HDTJgpDUazOsJ0fPLw1Q9eLDsreWo3UV/fVaDL0j+z0LFAQDvbm7GLHNsVaBgWRzLdenYJWtFHdUQyjta7TrMQGc3GtT3yJRPOJirMTofRNKkLQIgfRUhvXL4+GRtX8S2K8RM+mFPlxWdPNjiEpw6bxEGQEPZSQsXxdZ0d4fg/wK80/6I rQIL3ofs 3sWoCAN95paikyoJr87Hee6G5FgS91eLfmVmSktkrADt13qXUykTLAoKc6gUtDScjhxzWr5a8iTbWP5Y0AJa2kh5zq1Vbwyn+EBcBMf1tX1qiA0ZX9FDJ6ScW2CZpiQgaL6YK6sxUsdgD/FyMLancsvKI8QZ3jZ+/9JueaoEvxFnibDNP19gfPAR2C3TGXexFPWF9j/pTWUZd6P2FTeIeZYuwmuitTRUiDyyC7k5IuLHYBUqtJpU2HN21wQYQe5pE9bPETkFj1ZT/RBTxaCHbGHcySjHTWuUR6aThcukAmHaCQf7CV3rOcptwjh4Xz665HDNeNZ44NNOxaqiQIeUPQd0HkCqO7nMYClLYr+sZvLvIMCwJnJEqE7sJtOekQw4bE7z+NpndbceW7AmPhvO2Dmmk1ZNvawnLFYJHLyceLzhjNrlzMT4EKvh2RtIWdwNtkH3Iz0KPAGZ/bQFjHQaQV7U0NAadFWZa9I9pSpkS3+FZrc/3GZ4LspWXkgjgRix1v7iaA1kgnSqqeSxBHFDWamLCnMVuzJQlMNOoWn4r39ksYkM5mzL7gdl/JZijDhcKn2FOPWtMpys2nG7X83FZwvIsUVkv2/ASfM/s X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/25/24 20:00, Dan Williams wrote: > Przemek Kitszel wrote: >>> From: Jiri Pirko >>> >>> With introduction of __free() macro using cleanup infrastructure, it >>> will very likely become quite common to see following pattern: >>> type *var __free(kfree) = kzalloc(sizeof(*var), GFP_KERNEL); >>> >>> To follow the CLASS() flow from cleanup.h, introduce a simple macro >>> KZALLOC_FREE() to wrap this over and allow the same flow. >>> >>> Show an example usage in gpio-sim driver. >>> >>> Signed-off-by: Jiri Pirko >>> --- >>> drivers/gpio/gpio-sim.c | 3 +-- >>> include/linux/slab.h | 3 +++ >>> 2 files changed, 4 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c >>> index c4106e37e6db..997237b3d80c 100644 >>> --- a/drivers/gpio/gpio-sim.c >>> +++ b/drivers/gpio/gpio-sim.c >>> @@ -1496,8 +1496,7 @@ gpio_sim_config_make_device_group(struct config_group *group, const char *name) >>> { >>> int id; >>> >>> - struct gpio_sim_device *dev __free(kfree) = kzalloc(sizeof(*dev), >>> - GFP_KERNEL); >>> + KZALLOC_FREE(struct gpio_sim_device *, dev, GFP_KERNEL); >>> if (!dev) >>> return ERR_PTR(-ENOMEM); >>> >>> diff --git a/include/linux/slab.h b/include/linux/slab.h >>> index b5f5ee8308d0..baee6acd58d3 100644 >>> --- a/include/linux/slab.h >>> +++ b/include/linux/slab.h >>> @@ -711,6 +711,9 @@ static inline __alloc_size(1) void *kzalloc(size_t size, gfp_t flags) >>> return kmalloc(size, flags | __GFP_ZERO); >>> } >>> >>> +#define KZALLOC_FREE(_type, var, _gfp_t) \ >>> + _type var __free(kfree) = kzalloc(sizeof(*var), _gfp_t) >>> + >> >> Nice, but I would rather see this wrapper in the cleanup.h file, that have all >> of the rest of related stuff. >> >> On top of that, I want to propose also a wrapper that is simpler in that it >> does not allocate but just assigns null, with that in mind `_FREE` part of your >> proposed name does not sound right. > > No, do not hide assignments within macros As most general advice I agree, but here we have a specific case: declare variable via macro; and that, (given the macro name would be clearer), is expected to have assignment (or default (un)init). I would even go one step further and remove also the asterisk from the call site (and *hide* it in the macro definition). See _DEFINE_FLEX() as example: (there we change on-stack instead $this_thread on-heap-autofree) https://elixir.bootlin.com/linux/v6.9-rc1/source/include/linux/overflow.h#L401 > > http://lore.kernel.org/r/CAHk-=whYxkfLVtBW_B-PgNqhKOAThTbfoH5CxtOTkwOB6VOt6w@mail.gmail.com Your thread is a more complex thing to what we have here. And BTW, your original proposed solution is nice, and even if it hides flow inside, it's almost obvious (the `return -EINTR` statement is verbatim at call site). Allowing `else return -EINTR;` solution proposed by @Linus is nicer, makes a good idiom, but is less obvious: Imagine two developers that don't know the API (well), one writes: `scoped_cond_guard(args);` and forgets to handle the error case, the other by just looking at the code have no idea to append `else handle_err();`. > > I.e. the amount of incremenal cleverness that include/linux/cleanup.h > will tolerate is low. Any helper should look like typical C