From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0431C3ABBC for ; Fri, 9 May 2025 05:25:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 709A86B0083; Fri, 9 May 2025 01:25:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B9C36B0085; Fri, 9 May 2025 01:25:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A7BC6B0088; Fri, 9 May 2025 01:25:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3DE4A6B0083 for ; Fri, 9 May 2025 01:25:31 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 65D4D1A0582 for ; Fri, 9 May 2025 05:25:31 +0000 (UTC) X-FDA: 83422231662.30.AFCCA26 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 5FE0320003 for ; Fri, 9 May 2025 05:25:29 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746768329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hSLCdPuODimzb6A0ttkIneu3Io/Lnsi3SN22oR9z3tI=; b=dfYaky76RqmdxzCctRhLO6Zj2RN7H+AJxR/PrpMfMwq2L07KrurcmZAi2UURE/Am314NhX ImS36n3xV7vanj9PdK2PjpAsYH7QswPIwD6qt1k/r7zUZCMgP272CW4F4BU05JAIMJZx4L zZ+cEm9tj7TitOT8wFZqjAGJPnc1MLs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746768329; a=rsa-sha256; cv=none; b=uAUlSld6IzV0YDjgIxR57r5lThaoLECvHwsKNYKKOb1jHhAH1AoZqSjV3Q0zh0a/3ytEMa L0nBM2Bc9ntXQGkBkHm0tiMXjdJg0Y3uSd+xTC66tv7cabHUDUE1rjjTbpk9lM618dpUkm m887ZCJ8/OOBgzOVybQf+e+v/aZ/TZg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF50D153B; Thu, 8 May 2025 22:25:17 -0700 (PDT) Received: from [10.162.43.14] (K4MQJ0H1H2.blr.arm.com [10.162.43.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 083603F58B; Thu, 8 May 2025 22:25:21 -0700 (PDT) Message-ID: Date: Fri, 9 May 2025 10:55:18 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm: Add generic helper to hint a large folio To: David Hildenbrand , akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, peterx@redhat.com, ryan.roberts@arm.com, mingo@kernel.org, libang.li@antgroup.com, maobibo@loongson.cn, zhengqi.arch@bytedance.com, baohua@kernel.org, anshuman.khandual@arm.com, willy@infradead.org, ioworker0@gmail.com, yang@os.amperecomputing.com References: <20250506050056.59250-1-dev.jain@arm.com> <20250506050056.59250-3-dev.jain@arm.com> <887fb371-409e-4dad-b4ff-38b85bfddf95@redhat.com> <0979ce4e-d316-477c-872e-d3f9e47690e5@redhat.com> Content-Language: en-US From: Dev Jain In-Reply-To: <0979ce4e-d316-477c-872e-d3f9e47690e5@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5FE0320003 X-Rspam-User: X-Stat-Signature: rgymz6pkyaxsxnw7wk8ji1am8gbunijr X-HE-Tag: 1746768329-657916 X-HE-Meta: U2FsdGVkX19KMIxIyGfppRkojDSKhyBRSqWlgfWET+iFpIq3alkZHaoJ4MI1OHiIeJ/IFg784DYvbdPlj55o8Obn/d7zO1j/qnc6udSZD4sA7/Bjq3QhriWwwbs/Cmhoolr+Wj1Mxp2CJ92mlSZWnW+0O+jb3m6XHIMVM2XWOX95xZdt9JotybDkwmVGryd6/UcqG3XE4loHZeRikgRfTkCK++rBxCGtmRHB9tiG+sg6dmDcPtk1DReGfg1ZEmS1nZMMZosuIDvOhoVm8ajtPsLwQyOhL9nh/dg0i/53XnolOvovmu7fgh22UJdmbuijK+CjhPNLYBlPz5LvjoHYfACOrb2ICn7uZk/vnDXoXhvvJvdPLBnv139+8/+bEe627yxgOZNkH00C/Jp857/fmsfx8kpgzL6enyBcQBh/KMe27ABA0KdYH24+2gfG1SbBospBHxIyE9PrrYuQTnUTY3mLsGOf4OlUiWb5fSRIxD3YQCRZwDqyEIXUAoeaG43t2f9rParwFS78u0dYo5htrEFmllV8TMF+SokUoKTqU7R2Kz3StHXmBhuW1mDYsj7UK+fMYtL52Scg72aAhuz+pQCdSskdtAQjR5B5GaL0EMVs5Qz254Yy9dOO0BZNc3Vn+gkJrj36VWN+qIty5YerhR+y8trLtskJFBCrgRjHH+vJK3H7UVYK4GIsSF5cB2BKzA3BnxoZGS4FaCDoRYGzoQAxZpiXdJi7J7ed3ahI8tBOCq9PWo1ynT0pML6A7my7fwAODTTl+5+HvHq/xmzvKpJaCyXadq+eISfda7ZNTsLpwHCLla6mWi11c/62XVvnPmhJapg0kUoZqy0BKu+Se9nnzAyYIBd/K2kQjGIA8J6zYhupPnVtA2tSK/nbl6UOlC8S2QW9S+HP1ZWwrVli8gayf5TTqU6HdptjK5V/Qyyqax/bsWCCFA1dn4aSXjdDdtsQ15CSpfXpN+oSM7y WlNe19T4 QRlGtxUU8Da3XjiuDieos4bKA+14j70XRwZNekKdWhN3qzOzsy9w0gjvReW3H8mWzOfEc+4T9cY4SvFz8ZcIhyVkY/3MS1ZoEv450iJcETdSV/Jt8AlYGsNLI9t2nmZtX8ohpfxF+DyhzoXxQZMzpn2+6ai5DkXTNpoTUilg2nQGxlyHNdpfFxYux2GhdL9anasyLYTQoSITAxMwhvUxFrLja0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08/05/25 4:25 pm, David Hildenbrand wrote: > >>> (2) Do we really need "must be part of the same folio", or could be just >>> batch over present >>> ptes that map consecutive PFNs? In that case, a helper that avoids >>> folio_pte_batch() completely >>> might be better. >>> >> I am not sure I get you here. folio_pte_batch() seems to be the simplest >> thing we can do as being done around in the code elsewhere, I am not >> aware of any alternate. > > If we don't need the folio, then we can have a batching function that > doesn't require the folio. > > Likely, we could even factor that (non-folio batching) out from > folio_pte_batch(). > The recent fix [1] might make that easier. See below. > > > So my question is: is something relying on all of these PTEs to point at > the same folio? Hmm...get_and_clear_full_ptes, as you say in another mail, will require that... > > [1] https://lkml.kernel.org/r/20250502215019.822-2-arkamar@atlas.cz > > > Something like this: (would need kerneldoc, probably remove "addr" > parameter from folio_pte_batch(), > and look into other related cleanups as discussed with Andrew) I like this refactoring! Can you tell the commit hash on which you make the patch, I cannot apply it. So we need to collect/not collect a/d bits according to whether the pte batch belongs to a large folio/small folios. Seems complicated :) > > > From f56f67ee5ae9879adb99a8da37fa7ec848c4d256 Mon Sep 17 00:00:00 2001 > From: David Hildenbrand > Date: Thu, 8 May 2025 12:53:52 +0200 > Subject: [PATCH] tmp > > Signed-off-by: David Hildenbrand > --- >  mm/internal.h | 84 ++++++++++++++++++++++++++++----------------------- >  1 file changed, 46 insertions(+), 38 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 25a29872c634b..53ff8f8a7c8f9 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -217,36 +217,8 @@ static inline pte_t __pte_batch_clear_ignored(pte_t > pte, fpb_t flags) >      return pte_wrprotect(pte_mkold(pte)); >  } > > -/** > - * folio_pte_batch - detect a PTE batch for a large folio > - * @folio: The large folio to detect a PTE batch for. > - * @addr: The user virtual address the first page is mapped at. > - * @start_ptep: Page table pointer for the first entry. > - * @pte: Page table entry for the first page. > - * @max_nr: The maximum number of table entries to consider. > - * @flags: Flags to modify the PTE batch semantics. > - * @any_writable: Optional pointer to indicate whether any entry except > the > - *          first one is writable. > - * @any_young: Optional pointer to indicate whether any entry except the > - *          first one is young. > - * @any_dirty: Optional pointer to indicate whether any entry except the > - *          first one is dirty. > - * > - * Detect a PTE batch: consecutive (present) PTEs that map consecutive > - * pages of the same large folio. > - * > - * All PTEs inside a PTE batch have the same PTE bits set, excluding > the PFN, > - * the accessed bit, writable bit, dirty bit (with FPB_IGNORE_DIRTY) and > - * soft-dirty bit (with FPB_IGNORE_SOFT_DIRTY). > - * > - * start_ptep must map any page of the folio. max_nr must be at least > one and > - * must be limited by the caller so scanning cannot exceed a single > page table. > - * > - * Return: the number of table entries in the batch. > - */ > -static inline int folio_pte_batch(struct folio *folio, unsigned long addr, > -        pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, > -        bool *any_writable, bool *any_young, bool *any_dirty) > +static inline int pte_batch(pte_t *start_ptep, pte_t pte, int max_nr, > +        fpb_t flags, bool *any_writable, bool *any_young, bool *any_dirty) >  { >      pte_t expected_pte, *ptep; >      bool writable, young, dirty; > @@ -259,14 +231,6 @@ static inline int folio_pte_batch(struct folio > *folio, unsigned long addr, >      if (any_dirty) >          *any_dirty = false; > > -    VM_WARN_ON_FOLIO(!pte_present(pte), folio); > -    VM_WARN_ON_FOLIO(!folio_test_large(folio) || max_nr < 1, folio); > -    VM_WARN_ON_FOLIO(page_folio(pfn_to_page(pte_pfn(pte))) != folio, > folio); > - > -    /* Limit max_nr to the actual remaining PFNs in the folio we could > batch. */ > -    max_nr = min_t(unsigned long, max_nr, > -               folio_pfn(folio) + folio_nr_pages(folio) - pte_pfn(pte)); > - >      nr = pte_batch_hint(start_ptep, pte); >      expected_pte = __pte_batch_clear_ignored(pte_advance_pfn(pte, nr), > flags); >      ptep = start_ptep + nr; > @@ -300,6 +264,50 @@ static inline int folio_pte_batch(struct folio > *folio, unsigned long addr, >      return min(nr, max_nr); >  } > > +/** > + * folio_pte_batch - detect a PTE batch for a large folio > + * @folio: The large folio to detect a PTE batch for. > + * @addr: The user virtual address the first page is mapped at. > + * @start_ptep: Page table pointer for the first entry. > + * @pte: Page table entry for the first page. > + * @max_nr: The maximum number of table entries to consider. > + * @flags: Flags to modify the PTE batch semantics. > + * @any_writable: Optional pointer to indicate whether any entry except > the > + *          first one is writable. > + * @any_young: Optional pointer to indicate whether any entry except the > + *          first one is young. > + * @any_dirty: Optional pointer to indicate whether any entry except the > + *          first one is dirty. > + * > + * Detect a PTE batch: consecutive (present) PTEs that map consecutive > + * pages of the same large folio. > + * > + * All PTEs inside a PTE batch have the same PTE bits set, excluding > the PFN, > + * the accessed bit, writable bit, dirty bit (with FPB_IGNORE_DIRTY) and > + * soft-dirty bit (with FPB_IGNORE_SOFT_DIRTY). > + * > + * start_ptep must map any page of the folio. max_nr must be at least > one and > + * must be limited by the caller so scanning cannot exceed a single > page table. > + * > + * Return: the number of table entries in the batch. > + */ > +static inline int folio_pte_batch(struct folio *folio, unsigned long addr, > +        pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, > +        bool *any_writable, bool *any_young, bool *any_dirty) > +{ > + > +    VM_WARN_ON_FOLIO(!pte_present(pte), folio); > +    VM_WARN_ON_FOLIO(!folio_test_large(folio) || max_nr < 1, folio); > +    VM_WARN_ON_FOLIO(page_folio(pfn_to_page(pte_pfn(pte))) != folio, > folio); > + > +    /* Limit max_nr to the actual remaining PFNs in the folio we could > batch. */ > +    max_nr = min_t(unsigned long, max_nr, > +               folio_pfn(folio) + folio_nr_pages(folio) - pte_pfn(pte)); > + > +    return pte_batch(start_ptep, pte, max_nr, flags, any_writable, > any_young, > +             any_dirty); > +} > + >  /** >   * pte_move_swp_offset - Move the swap entry offset field of a swap pte >   *     forward or backward by delta