From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A124C07E9B for ; Wed, 21 Jul 2021 02:22:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0BFE561178 for ; Wed, 21 Jul 2021 02:22:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BFE561178 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6A85F6B0036; Tue, 20 Jul 2021 22:22:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 659046B006C; Tue, 20 Jul 2021 22:22:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D3106B0070; Tue, 20 Jul 2021 22:22:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 25D9D6B0036 for ; Tue, 20 Jul 2021 22:22:02 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A821B181200C8 for ; Wed, 21 Jul 2021 02:22:00 +0000 (UTC) X-FDA: 78384994800.40.28FA682 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf04.hostedemail.com (Postfix) with ESMTP id BF792500033C for ; Wed, 21 Jul 2021 02:21:59 +0000 (UTC) Received: by mail-pg1-f173.google.com with SMTP id u14so485176pga.11 for ; Tue, 20 Jul 2021 19:21:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=Xa2qBzVhj+Lwzg0PLQSc5h1ujLhU4dxvWdbFcvIDTfw=; b=SXnOcZ0M8e/9dJtVF+RdQ0y/kMDW3abcs+qkGIoPCTEsFozKmSK82jf2+02L57zLYC jYmgqsfAtoGhhgdRxMjIWYm52f2rP12uQ0HsOTR47XMczrlEmI/trqf2epwZ7HNM/pa+ QrE9oTA0xM6/KaoH212t8N0P/HgCCPh57r0MAI+h5lgVUMHCrcT3h2z6/3vbtSrUV52q Jgtl5vTIWagvcfTskpINygfcsuFhHi16QeSKcD+9VQ+K+rYZDH/OJyDNZ6qOAhwqLY04 8Cl5EpaWOs6HPygLiAD2zjQNZT3LEKvLV97l1d9D9YhFKP3uP5pT73FV/TykavGBSdcQ SLMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=Xa2qBzVhj+Lwzg0PLQSc5h1ujLhU4dxvWdbFcvIDTfw=; b=lc45UPTS9qXv+6DAzpRFJhVZFLbDjW/bv0fyEazFDf56kxbcd3HMYSksnBdv6gtEZE 7mHanXGtUGlgsL9zgMFg3I2+lV8fVrT7Sm8Psq/4cbrL61L6gWCaThLt4luB81xABY22 A/pF8+UoVYad0QnxTnEUbymUFYAl4DhhTdAahvv4MRX68gk/1d2tkUTI9uuoPwj8O7Ye u7eVCdPJKiAGo61uQKVTi9rmShLiqMK/V3O6MRGT3MfzN/QHm3kPTAYacWLPvKmN5/mr 2oOXCTZsm1DJpoJv1tIDpZh5RaNc1J58RfjAW3fyu8l5ucJ+mifKjhK/lgrZU3hKdM/L BPYg== X-Gm-Message-State: AOAM530LyL4M/gPEB5iF/4+UT6F5XaM09tgp8MK4hkYGz2/pjnFLNXc3 iEFAxq62kWyZMHBUPw20kUcc0A== X-Google-Smtp-Source: ABdhPJwS6Lzpa5Vs2Z8wzgBskUrWY6TXhY1ph6ulpI4RrbxgxkYEI8hVxvqHQoiYdxs5NDFF5jtyzA== X-Received: by 2002:a63:5442:: with SMTP id e2mr34013774pgm.365.1626834118464; Tue, 20 Jul 2021 19:21:58 -0700 (PDT) Received: from [10.76.41.210] ([61.120.150.77]) by smtp.gmail.com with ESMTPSA id n14sm26773984pfq.177.2021.07.20.19.21.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jul 2021 19:21:58 -0700 (PDT) Subject: Re: [PATCH 1/7] mm: fix the deadlock in finish_fault() To: Andrew Morton Cc: "Kirill A. Shutemov" , tglx@linutronix.de, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com References: <20210718043034.76431-1-zhengqi.arch@bytedance.com> <20210718043034.76431-2-zhengqi.arch@bytedance.com> <20210718212814.suvziikndiyezi6m@box.shutemov.name> <9e97cedc-9fd7-4290-9f44-04b96acea15d@bytedance.com> <20210720161421.f4874db77e0b13192d0ab895@linux-foundation.org> From: Qi Zheng Message-ID: Date: Wed, 21 Jul 2021 10:21:47 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210720161421.f4874db77e0b13192d0ab895@linux-foundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=SXnOcZ0M; spf=pass (imf04.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam02 X-Stat-Signature: fc5gwp35fw6wkeh5f413ys85jsa7bn6o X-Rspamd-Queue-Id: BF792500033C X-HE-Tag: 1626834119-561150 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/21/21 7:14 AM, Andrew Morton wrote: > On Mon, 19 Jul 2021 17:53:12 +0800 Qi Zheng wrote: > >> >> >> On 7/19/21 5:28 AM, Kirill A. Shutemov wrote: >>> On Sun, Jul 18, 2021 at 12:30:27PM +0800, Qi Zheng wrote: >>>> The commit 63f3655f9501(mm, memcg: fix reclaim deadlock with writeback) >>>> fix a deadlock bug by pre-allocating the pte page table outside of the >>>> page lock, the commit f9ce0be71d1f(mm: Cleanup faultaround and >>>> finish_fault() codepaths) rework the relevant code but ignore this race, >>>> fix it. >>>> >>>> Fixes: f9ce0be71d1f(mm: Cleanup faultaround and finish_fault() codepaths) >>>> Signed-off-by: Qi Zheng >>> >>> Acked-by: Kirill A. Shutemov >>> >>> and add stable@, please. >>> >> >> OK, I will add these in the patch v2, thanks. > > Please send this as a separate standalone patch, not as a part of the > main series. > > Also, please include in the changelog a description of the user-visible > impact of the bug which is being fixed. > OK, I will do this. Thanks, Qi