From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2687C54F30 for ; Tue, 27 May 2025 06:26:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 371CE6B008C; Tue, 27 May 2025 02:26:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 348AE6B0092; Tue, 27 May 2025 02:26:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2855A6B0093; Tue, 27 May 2025 02:26:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 07D206B008C for ; Tue, 27 May 2025 02:26:51 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 80C86160117 for ; Tue, 27 May 2025 06:26:50 +0000 (UTC) X-FDA: 83487704580.06.C2676E9 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf02.hostedemail.com (Postfix) with ESMTP id 7DD7C80003 for ; Tue, 27 May 2025 06:26:48 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=emz8Yxu1; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf02.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748327208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uTdKZdfSYxh5Xi+IhepiWE/QahNw1PejLfKCqR96OAk=; b=oYJGnbVoBTNAILvzLLVJ0O9x61Ya57Vr6/QA1j6JV5Yyw//vPecSZXWG53Tujcq+N2w2gR SReZKZMqtdTUpa7wTfodsvubvl34fqCe2UTubXZ3gCsL/esci9O/qUfwdPLyk2jkhkInko 922s9Tahb5XCiHdJ9Y7PWbjHbprpGWk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=emz8Yxu1; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf02.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748327208; a=rsa-sha256; cv=none; b=Cj30rj9cfmJutInJBIT5Xz55NqLVpDTF/iUYKsnsFmYWxUUIzTkkenVsbeNgPn9x7R7yaL MlBr8asjQFYsksH9P2ald4LiCea7CptxWM0pu1zB7xpUFF66hJcIJmF5nHV3fVwoRsjpKY XFxaKKCnN4e+p7U+RifwXaRWcj6Fz18= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1748327205; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=uTdKZdfSYxh5Xi+IhepiWE/QahNw1PejLfKCqR96OAk=; b=emz8Yxu18w3An4GFQaT0aFjePfqWrAmNNYL/E6FSheLr5Zdl9G87SEWKHrVtwJ/qKADvhn84jlyP9SyEyOGtKeSbzmK5dGNTXIAdL95IyzewplAkUrVGZGNvJnUjDi6lzeuwT8LsiYtZx98p+18/IjydxrxYcSJlLaB1qMzHgkM= Received: from 30.74.144.125(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Wbxaiaf_1748327203 cluster:ay36) by smtp.aliyun-inc.com; Tue, 27 May 2025 14:26:44 +0800 Message-ID: Date: Tue, 27 May 2025 14:26:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 2/2] mm/khugepaged: clean up refcount check using folio_expected_ref_count() To: Shivank Garg , akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: ziy@nvidia.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, fengwei.yin@intel.com, bharata@amd.com References: <20250526182818.37978-1-shivankg@amd.com> <20250526182818.37978-2-shivankg@amd.com> From: Baolin Wang In-Reply-To: <20250526182818.37978-2-shivankg@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7DD7C80003 X-Stat-Signature: ux7k7cynhr7wwctm41acp5e8zwmzo43g X-Rspam-User: X-HE-Tag: 1748327208-599086 X-HE-Meta: U2FsdGVkX1+R3ibcIzG5nKQY2mSVdg3UTBgCsg+QwDY76OptBf65VH2V4B1nW66zsN6FJaN2TDwATuRTJHX4XysabWahZVcvb8frg8s2gLHpPqxnxk2YEo7pf7ugKz6FMjxIA+PJa84KVV6ln+DENlN2dCcO65Ar0GGM1Wa0mNvvLKXWEBaipnIfoWl00BpRMb6B+PCwSLXBHYbOMI8Y3XdiU2+jDe7AGzgIacag1RlYqu/k0er8A7rXh3uFF0QltWzo40DO388kWiqhrzm1XCahdJVzhx/xrpB0slVgIs5G2DTPU/eMwerKASuAYIogtxjF77u08KrYOvA/mlU+DIyZiEmOOdOfNpdxC0H0iojinYA+jHrp74vT1oL5kKgPreH8oEFDnCFBsPWXxQC9imEJuI3hQ2xbZC5bKHdHQmwXl2B14WbLbvuAPC5cI90R/e4bQOa6/1ZgmvaSgRdaI/gcW2lNvQglY4TQxNKKLzmhvmANoLjYE2x9o/ZU9XLVhEAutSzGAZr02jZOM2iGPuzq3Rwj7oxLFn20j15UZVQbhwVoL/CusKuVFghV/pDm4/WpHmkxENvz/tp+QGaSLxobwLCupGHyyrONG1gWBt/CYF9yl7RhAbO6YvVEoHKvs4U2L1Fzhy0vKEl71DwXINDkP+Kj4vgWvFqlIUyw0TNL2JV/3VfxgQm9SYsqYWSPBfVDpt9s4salzcTXfNFMOz1zDGK6EiFbQoujkRXOp4vkDrCh5LWytNoeOr/FMb+clQJbfumvC3CWRzsSS9P6KKAPfvG+LX3uCpt7E/Oz+pcuIrfAio7biNWd26Wx2GBAs5x0NUNNvbGvD+EKW9gb2asZ+08DVz3zNR+q7eZsx0aHNNUUXjMh/ZU8sr+sb9+c5xLBIj0967Dm1GorGAyu1cGMuCoRji346l12JMcGu6V1tYzCwT+0XdnRKp3qfsHP4X4HCuJ67OUD/1usx73 B+Xa60EJ KRWRH55fm4KHOcr4lXKlYujIl1AitTF2+sq38KZrJbCP0IYZ7Shg+fgsxkQDNJsXe61nzrSK5adXtyb+KArJ9JWbssG/N9LQAxY2g4FT/yA0l7vjg2dMzyW8zwaWwmQWBuJzmSCyJPkT0T6z40Tk+Q1Q31b2xW3+XZfXGsihMpgQ95PYG4pW2SszT5lHptIadOxvgp5k7jpMpA93050IoQgz9ZCg7lSW/4K4JDFiJYwk0/7e7AGulT+dwTXkOF0U8UGKJ0xP6WlUXJTbcjm5XZXm0BFWeyZ/jcTpPaPgaNH0NkyDkv3zDuUu0lQN9rcIcwK/fshPShJviG+HCSAJ5Se2dJo4yHeAtd8+a+TPdyx1wVFc05FUN+BRV+xprMt/ALm8vESdHlYk0o/pktTGTM4Rc9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/5/27 02:28, Shivank Garg wrote: > Use folio_expected_ref_count() instead of open-coded logic in > is_refcount_suitable(). This avoids code duplication and improves > clarity. > > Drop is_refcount_suitable() as it is no longer needed. > > Suggested-by: David Hildenbrand > Acked-by: David Hildenbrand > Signed-off-by: Shivank Garg Nice cleanup. Reviewed-by: Baolin Wang