From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD86BC05027 for ; Fri, 3 Feb 2023 13:16:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E6456B0074; Fri, 3 Feb 2023 08:16:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7964B6B0075; Fri, 3 Feb 2023 08:16:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 610636B0078; Fri, 3 Feb 2023 08:16:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 540B66B0074 for ; Fri, 3 Feb 2023 08:16:24 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2551180F6C for ; Fri, 3 Feb 2023 13:16:24 +0000 (UTC) X-FDA: 80426029488.29.9132788 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf09.hostedemail.com (Postfix) with ESMTP id 4ADE3140016 for ; Fri, 3 Feb 2023 13:16:19 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bNLKI9f4; spf=pass (imf09.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675430180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ax1Q0M+X3wSFC9ACg81a4ooNaI5a2RFV1OgjoAvNP6w=; b=CaDLUKN16nSeEBYuWCKmInLbyFA4A4pXKqgWBBbfZTqrvb28OVaFBweM3zKaAcXLiAhIWI Yn9t45RqvHQSn75nh73bnJzkgGcQOSs6NrtDNqBHukMEPguPD0CI7+1lhP536qMLQ21rFU vJR3SeabpaELMWJN79VuQLChvxC0B2c= ARC-Authentication-Results: i=2; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bNLKI9f4; spf=pass (imf09.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675430180; a=rsa-sha256; cv=fail; b=KDuUaSzcuiS23CBXpnmaAGszSQvWWnam7a7tDwTcdOraj+aN9kIpmdS5GfUcD1tj3IbdI6 4LPg2ZbU7VpvTZ7R8/yQMbz8zF85SUy/LEAMYPhxIu0GNak7VDg3d74lLCZCJQWUV3vErg hZagf6GqY32tUlaKW0ifw9pFrrnRbic= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675430180; x=1706966180; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=HFQ5+lxcKLOvT6aRNugMr2/gQtqsqB6yMenRfFV9VoY=; b=bNLKI9f4Uw/eirkbeQZmb6slbmaPl9cBYaNLCyjl3C63YwsW9tnutcs6 +/vVjijwqRq8ab7MtvrmCEQuvSxmayxoJiSRaJcv+8Wtw03vREJmz6tXN A0f0NA/8hEXHyaHFLqYIDfG9AxahtBi8/yoo3DxL2pSWCpqI68TIbacCR t3mxzgH0RCmC5WE6zRPXt693n2PGP8ofRqwPrzmgwJEOst7mUg14WzzbY OGPT13SSGk2/EvIb5VBjxGfAPpwct5f+2+Fou+uVWibKCWY+L2YN/bFS2 JqzREV1lmtn9+QMf2nqZa0azhKIRpvKdxwfqzsqmEMLCGiG6imY1mIjgs w==; X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="308383837" X-IronPort-AV: E=Sophos;i="5.97,270,1669104000"; d="scan'208";a="308383837" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2023 05:16:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="659096627" X-IronPort-AV: E=Sophos;i="5.97,270,1669104000"; d="scan'208";a="659096627" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 03 Feb 2023 05:16:17 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 3 Feb 2023 05:16:17 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 3 Feb 2023 05:16:16 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 3 Feb 2023 05:16:16 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 3 Feb 2023 05:16:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LnAf0GMlA8LDHjE2aWzOPgghheQsANBKVSHC57CeRPy9i2+2oni1c5TIlpAh/owEWM6+Q272Gamwqn+ovVZcHKUmXRGkbH+vbDjUtuLO7eI989h2ZROMxPgveko77T60dkBB3ErFbHhTaDemRfJGbSKrCJNPgi4K2NqCm0Ces3LKKv0h0qrdlao5EWayf+fySZjS75+0HjZDXNLt73aLalu/VokLxrx10FF1fpb4koo3ASWqSJ5IGsIR8jaThHY/wCbEafgWKkqymb4ScHuD6OfgFb1r2QDLyreFhan3VAs/XETCSWedaafpJjtLt41TjRXSLrKOGaqW/g7IxFne/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ax1Q0M+X3wSFC9ACg81a4ooNaI5a2RFV1OgjoAvNP6w=; b=GLX+Sz/aCpdMlBAPI5T9PTrb66QEvWzoYjka2y9Tkuz3q6nO5hPlY6lR3/LvJ66ntav3cki1aQLARht3xKqckJL7fFkONgseM5gS7Uixo8u0FQmqjLxe6sICkQOhz1bQVC+08ES0xb87aqWOq5IS7rZm4NO50A+eUVDj7/qOzc/yiwqe1JAEW40BxiMiROwKImF6wmGfbDokaga58/BhIpDrdNR3CWXvdUcga9Hy/08kA6sNOvPc26sh7HPLiU04MamHDtPJBtCcTcwoNCVvRHtHwaPLBUYJovuCPQuK6Gw2voXmfVo1XhjzoQmZ/J9U/qJPf4rnWQQfTWhV6RdN+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by MN2PR11MB4632.namprd11.prod.outlook.com (2603:10b6:208:24f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Fri, 3 Feb 2023 13:16:13 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::1531:707:dec4:68b4]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::1531:707:dec4:68b4%3]) with mapi id 15.20.6064.031; Fri, 3 Feb 2023 13:16:13 +0000 Message-ID: Date: Fri, 3 Feb 2023 21:15:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [RFC PATCH v2 5/5] filemap: batched update mm counter,rmap when map file folio To: Matthew Wilcox CC: , , , , References: <20230201081737.2330141-1-fengwei.yin@intel.com> <20230201081737.2330141-6-fengwei.yin@intel.com> Content-Language: en-US From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR01CA0145.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::25) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|MN2PR11MB4632:EE_ X-MS-Office365-Filtering-Correlation-Id: b83317c3-f6a8-4130-3aa7-08db05e8d2af X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r8XKWRD1Z9S8QtQ/oAqJPtBM31M8q9fRE3YjqzBEZYLD86gIviOImgN3RTY2/5Pfqc7pIdC6C418hm8NBOZXUL4iNPb+10g/cr/080N7fbFnginvrhN48eI5hu/24QaiS0t3oN5Z+N/1RtxL8qor0F//a/zftBebEBjMcfSUnJakjUxWtFjmEne72FfZ5bwjKAqtfqQqJJNQ/diQ9vt1VZluqWu2I28Qc4cDCh5TgiqIf30MmLK3ZanW3LmjtZ516Rfl62+8j5gWAk8PnZz8HPhI69FFrGgC6gQkqD0JnK7lcF1lNca3M0VqfFir5h8Z5W49IrcRog78y8x1kYEV4H2n0OHERTHoARzg2rVKJCBDRojfmCLdMmfjQE5lYCrH9PbqJdCz65p9tCRYeFOfR33HOXMXZcdOp5wx2SBhtqH5ws/lWlNWgfnOEUfvk9GHGEbaALojgWz0sIoPQ2HLxy/wxziAxHYJ90BVLQ9T10bnIYyYlb4rfdA4DZdh02SLKr4VPHwnOiEYZ+Oi6++ppQO89beFHbme1uLWSux1YsXFayLODqp3cL+N7hW+3ndD8+fGkw3IlnQoUq+gDo5jch35cAilPBno+p3EBSFUoDUnBOdPwgew4rYyx+DN7becd6+ITbiLFCvZKbI6GdKzIi8R+YRFdsCOi+/mMHMnthLOFQieay/pDWA6ZiHYlDI8ZFDJZxkfVXqsOF7hf8iBkErBMNqs0lEiQ2XOfnDLKTY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199018)(2616005)(83380400001)(31686004)(82960400001)(38100700002)(8676002)(66946007)(6916009)(31696002)(66476007)(8936002)(66556008)(41300700001)(5660300002)(15650500001)(86362001)(2906002)(4326008)(107886003)(478600001)(6486002)(6506007)(6666004)(316002)(186003)(53546011)(26005)(36756003)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVN5S1A1WFNMS2FPNExQeUhseEx1YldCY3ZWaCtiVE9QOUJZc3lXcnM3N1Qy?= =?utf-8?B?RmxyVDNBK3dNK3VZNVY1cVJDK3NENDhWcE9XMDdWc013SnJXSVNLaFNMYjlv?= =?utf-8?B?NGFJVit2bVJSZzJrVnpOV0gyb2F6RTRWRWZGclcxMTdqZk4yaC84OEZYeDBr?= =?utf-8?B?c0JJaFN5YVZETXk5UGdVU2ZlQUt0N3N1VjRoc0g1S0dWUHZnWWF1V2EyL2Jm?= =?utf-8?B?OVpmUnBDRXd0bFFZTnNqN1RtYTZCSURlRmRjcVBOZ2xDS0lsdWdqL0RsMXpz?= =?utf-8?B?YjJDZkM4UEhnZzVmWVVLQXdPa1hBR00xaTBXVzVvOHFUSHY4L3RhYW9FeEFU?= =?utf-8?B?NjB5bXBTc0lUQkgzRTNuMmdXekNrNUtraXdrQmVhS2pQaXhOdldSaUQzUmJI?= =?utf-8?B?M2piQ2hjazJzWmdRVXMzYkZqYmJOeXNKMG5vczlDSXpZNlhDaHA4VDFJOHBy?= =?utf-8?B?eUFIeWZwa0IxdUJ5aTA0TThsZUQwL2hhcVNNSE44S08vYnJubGNhOEJ0Slpq?= =?utf-8?B?WnFibU1jVDQ1U1ZoRS94SWh1OFhnWTdsbGkxRHRUWkRqSXdnckM5L3I1UTJN?= =?utf-8?B?dkZMcURJdFprenUwdXJSYVVMclBBY3VOZ3d4NnNlU0xad2dFaDA5WEFVTFE1?= =?utf-8?B?Vy84TUNNMGhQd2xuUmYzdDR6TExRNHJNalRaTFZ0NXRkSjR3c0VXWjB1K2lh?= =?utf-8?B?TFJ2VkFpVG1BZGFRZmtoaElNRThsYi9WczRjWnZNcktyS2RWQTRwclJmK0t0?= =?utf-8?B?TXpMRGN4MDA1eVVBY1NkNTc4aHpYTFgwMnEwUzhuL1NVQk1DRnJWa3JWbTRs?= =?utf-8?B?VWZubUk5Ni8vbmdweEZkOHJUaklKSmVJSWJxY01UWEY5UFJNdDFFU3prdHFi?= =?utf-8?B?Y1p3ODAydFB6T2NZVnN2Z093eDNGZWZPK2g3ODQ4RWg5aEdOTVBGK0ZaOU1a?= =?utf-8?B?TjRLMVAzdGRpYVlMUVZ5azJEWVZ2NU9wc3pQNEExK2ErZVlOdHlzdGFZdjJF?= =?utf-8?B?ZHlqYXNWNEhlbUVxMERrQUVQbzBqbFN5MHBQZUVmL3pvanp0K2tTSGo4VVBo?= =?utf-8?B?ZnVGZ0IwTHYyaDFuV1phcUxQL0Y4Ukx2cWV1OHN2QXd0ZEgwY0Jtai90TytG?= =?utf-8?B?UnNPdU5tOU5zRTY0VGJuWlBIdndQQ1p0VG1ZV0gxN0I0QTUvalc4c0M2RWQr?= =?utf-8?B?RXZxU05WRlp3c0k2ampTSUhLakJqaW5JcEFoRThaT2VNbDdtN1VMdWREejFR?= =?utf-8?B?emluazNPUkJ1cHFRdERUOGZiMlFEUUsxY0E1Tk9tS0FnN2t3UWwrR1l0TUxP?= =?utf-8?B?SFR3ZjZYN09veHZuQTUwbDJyY1J1aTU2aHZ1OWMrUHloRzMxdUM5djY4a3g1?= =?utf-8?B?NlE5NHZXM1ZOYjY0SlpmWTVMdnpObXNJUm5qTk1KYmFzUG5MMWxOcWY3WW9W?= =?utf-8?B?TU9McC9WaWZPSVZjaUNyemJaYTFzbk1aQzVvQlZNMmozbmZHNHIrQU1CWHln?= =?utf-8?B?eFI0U1g0eTVtUWlGenVvd0I4UTNUbHp4QzEvYU1vS1U1c2dRN0RRdkdkdmc3?= =?utf-8?B?ejdLaGY4NG5rVjZrZ2didit5N1FxY3QvTjdvbFUxUDhPbjJRMWpUTlVCVGhE?= =?utf-8?B?K0d4TUt4Rkw2YlU4c0ozSGdQbmdCRmpHb1RVN3JFOFVQZXhESVViY2dQQ0lY?= =?utf-8?B?bzNxNUhZa1Urb0hXNXJucWpCRTRzcE9oVVBDdWMrcWJIS215WlQ3NFRxem16?= =?utf-8?B?MGMzME1IQjRXNmgzOUg1ZGZGNXYvNEJYaHZJeWYxRlk0SkZBUU4wamxRZ0E5?= =?utf-8?B?TjVuenB6OEJKdmhtbEdrN2lveE10WE92K1NqUS8xSlIvTlh6eDZJeXNhOU84?= =?utf-8?B?dDIwOXhXU0pEWUhHaTlVbTB1V0JPMjhFaTlPa3ZjNmJweWNIZjlKZFkzcXQ5?= =?utf-8?B?dkxrTk5PMExabzIrZ3RDSEwxbW9tRmRUTEk2VnQ0dGV1UGRSR1NkQ1NyaDVH?= =?utf-8?B?L1VHMkdhcVpLZE9qR3FUaUh2QmFKQUQwZi9jaTdYL3A2aWtrZ1REYVMzOVIr?= =?utf-8?B?L0cyUWE0YUR2Y0VZYXZpR3lxc3ZNbXY5UVhUZjNYU1RUSG54TEs2a2JBV2xG?= =?utf-8?B?RmIrUFpROUpyOWNVTkU3Y0V4UjhremNIbVRxWVUzdjlGd2NwM1JtTUpPV1Z1?= =?utf-8?B?Rmc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: b83317c3-f6a8-4130-3aa7-08db05e8d2af X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 13:16:13.0494 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PYiQypw/v7SCLugIi+1Np/Djhbby84vHe5LY2XOJffXRhp0ZB15PBbyG2RZEZ2do1WSgtSZigheMKJO8+KuC/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4632 X-OriginatorOrg: intel.com X-Stat-Signature: hohxw9qpjtug7h43ej85dx8rqpf19xdk X-Rspam-User: X-Rspamd-Queue-Id: 4ADE3140016 X-Rspamd-Server: rspam06 X-HE-Tag: 1675430179-669874 X-HE-Meta: U2FsdGVkX18/J3a4ItuCk14hpG/xx6nmUVky6OKPwmna9EXuc287vKevMW74zWjTnFfOGRih0As3STREXKyHC213PvVjx0Lr14KEZo97BpBeGa7yofsuMcoDb1K2JiOuMagsUG+lAUfW1ktP6dK1cGPnxvQRBtt8BWaxfI3TsXCJK4hACnf27JPlWJxV7viXaXAA6jcJIh685yDpx/v/iz4jsrDwDurs14q5l+BvZOrzVQLkMgbN2c+sXNiWVi7ppfvyErZYUrI4id0zTWK5o09qb0ETZx9fj/L0DP3sTZTpFvhMQzd+Irclt2x/64aMY+75f0g/D8ZUJui5GmYQ2Ndu/+0WFT3KMmdUQUqMipK3N2kpL5OhSuMUDoIWgshVPG72O6cHy6Aha4+dc8wPSZE8mtzlGkPmiIy23FpItLJESa0QmEhxcT7ZeXqV3hPkz+tzm9zD4k100e1etVj5EOb6XLDdokVV7x0MmdwKr9y/2t9zwG9ClIyyvW5r9vhE0AYDRLTS/y7sI6FMdL8++BjA2XXfy9TxpEW6fT9n5S0ERtM2Y0xT5t2I6TiWiVeCZfbKw+EirP+83Ros1ZXVcXObPa/pLHU2xuGnUWawbvM2spbQGVsy306+qGhBvprau1KySEbdDmlnNlFQo0EFV/t5HGBcM3xo87x8G6wckeqM6L2XdJVViNcUbfbwuHVyIcddwgG2DdDiITK1qsvSlsKuX81AeYWn4008kv3lFD+3cNsiehdNXLRNGdSKPmowGZ4DijQ3U7DyvsuH4j8jgRLyow+eAhYUeLioROCXVsjYmwC2KpEeD9Y7X2sNR2dkvFD/5W8xHbFSQx7hHO1eYqYJYgqZytfBJ82Yc3jg7tVGbf0nxZixoThVIGOtqtl5fKrFOUIDLpvjrD56+PSgDGABWQn1hclsqOoHrt9YkuVvZvJ1VECEyFDZ4c04hyS1kfFLTPheiHY55mWHUiK D4Sv3zxE BY9zleJqCmzVrdNYKcobm00sNQ8pE8q9Yq/9Nq8jXD58Iu69Q7tFDZ31pSOTxEDFTAKSRvdWA7C3LJtiKgv/NxEE3XGE1TEl0pXaACQXtNa56Nlv376kBs5aA32f3RNZHkq6teTxSW/BWyW06k3PDw7X1AzM0MoYSbXG2WkF0RmXPJ2IWeqravSWbqwDSezCHQ59VRdv338M+kIiN2OIJ8u7nsEzw6v+2FK0M/SizRKn4lRIh4HGS66/k15n2pV5mrI3t69durO1NCd7Zy9cApii73M89vAtc5finykaExaRmyf4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/1/2023 11:50 PM, Matthew Wilcox wrote: > On Wed, Feb 01, 2023 at 04:17:37PM +0800, Yin Fengwei wrote: >> Use do_set_pte_range() in filemap_map_folio_range(). Which >> batched updates mm counter, rmap. >> >> With a self cooked will-it-scale.page_fault3 like app (change >> file write fault to read fault) got 15% performance gain. > > I'd suggest that you create a will-it-scale.page_fault4. Anton > is quite open to adding new variations of tests. > >> Perf data collected before/after the change: >> 18.73%--page_add_file_rmap >> | >> --11.60%--__mod_lruvec_page_state >> | >> |--7.40%--__mod_memcg_lruvec_state >> | | >> | --5.58%--cgroup_rstat_updated >> | >> --2.53%--__mod_lruvec_state >> | >> --1.48%--__mod_node_page_state >> >> 9.93%--page_add_file_rmap_range >> | >> --2.67%--__mod_lruvec_page_state >> | >> |--1.95%--__mod_memcg_lruvec_state >> | | >> | --1.57%--cgroup_rstat_updated >> | >> --0.61%--__mod_lruvec_state >> | >> --0.54%--__mod_node_page_state >> >> The running time of __mode_lruvec_page_state() is reduced a lot. > > Nice. > >> +++ b/mm/filemap.c >> @@ -3364,11 +3364,22 @@ static vm_fault_t filemap_map_folio_range(struct vm_fault *vmf, >> struct file *file = vma->vm_file; >> struct page *page = folio_page(folio, start); >> unsigned int mmap_miss = READ_ONCE(file->f_ra.mmap_miss); >> - unsigned int ref_count = 0, count = 0; >> + unsigned int ref_count = 0, count = 0, nr_mapped = 0; >> >> do { >> - if (PageHWPoison(page)) >> + if (PageHWPoison(page)) { >> + if (nr_mapped) { >> + vmf->pte -= nr_mapped; >> + do_set_pte_range(vmf, folio, >> + start + count - nr_mapped, >> + addr - nr_mapped * PAGE_SIZE, >> + nr_mapped); >> + >> + } >> + >> + nr_mapped = 0; >> continue; >> + } > > Having subtracted nr_mapped from vmf->pte, we then need to add it again. > > But this is all too complicated. What if we don't update vmf->pte > each time around the loop? ie something like this: > > do { > if (PageHWPoisoned(page)) > goto map; > if (mmap_miss > 0) > mmap_miss--; > /* > * If there're PTE markers, we'll leave them to be handled > * in the specific fault path, and it'll prohibit the > * fault-around logic. > */ > if (!pte_none(vmf->pte[count])) > goto map; > if (vmf->address == addr + count * PAGE_SIZE) > ret = VM_FAULT_NOPAGE; > continue; > map: > if (count > 1) { > do_set_pte_range(vmf, folio, start, addr, count - 1); > folio_ref_add(folio, count - 1); > } > start += count; > vmf->pte += count; > addr += count * PAGE_SIZE; > nr_pages -= count; > count = 0; I found it's not easy to make this part correct. So I tried to simplify the logic here a little bit. Regards Yin, Fengwei > } while (page++, ++count < nr_pages); > > if (count > 0) { > do_set_pte_range(vmf, folio, start, addr, count); > folio_ref_add(folio, count); > } else { > /* Make sure the PTE points to the correct page table */ > vmf->pte--; > }