From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 842A0C4332F for ; Tue, 14 Nov 2023 14:43:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2FD66B02D5; Tue, 14 Nov 2023 09:43:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDF8B6B02E5; Tue, 14 Nov 2023 09:43:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D810E6B02E7; Tue, 14 Nov 2023 09:43:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C66626B02D5 for ; Tue, 14 Nov 2023 09:43:20 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9ACD21CB735 for ; Tue, 14 Nov 2023 14:43:20 +0000 (UTC) X-FDA: 81456827760.16.FC22534 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 66196C0006 for ; Tue, 14 Nov 2023 14:43:17 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g0eIosbN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699972997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5SJ3Nn0MswLm+ieIv5vpfuxn2m1fYyMn2DeOZf4gqog=; b=41cZtGjOn1MirMWrM4pOd1sFYPA97cQ9nckpYAm4hEdu2ipwjdypKf7u4U1b3pminK/6rL e/EGfvAQpMTwUe+VnIEz5NWLODRvNNb0t5KyEUxsxbNd3MMbqk+unOduZ35FwFTj2zb0VH wx7EmSO6Vqfa8uDVhIbXgJh7FalRvH4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g0eIosbN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699972997; a=rsa-sha256; cv=none; b=gxYOw7VqyRkZHM4HOMKW9WBFgDN7tNU0vJdEzWrVS/X+h9jOIfSEu5bWjodZT03IpUUAFo 4WaKaRqi48Ak4/bBfMyTRmZj8R8A+SI1RMQPVqgZ9uzUS9+KIjNWpzYVNx8VF35M+F23Dx Vkf+StW8KQfvOrRWFnk8/CM/kNhxew4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699972996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5SJ3Nn0MswLm+ieIv5vpfuxn2m1fYyMn2DeOZf4gqog=; b=g0eIosbN8Y6198o9GCwXUn7y5jNECm1y8dUUUFqW0cOEFoBgylZC+zy+GyuJwv0ExqDATx UhHBX0fvbzQS4eV/oujASyF/Rd6bHs5oNbrNRzM7Gf7MW8QNZTVcMDqEVJryMIB0uRvfnB donqbDH7BQAqVh8mVjfN1OtSMGWeysw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-14-7CztJEG1MwifFr_sPWo2Xg-1; Tue, 14 Nov 2023 09:43:10 -0500 X-MC-Unique: 7CztJEG1MwifFr_sPWo2Xg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-32f8c4e9b88so3002194f8f.0 for ; Tue, 14 Nov 2023 06:43:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699972989; x=1700577789; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5SJ3Nn0MswLm+ieIv5vpfuxn2m1fYyMn2DeOZf4gqog=; b=ClaI/7hbji5Pr3zKz3Kp6J9uP12sAf235FSlE+w7U2XpwUcKiby0+6GLgTlq84pT2e eHmib6tIaHX3AIjJ3r3M+vsojP2LwcjuTXUQhhSDiiXZGHUiHpEVpFECYLY2oYxjdUqc 36Is3qis9pur3ban77HnIwIobxyR/Q49CK0eZ7hFYh5OduWGpSLrITaLtG+okqFV7+VL wEwjXV6IDE+VfSbSkMZ+3HGkhchY4nf0Kth6ISpBW6NpVbsXT0ABJu2TQfhj9mQJJK/g 6iKoCyCcsm15KgnuVVHM/N6QqsRMPxjFUkicEQ6oBe/ijZa9Hy8PqbPL+mLiIAobWRUA gTNg== X-Gm-Message-State: AOJu0Yxs4tJTiHKVw62K8GVSoOnXjw3fuQPy6jLCQ4WTkH1kSAwvoyPu tUq5YmiS0qfY+pcNHVmWRLj6FJ0OeTS/sL08lTwBarBDRg9O51L1yWWR1YrObtIrdDse3Cg+8s7 JifoNDHx+dx8= X-Received: by 2002:a5d:584f:0:b0:32d:dd68:e83 with SMTP id i15-20020a5d584f000000b0032ddd680e83mr2299578wrf.21.1699972988825; Tue, 14 Nov 2023 06:43:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUdIYQpNwmcCSJgMhBTuzh3dWmnDfaflXDgDaBkJU4XDK4doSNxIGSMy3RT+SFNRd7KB/feg== X-Received: by 2002:a5d:584f:0:b0:32d:dd68:e83 with SMTP id i15-20020a5d584f000000b0032ddd680e83mr2299530wrf.21.1699972987458; Tue, 14 Nov 2023 06:43:07 -0800 (PST) Received: from ?IPV6:2003:cb:c73e:8900:2d8:c9f0:f3fb:d4fd? (p200300cbc73e890002d8c9f0f3fbd4fd.dip0.t-ipconnect.de. [2003:cb:c73e:8900:2d8:c9f0:f3fb:d4fd]) by smtp.gmail.com with ESMTPSA id he9-20020a05600c540900b0040a48430837sm13332637wmb.13.2023.11.14.06.43.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Nov 2023 06:43:07 -0800 (PST) Message-ID: Date: Tue, 14 Nov 2023 15:43:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ksm: delay the check of splitting compound pages To: yang.yang29@zte.com.cn, akpm@linux-foundation.org Cc: imbrenda@linux.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn, jiang.xuexin@zte.com.cn, wang.yong12@zte.com.cn References: <202311142036302357580@zte.com.cn> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <202311142036302357580@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 66196C0006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 554oqmun5rssbsz7cetqu6x9irkhuqrb X-HE-Tag: 1699972997-790725 X-HE-Meta: U2FsdGVkX19ibJXIUeMqe/bX80m27iGREVDmExAJ5G+iW24eoPQfMqbvufofYKepkxusj3S8qTvsDAzmPD0pcYw8tyc+rQJz6lSjDm4ckCo3Tv11QJJvtSN+BdJS9950pWfxaIhu6oMDQRbX0R+JOKB2IFJ8lgciORuL4lm5E8AqiA+qMzsh5H5tr1F0N8GwenQ3CBe++cuHQHP1j2d6hj81faC3HIMqbkfUMrfa+utDrOcSr6QQjAQ+cpuQr2ZGDHFd23qOqP2WPOP7A+HDJD+bO2+IyRz+msKAacOR87Gw8BZhX7ho67ciD9/lvsleRM2ttoZ2yCbuxP2jDeNtgdue14wLWBefB+AK/1fwWigRgxSX0s9zyAevnJ8kV5YgIXzYUnsG/R07A1d+DLqGTkFPHUsBpf6/g+J6Vbp2ludHCG1TUnP3COIJBaKNFPf8BCfi+z0hgWHiOV1suJm3Nj0jM8hI2nZ65VVUM9Y8iaMY1hVYzXiV64SUEpIBZ9dYK/H0GAq2gIqDjDEstXZv1Wd6RX+8ieP/C1hfiKWoi4Qjsz/l1+BDBC4OU9MTPi/mT8jw8KKvmjo4yMIA0ebmD+MZ0jk2elMAvzSbNFqKkyRzOI8Gdn6nXBl711Jw6n0RqwOOvbpyCH6BsnFQVzYH8JZd2LrruD/kPWpnDuyvQKBZjgVAUKzgwXsYPABe49qVAqQ7lmlU44n6UbXJw/y6Zm18G5nKXL6qKW3f2r/varSbCtg9RkMun3hd8VutNQbG8FwsNVIjR1PZdmkI2YdZvXAbSNlU2XBeVt/7LWH3VydONVy36Hua8jISpyOGASdILgJPhe0c9+9icSF3Nd1xK7ZXNFGAQErdQnLBSDUqL1BIfwzEPJrEb88NguHu48+TSr/olWG57oGHY0+TvrudyaZm/v6OH4Idc94qKf3zuiJUjQqg94FHUmqwmEVysJmyMhA/b7BkggX6LhMjrYH tvI/7j5m qpmYIEGvSPjWNZ0/pjw3S3nxZ8rHrxh4YjhJOIaDrBWsE5/fkyBiq+R1cnIgrVn9L0blMuzwYQP360Q/+OU1umPWwaX6Ig88luCPrxvEHQUICqUAm6S6EIQSErSAaWSqIU8Jbs1BCk7ZXPo5RuelzUd6oBVbU6jZRzxDcXvN0PD6V0mxRkuLfGnXizEFWq5jMk4ir1WtAvSRfl5hYLEJ0vmLv+NHiU3V45OSrw1qCkOhcvGZFnFwfnJEv8eaUa9ujkc7+Kdl0KsaHMDxKZF9h3W8R8/C1IXr4Y/Bwy5Wk7GRemxgsU3/rmjG/GMYz6FX/sZls+oRwZEtYoP3egDMeud4i1QXQixDPGL2GYgbk+c97leTGPy2St9osSBQD7hsEGcMpQ0PdLNz+l/HEOLFjnXoDYlR6sRJJCh8Wt42F7eRHPWT/vTBxwlUi/UlFkA8IB5Um+LC5bA0tMyOFZkrzYKx8YBnql7iY1XUuXfU5yTQ94pYgMzZGP0yg2QDTi+1UCQLGe8DF1UUlJZTPMdtAo8mtRkdUMnUZCqmGBL0FecRpafo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.11.23 13:36, yang.yang29@zte.com.cn wrote: > From: xu xin > > Background > ========== > When trying to merge two pages, it may fail because the two pages > belongs to the same compound page and split_huge_page fails due to > the incorrect reference to the page. To solve the problem, the commit > 77da2ba0648a4 ("mm/ksm: fix interaction with THP") tries to split the > compound page after try_to_merge_two_pages() fails and put_page in > that case. However it is too early to calculate of the variable 'split' which > indicates whether the two pages belongs to the same compound page. > > What to do > ========== > If try_to_merge_two_pages() succeeds, there is no need to check whether > to splitting compound pages. So we delay the check of splitting compound > pages until try_to_merge_two_pages() fails, which can improve the > processing efficiency of cmp_and_merge_page() a little. > > Signed-off-by: xu xin > Reviewed-by: Yang Yang > --- > mm/ksm.c | 36 ++++++++++++++++++++---------------- > 1 file changed, 20 insertions(+), 16 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 7efcc68ccc6e..c952fe5d9e43 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -2229,24 +2229,10 @@ static void cmp_and_merge_page(struct page *page, struct ksm_rmap_item *rmap_ite > tree_rmap_item = > unstable_tree_search_insert(rmap_item, page, &tree_page); > if (tree_rmap_item) { > - bool split; > - > kpage = try_to_merge_two_pages(rmap_item, page, > tree_rmap_item, tree_page); > - /* > - * If both pages we tried to merge belong to the same compound > - * page, then we actually ended up increasing the reference > - * count of the same compound page twice, and split_huge_page > - * failed. > - * Here we set a flag if that happened, and we use it later to > - * try split_huge_page again. Since we call put_page right > - * afterwards, the reference count will be correct and > - * split_huge_page should succeed. > - */ I'm curious, why can't we detect that ahead of time and keep only a single reference? Why do we need the backup code? Anything I am missing? > - split = PageTransCompound(page) > - && compound_head(page) == compound_head(tree_page); > - put_page(tree_page); > if (kpage) { > + put_page(tree_page); > /* > * The pages were successfully merged: insert new > * node in the stable tree and add both rmap_items. > @@ -2271,7 +2257,25 @@ static void cmp_and_merge_page(struct page *page, struct ksm_rmap_item *rmap_ite > break_cow(tree_rmap_item); > break_cow(rmap_item); > } > - } else if (split) { > + } else { > + bool split; > + /* > + * If both pages we tried to merge belong to the same compound > + * page, then we actually ended up increasing the reference > + * count of the same compound page twice, and split_huge_page > + * failed. > + * Here we set a flag if that happened, and we use it later to > + * try split_huge_page again. Since we call put_page right > + * afterwards, the reference count will be correct and > + * split_huge_page should succeed. > + */ > + > + split = PageTransCompound(page) > + && compound_head(page) == compound_head(tree_page); Would split = page_folio(page) == page_folio(tree_page); do the trick? No need to mess with compound pages. -- Cheers, David / dhildenb